wikimedia/mediawiki-extensions-Thanks
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Thanks synced 2024-11-14 18:44:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Thanks/thank: Add tests for thanked cookie and getUserGender()

Browse source 
Added two new tests: thanked cookie and gets user gender. First uses jQuery cookies and second uses Sinon fake server

Bug: T160267
Change-Id: I8f5dad9c90e930d557e86acb4b175ec549849e7a
This commit is contained in:
takidelfin 2018-11-13 22:02:18 +01:00
parent e18f2c09c1
commit 957ee53679
2 changed files with 70 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/ThanksHooks.php
View file

@ -32,6 +32,15 @@ class ThanksHooks {
'targets' => [ 'desktop', 'mobile' ],
];
}
$testModules['qunit']['tests.ext.thanks.thank'] = [
'localBasePath' => dirname( __DIR__ ),
'remoteExtPath' => 'Thanks',
'dependencies' => [ 'ext.thanks' ],
'scripts' => [
'tests/qunit/test_ext.thanks.thank.js',
],
'targets' => [ 'desktop' ],
];
return true;
}

61
tests/qunit/test_ext.thanks.thank.js Normal file
View file

@ -0,0 +1,61 @@
QUnit.module( 'Thanks thank', QUnit.newMwEnvironment( {
setup: function () {
this.server = this.sandbox.useFakeServer();
this.server.respondImmediately = true;
}
} ) );
QUnit.test( 'thanked cookie', function ( assert ) {
var $thankLink = $( '<a ' + mw.thanks.thanked.attrName + '="8" />' ),
$thankLinkNonExisting = $( '<a ' + mw.thanks.thanked.attrName + '="13" />' );
$.cookie( mw.thanks.thanked.cookieName, escape( '17,11' ) );
assert.deepEqual( mw.thanks.thanked.load(), [ '17', '11' ], 'gets cookie with two values' );
// Makes the 0 100th element
$.cookie( mw.thanks.thanked.cookieName, escape( '9,'.repeat( mw.thanks.thanked.maxHistory - 1 ) + '0' ) );
assert.strictEqual( mw.thanks.thanked.load()[ mw.thanks.thanked.maxHistory - 1 ], '0', 'loads ' + mw.thanks.thanked.maxHistory + ' ids from a cookie' );
mw.thanks.thanked.push( $thankLink );
assert.strictEqual( mw.thanks.thanked.load().length, mw.thanks.thanked.maxHistory, 'cuts a cookie to ' + mw.thanks.thanked.maxHistory + ' values' );
assert.strictEqual( mw.thanks.thanked.load()[ mw.thanks.thanked.maxHistory - 1 ], $thankLink.attr( mw.thanks.thanked.attrName ), 'adds a new value to cookie to the end' );
assert.strictEqual( mw.thanks.thanked.contains( $thankLink ), true, 'cookie contains id and returns true' );
assert.strictEqual( mw.thanks.thanked.contains( $thankLinkNonExisting ), false, 'cookie does not contains id and returns false' );
} );
QUnit.test( 'gets user gender', function ( assert ) {
this.server.respond( /user1/, function ( request ) {
request.respond( 200, { 'Content-Type': 'application/json' },
'{"batchcomplete":"","query":{"users":[{"userid":1,"name":"user1","gender":"male"}]}}'
);
} );
this.server.respond( /user2/, function ( request ) {
request.respond( 200, { 'Content-Type': 'application/json' },
'{"batchcomplete":"","query":{"users":[{"userid":2,"name":"user2","gender":"unknown"}]}}'
);
} );
this.server.respond( /user3/, function ( request ) {
request.respond( 200, { 'Content-Type': 'application/json' },
'{"batchcomplete":"","query":{"users":[{"name":"user3","missing":""}]}}'
);
} );
// eslint-disable-next-line vars-on-top
var maleUser = mw.thanks.getUserGender( 'user1' ),
unknownGenderUser = mw.thanks.getUserGender( 'user2' ),
nonExistingUser = mw.thanks.getUserGender( 'user3' ),
callbackDone = assert.async( 3 );
maleUser.then( function ( recipientGender ) {
assert.strictEqual( recipientGender, 'male', 'gets a proper gender for existing male user' );
callbackDone();
} );
unknownGenderUser.then( function ( recipientGender ) {
assert.strictEqual( recipientGender, 'unknown', 'gets a unknown gender for a existing unknown gender user' );
callbackDone();
} );
nonExistingUser.then( function ( recipientGender ) {
assert.strictEqual( recipientGender, 'unknown', 'gets a unknown gender for non-existing user' );
callbackDone();
} );
} );