From dae848638e637b7c91c90b9daa81fbce51952d6e Mon Sep 17 00:00:00 2001 From: Douglas Gardner Date: Sun, 24 May 2015 12:04:22 +0200 Subject: [PATCH] Remove message reuse for "send thanks" Split the special page heading and the submit button into separate messages. Previously, they used the same message key. c.f. [[translatewiki:Thread:Support/About_MediaWiki:Thanks/en]]. Change-Id: I3611a0d7716ef3b0fd9d8b981a0445800906e039 --- SpecialThanks.php | 2 +- i18n/en.json | 1 + i18n/qqq.json | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/SpecialThanks.php b/SpecialThanks.php index 96cd3ac9..a4734a9e 100644 --- a/SpecialThanks.php +++ b/SpecialThanks.php @@ -93,7 +93,7 @@ class SpecialThanks extends FormSpecialPage { if ( $this->type === null || $this->type === 'rev' && $this->id === '0' ) { $form->suppressDefaultSubmit( true ); } else { - $form->setSubmitText( $this->msg( 'thanks' )->escaped() ); + $form->setSubmitText( $this->msg( 'thanks-submit' )->escaped() ); } } diff --git a/i18n/en.json b/i18n/en.json index 0f284e54..53e77331 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -18,6 +18,7 @@ "thanks-confirmation2": "{{GENDER:$1|Send}} public thanks for this edit?", "thanks-thanked-notice": "$1 received your thanks for {{GENDER:$2|his|her|their}} edit.", "thanks": "Send thanks", + "thanks-submit": "Send thanks", "thanks-form-revid": "Revision ID for edit", "echo-pref-subscription-edit-thank": "Thanks me for my edit", "echo-pref-tooltip-edit-thank": "Notify me when someone thanks me for an edit I made.", diff --git a/i18n/qqq.json b/i18n/qqq.json index 4e863595..ffae8df8 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -26,7 +26,8 @@ "thanks-thank-tooltip-yes": "Tooltip that appears when a user hovers over the \"Yes\" confirmation link (which confirms the thank action). Parameters:\n* $1 - The user sending the thanks. Can be used for GENDER support.", "thanks-confirmation2": "A confirmation message to make sure the user actually wants to send thanks to another user.\n\nParameters:\n* $1 - The user sending the thanks. Can be used for GENDER.\nSee also:\n* {{msg-mw|Thanks-confirmation-special}}", "thanks-thanked-notice": "{{doc-singularthey}}\nPop-up message that is displayed after a user has thanked another user for their edit.\n\nParameters:\n* $1 - the username of the user that was thanked\n* $2 - the gender of the user that was thanked\nSee also:\n* {{msg-mw|Flow-thanks-thanked-notice}}", - "thanks": "{{doc-special|Thanks|unlisted=1}}\nThe special page contains the form to thank for the edit.", + "thanks": "{{doc-special|Thanks|unlisted=1}}\nThe special page contains the form to thank for the edit. {{Identical|Send thanks}}", + "thanks-submit": "The text of the submit button on the Special:Thanks page. {{Identical|Send thanks}}", "thanks-form-revid": "Label for form field where the user inputs the revision ID.", "echo-pref-subscription-edit-thank": "Option for getting notifications when someone thanks the user for their edit.\n\nThis is the conclusion of the sentence begun by the header: {{msg-mw|Prefs-echosubscriptions}}.", "echo-pref-tooltip-edit-thank": "This is a short description of the edit-thank notification category.\n{{Related|Echo-pref-tooltip}}",