wikimedia/mediawiki-extensions-TextExtracts
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TextExtracts synced 2024-11-24 00:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove figures from text extracts

Browse source 
Bug: T318727
Change-Id: I304d4b794a0f27eb78ef013f911c444fc9a80cf1
This commit is contained in:
Arlo Breault 2022-09-27 13:13:24 -04:00
parent bbf63a420c
commit d67f9a73d5
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extension.json
View file

@ -43,6 +43,7 @@
"value": [
"table",
"div",
"figure",
"script",
"input",
"style",

16
tests/phpunit/ExtractFormatterTest.php
View file

@ -19,7 +19,7 @@ class ExtractFormatterTest extends MediaWikiIntegrationTestCase {
public function testExtracts( $expected, $text, $plainText ) {
$fmt = new ExtractFormatter( $text, $plainText );
// .metadata class will be added via $wgExtractsRemoveClasses on WMF
$fmt->remove( [ 'div', '.metadata' ] );
$fmt->remove( [ 'div', 'figure', '.metadata' ] );
$text = $fmt->getText();
$this->assertSame( $expected, $text );
}
@ -30,6 +30,8 @@ class ExtractFormatterTest extends MediaWikiIntegrationTestCase {
$tocText = 'Lead<div id="toc" class="toc">TOC goes here</div>
<h1>Section</h1>
<p>Section text</p>';
// phpcs:ignore Generic.Files.LineLength
$figureText = '<b>Test 123</b>beforetext<figure><span><img alt="About this sound" src="https://upload.wikimedia.org/wikipedia/commons/thumb/8/8a/Loudspeaker.svg/11px-Loudspeaker.svg.png" width="11" height="11" srcset="https://upload.wikimedia.org/wikipedia/commons/thumb/8/8a/Loudspeaker.svg/17px-Loudspeaker.svg.png 1.5x, https://upload.wikimedia.org/wikipedia/commons/thumb/8/8a/Loudspeaker.svg/22px-Loudspeaker.svg.png 2x" /></span><figcaption>Very loud speaker</figcaption></figure>aftertext';
return [
[
@ -77,6 +79,18 @@ class ExtractFormatterTest extends MediaWikiIntegrationTestCase {
$tocText,
true,
],
[
// Verify that text in figures is removed (plain)
'Test 123beforetextaftertext',
$figureText,
true,
],
[
// Verify that text in figures is removed (html)
'<b>Test 123</b>beforetextaftertext',
$figureText,
false,
]
];
}