wikimedia/mediawiki-extensions-TemplateStyles
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateStyles synced 2024-12-04 20:59:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Templa.../tests/phpunit/TemplateStylesHooksTest.php

325 lines
15 KiB
PHP
Raw Normal View History

Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
<?php
Namespace extension Change-Id: I7f64539f1c9c4c03088e28e99f77a9acc503f627
2022-02-06 14:39:49 +00:00
use MediaWiki\Extension\TemplateStyles\Hooks as TemplateStylesHooks;
use MediaWiki\Extension\TemplateStyles\TemplateStylesContent;
Don't use deprecated $wgParserConf global The modern way to create a Parser object is to use a ParserFactory. Change-Id: I97d58750c91b06eeca5d810509becdf53a39cc95
2020-04-16 18:38:36 +00:00
use MediaWiki\MediaWikiServices;
Use RevisionRecordCallback in ParserOptions, require MW 1.35+ Bug: T249384 Change-Id: I36b7a57278f9c32040180fc885827731a2d94098
2020-04-17 16:59:59 +00:00
use MediaWiki\Revision\MutableRevisionRecord;
use MediaWiki\Revision\SlotRecord;
Replace some moved Title class uses, now MediaWiki\Title\Title Bug: T321681 Change-Id: Ib7950b17581d69c1c9197e3a3109d3da4c735a33
2023-08-19 04:19:46 +00:00
use MediaWiki\Title\Title;
Fix wrapper="…" failing for more complex selectors For example, <templatestyles wrapper="a[href]" /> fails with an InvalidArgumentException very late in the process, long after the actual validation in TemplateStylesHooks::validateExtraWrapper() was done. This happens because validateExtraWrapper() works on a proper tree (where the [href] from the example is a nested object), but flattens this tree in the end via toTokenArray(). This flattened array ends in StyleRuleSanitizer::doSanitize() where it is added to a ComponentValueList – which expects a tree. The only change in this patch is that the object structure is not flattened any more. That's all. Bug: T258093 Change-Id: I5dc04611f91fe672da706f31fa8d0c254e3123d3
2020-09-15 17:34:01 +00:00
use Wikimedia\CSS\Parser\Parser as CSSParser;
Don't use deprecated $wgParserConf global The modern way to create a Parser object is to use a ParserFactory. Change-Id: I97d58750c91b06eeca5d810509becdf53a39cc95
2020-04-16 18:38:36 +00:00
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
/**
* @group TemplateStyles
* @group Database
Namespace extension Change-Id: I7f64539f1c9c4c03088e28e99f77a9acc503f627
2022-02-06 14:39:49 +00:00
* @covers \MediaWiki\Extension\TemplateStyles\Hooks
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
*/
class TemplateStylesHooksTest extends MediaWikiLangTestCase {
protected function addPage( $page, $text, $model ) {
$title = Title::newFromText( 'Template:TemplateStyles test/' . $page );
$content = ContentHandler::makeContent( $text, $title, $model );
Avoid using WikiPage::factory() WikiPage::factory() is deprecated since 1.36 and should be replaced with WikiPageFactory::newFromTitle(). Bug: T297688 Change-Id: I6c754b872c3b60ad724af8c18faacbf7320579fa
2021-12-16 20:54:21 +00:00
$page = $this->getServiceContainer()->getWikiPageFactory()->newFromTitle( $title );
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
$user = static::getTestSysop()->getUser();
Use WikiPage::doUserEditContent() instead of ::doEditContent() ::doUserEditContent() is available since 1.36 as a replacement for ::doEditContent(), which has been deprecated. Bump the required version of MediaWiki to 1.36 accordingly. Bug: T255507 Change-Id: I5d19b24031872105a27e886242c8d580ad278354
2021-06-24 05:58:50 +00:00
$status = $page->doUserEditContent( $content, $user, 'Test for TemplateStyles' );
Revert "Remove use of WikiPage::doEditContent" This reverts commit eb94a40c3ec8b3da8c8e32ac15bfcce09c795303. Reason for revert: autopatrol status wasn't included in the use of PageUpdater, revert for now and reapply properly with autopatrol later. Bug: T252179 Change-Id: I38e29e607bc01146ccab00ef8e10d59b769e4044
2020-05-08 00:16:42 +00:00
if ( !$status->isOk() ) {
$this->fail( "Failed to create $title: " . $status->getWikiText( false, false, 'en' ) );
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
}
public function addDBDataOnce() {
$this->addPage( 'wikitext', '.foo { color: red; }', CONTENT_MODEL_WIKITEXT );
$this->addPage( 'nonsanitized.css', '.foo { color: red; }', CONTENT_MODEL_CSS );
$this->addPage( 'styles1.css', '.foo { color: blue; }', 'sanitized-css' );
$this->addPage( 'styles2.css', '.bar { color: green; }', 'sanitized-css' );
Hoist selectors for html and body element Bug: T197617 Depends-On: Iac00198495cf08dec034f45100937df0f6cb1590 Change-Id: I5dd85d12eb77c70c1632974561c4cad8636fad1d
2018-08-24 19:07:10 +00:00
$this->addPage(
'styles3.css', 'html.no-js body.skin-minerva .bar { color: yellow; }', 'sanitized-css'
);
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
public function testGetSanitizerInvalidWrapper() {
@expectedException is deprecated Bug: T234597 Change-Id: Ieeb352cb37822b9eabc5179d7a30fb137070639b
2019-10-12 02:39:25 +00:00
$this->expectException( InvalidArgumentException::class );
$this->expectExceptionMessage( 'Invalid value for $extraWrapper: .foo>.bar' );
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
TemplateStylesHooks::getSanitizer( 'foo', '.foo>.bar' );
}
Fix wrapper="…" failing for more complex selectors For example, <templatestyles wrapper="a[href]" /> fails with an InvalidArgumentException very late in the process, long after the actual validation in TemplateStylesHooks::validateExtraWrapper() was done. This happens because validateExtraWrapper() works on a proper tree (where the [href] from the example is a nested object), but flattens this tree in the end via toTokenArray(). This flattened array ends in StyleRuleSanitizer::doSanitize() where it is added to a ComponentValueList – which expects a tree. The only change in this patch is that the object structure is not flattened any more. That's all. Bug: T258093 Change-Id: I5dc04611f91fe672da706f31fa8d0c254e3123d3
2020-09-15 17:34:01 +00:00
public function testGetSanitizerNonLinearWrapper() {
$sanitizer = TemplateStylesHooks::getSanitizer( 'foo', 'div[data]' );
$sanitizer->sanitize( CSSParser::newFromString( '.not-empty { }' )->parseStylesheet() );
$this->assertSame( [], $sanitizer->getSanitizationErrors() );
}
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
/**
* @dataProvider provideOnRegistration
* @param array $textModelsToParse
* @param bool $autoParseContent
* @param array $expect
*/
public function testOnRegistration( $textModelsToParse, $autoParseContent, $expect ) {
$this->setMwGlobals( [
'wgTextModelsToParse' => $textModelsToParse,
'wgTemplateStylesAutoParseContent' => $autoParseContent,
] );
global $wgTextModelsToParse;
TemplateStylesHooks::onRegistration();
$this->assertSame( $expect, $wgTextModelsToParse );
}
public static function provideOnRegistration() {
return [
[
[ CONTENT_MODEL_WIKITEXT ],
true,
[ CONTENT_MODEL_WIKITEXT ]
],
[
[ CONTENT_MODEL_WIKITEXT, CONTENT_MODEL_CSS ],
true,
[ CONTENT_MODEL_WIKITEXT, CONTENT_MODEL_CSS, 'sanitized-css' ],
],
[
[ CONTENT_MODEL_WIKITEXT, CONTENT_MODEL_CSS ],
false,
[ CONTENT_MODEL_WIKITEXT, CONTENT_MODEL_CSS ],
],
];
}
/**
* @dataProvider provideOnContentHandlerDefaultModelFor
*/
public function testOnContentHandlerDefaultModelFor( $ns, $title, $expect ) {
$this->setMwGlobals( [
Allow extensions to register additional namespaces in extension.json Extensions can register additional namespaces by setting the "TemplateStylesNamespaces" attribte in their extension.json. This change is analogous to Ia5d34cb78fa6af. There isn't really a simpler way to do this here, as the config setting uses namespaces as keys, while the attribute is using them as values. Furthermore, keys with falsey values are ignored in the config setting, and attributes can't use the same setting architecture, as array_merge_recursive doesn't maintain numeric keys. Bug: T200914 Depends-On: I9e62a02ed2044c847e9ab2dcdfab094001f88986 Change-Id: I2fa9b822ee39bcc5f95a293c8c4aad4d53ede30a
2018-10-18 13:32:49 +00:00
'wgTemplateStylesNamespaces' => [
10 => true,
2 => false,
3000 => true,
3002 => true,
3006 => false,
],
'wgNamespacesWithSubpages' => [
10 => true,
2 => true,
3000 => true,
3002 => false,
3004 => true,
3006 => true
],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
] );
Allow extensions to register additional namespaces in extension.json Extensions can register additional namespaces by setting the "TemplateStylesNamespaces" attribte in their extension.json. This change is analogous to Ia5d34cb78fa6af. There isn't really a simpler way to do this here, as the config setting uses namespaces as keys, while the attribute is using them as values. Furthermore, keys with falsey values are ignored in the config setting, and attributes can't use the same setting architecture, as array_merge_recursive doesn't maintain numeric keys. Bug: T200914 Depends-On: I9e62a02ed2044c847e9ab2dcdfab094001f88986 Change-Id: I2fa9b822ee39bcc5f95a293c8c4aad4d53ede30a
2018-10-18 13:32:49 +00:00
$reset = ExtensionRegistry::getInstance()->setAttributeForTest(
'TemplateStylesNamespaces', [ 3004, 3006 ]
);
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
$model = 'unchanged';
Use HookHandlers for core hooks The use of "HookHandlers" attribute in extension.json makes it possible to inject services into hook handler classes in a future patch. Bug: T338435 Change-Id: Iadeed8e4735f95387f2faed4bc4305327bff3c8a
2023-09-24 20:12:07 +00:00
$ret = ( new TemplateStylesHooks )->onContentHandlerDefaultModelFor(
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
Title::makeTitle( $ns, $title ), $model
);
$this->assertSame( !$expect, $ret );
$this->assertSame( $expect ? 'sanitized-css' : 'unchanged', $model );
}
public static function provideOnContentHandlerDefaultModelFor() {
return [
[ 10, 'Test/test.css', true ],
[ 10, 'Test.css', false ],
[ 10, 'Test/test.xss', false ],
[ 10, 'Test/test.CSS', false ],
[ 3000, 'Test/test.css', true ],
[ 3002, 'Test/test.css', false ],
[ 2, 'Test/test.css', false ],
Allow extensions to register additional namespaces in extension.json Extensions can register additional namespaces by setting the "TemplateStylesNamespaces" attribte in their extension.json. This change is analogous to Ia5d34cb78fa6af. There isn't really a simpler way to do this here, as the config setting uses namespaces as keys, while the attribute is using them as values. Furthermore, keys with falsey values are ignored in the config setting, and attributes can't use the same setting architecture, as array_merge_recursive doesn't maintain numeric keys. Bug: T200914 Depends-On: I9e62a02ed2044c847e9ab2dcdfab094001f88986 Change-Id: I2fa9b822ee39bcc5f95a293c8c4aad4d53ede30a
2018-10-18 13:32:49 +00:00
[ 3004, 'Test/test.css', true ],
[ 3006, 'Test/test.css', false ],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
];
}
/**
* Unfortunately we can't just use a parserTests.txt file because our
* tag's output depends on the revision IDs of the input pages.
* @dataProvider provideTag
*/
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
public function testTag(
ParserOptions $popt, $getTextOptions, $wikitext, $expect, $globals = []
) {
$this->setMwGlobals( $globals + [
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'wgScriptPath' => '',
'wgScript' => '/index.php',
'wgArticlePath' => '/wiki/$1',
] );
Use RevisionRecordCallback in ParserOptions, require MW 1.35+ Bug: T249384 Change-Id: I36b7a57278f9c32040180fc885827731a2d94098
2020-04-17 16:59:59 +00:00
$oldCurrentRevisionRecordCallback = $popt->setCurrentRevisionRecordCallback(
build: Updating composer dependencies * mediawiki/mediawiki-codesniffer: 35.0.0 → 36.0.0 * php-parallel-lint/php-parallel-lint: 1.2.0 → 1.3.0 Change-Id: I0105b425acd5e65b15c789015cdc9144a2d4f8f1
2021-05-03 10:21:33 +00:00
static function ( Title $title, $parser = null ) use ( &$oldCurrentRevisionRecordCallback ) {
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
if ( $title->getPrefixedText() === 'Template:Test replacement' ) {
$user = RequestContext::getMain()->getUser();
Use RevisionRecordCallback in ParserOptions, require MW 1.35+ Bug: T249384 Change-Id: I36b7a57278f9c32040180fc885827731a2d94098
2020-04-17 16:59:59 +00:00
$revRecord = new MutableRevisionRecord( $title );
$revRecord->setUser( $user );
$revRecord->setContent(
SlotRecord::MAIN,
new TemplateStylesContent( '.baz { color:orange; bogus:bogus; }' )
);
$revRecord->setParentId( $title->getLatestRevID() );
return $revRecord;
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
Use RevisionRecordCallback in ParserOptions, require MW 1.35+ Bug: T249384 Change-Id: I36b7a57278f9c32040180fc885827731a2d94098
2020-04-17 16:59:59 +00:00
return call_user_func( $oldCurrentRevisionRecordCallback, $title, $parser );
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
);
Don't use deprecated $wgParserConf global The modern way to create a Parser object is to use a ParserFactory. Change-Id: I97d58750c91b06eeca5d810509becdf53a39cc95
2020-04-16 18:38:36 +00:00
$services = MediaWikiServices::getInstance();
$parser = $services->getParserFactory()->create();
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
$parser->firstCallInit();
Replace use of Parser::$mTagHooks, deprecated in 1.35 The replacement, Parser::getTags(), has been in MediaWiki for over a decade (since sometime before 1.11). Bug: T275160 Change-Id: Ib708e3f84aa871de84aa56561c875f4a85bb000c
2021-02-18 22:23:22 +00:00
if ( !in_array( 'templatestyles', $parser->getTags(), true ) ) {
Don't skip tests if the hook is not present This just hides the error if something's broken with extension registration because skipped tests don't result in a failed suite. Instead, explode in everybody's eyes to make it clear there's a problem. Change-Id: I2f1e80a1fa4b99d857671c9d1061d34449764f01
2017-11-14 21:51:50 +00:00
throw new Exception( 'templatestyles tag hook is not in the parser' );
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
$out = $parser->parse( $wikitext, Title::newFromText( 'Test' ), $popt );
build: Updating composer dependencies * mediawiki/mediawiki-codesniffer: 35.0.0 → 36.0.0 * php-parallel-lint/php-parallel-lint: 1.2.0 → 1.3.0 Change-Id: I0105b425acd5e65b15c789015cdc9144a2d4f8f1
2021-05-03 10:21:33 +00:00
$expect = preg_replace_callback( '/\{\{REV:(.*?)\}\}/', static function ( $m ) {
Deduplicate embedded style rules Use the facility added in core change I055abdf4d to deduplicate the embedded style rules. Bug: T168333 Change-Id: I98c6d5ca4b474de8826b19355f15a5230aef5650 Depends-On: I055abdf4d73ec65771eaa4fe0999ec907c831568
2017-11-24 19:20:47 +00:00
return Title::newFromText( 'Template:TemplateStyles test/' . $m[1] )->getLatestRevID();
}, $expect );
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$this->assertEquals( $expect, $out->getText( $getTextOptions ) );
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
}
public static function provideTag() {
$popt = ParserOptions::newFromContext( RequestContext::getMain() );
$popt->setWrapOutputClass( 'templatestyles-test' );
$popt2 = ParserOptions::newFromContext( RequestContext::getMain() );
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
$popt3 = ParserOptions::newFromContext( RequestContext::getMain() );
Change use of AtEase to at operator Change-Id: If660c57d30d987762ac6a8cf4dfc0df240a6e560
2024-04-29 17:36:03 +00:00
// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
@$popt3->setWrapOutputClass( false );
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
return [
'Tag without src' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">TemplateStyles' <code>src</code> attribute must not be empty.</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Tag with invalid src' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="Test&lt;&gt;" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Invalid title for TemplateStyles' <code>src</code> attribute.</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Tag with valid but nonexistent title' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="ThisDoes\'\'\'Not\'\'\'Exist" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Page <a href=\"/index.php?title=Template:ThisDoes%27%27%27Not%27%27%27Exist&amp;action=edit&amp;redlink=1\" class=\"new\" title=\"Template:ThisDoes&#39;&#39;&#39;Not&#39;&#39;&#39;Exist (page does not exist)\">Template:ThisDoes&#39;&#39;&#39;Not&#39;&#39;&#39;Exist</a> has no content.</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Tag with valid but nonexistent title, main namespace' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src=":ThisDoes\'\'\'Not\'\'\'Exist" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Page <a href=\"/index.php?title=ThisDoes%27%27%27Not%27%27%27Exist&amp;action=edit&amp;redlink=1\" class=\"new\" title=\"ThisDoes&#39;&#39;&#39;Not&#39;&#39;&#39;Exist (page does not exist)\">ThisDoes&#39;&#39;&#39;Not&#39;&#39;&#39;Exist</a> has no content.</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Tag with wikitext page' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="TemplateStyles test/wikitext" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Page <a href=\"/wiki/Template:TemplateStyles_test/wikitext\" title=\"Template:TemplateStyles test/wikitext\">Template:TemplateStyles test/wikitext</a> must have content model \"Sanitized CSS\" for TemplateStyles (current model is \"wikitext\").</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Tag with CSS (not sanitized-css) page' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="TemplateStyles test/nonsanitized.css" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Page <a href=\"/wiki/Template:TemplateStyles_test/nonsanitized.css\" title=\"Template:TemplateStyles test/nonsanitized.css\">Template:TemplateStyles test/nonsanitized.css</a> must have content model \"Sanitized CSS\" for TemplateStyles (current model is \"CSS\").</strong>\n</p></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
'Working tag' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="TemplateStyles test/styles1.css" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><style data-mw-deduplicate=\"TemplateStyles:r{{REV:styles1.css}}/templatestyles-test\">.templatestyles-test .foo{color:blue}</style></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
'Disabled' => [
$popt, [],
'<templatestyles src="TemplateStyles test/styles1.css" />',
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"></div>",
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
[ 'wgTemplateStylesDisable' => true ],
],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'Replaced content (which includes sanitization errors)' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="Test replacement" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><style data-mw-deduplicate=\"TemplateStyles:8fd14043c1cce91e8b9d1487a9d17d8d9ae43890/templatestyles-test\">/*\nErrors processing stylesheet [[:Template:Test replacement]] (rev ):\n• Unrecognized or unsupported property at line 1 character 22.\n*/\n.templatestyles-test .baz{color:orange}</style></div>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
Hoist selectors for html and body element Bug: T197617 Depends-On: Iac00198495cf08dec034f45100937df0f6cb1590 Change-Id: I5dd85d12eb77c70c1632974561c4cad8636fad1d
2018-08-24 19:07:10 +00:00
'Hoistable selectors are hoisted' => [
$popt, [],
'<templatestyles src="TemplateStyles test/styles3.css" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><style data-mw-deduplicate=\"TemplateStyles:r{{REV:styles3.css}}/templatestyles-test\">html.no-js body.skin-minerva .templatestyles-test .bar{color:yellow}</style></div>",
Hoist selectors for html and body element Bug: T197617 Depends-On: Iac00198495cf08dec034f45100937df0f6cb1590 Change-Id: I5dd85d12eb77c70c1632974561c4cad8636fad1d
2018-08-24 19:07:10 +00:00
],
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
'Still prefixed despite no wrapping class' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt2, [ 'unwrap' => true ],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
'<templatestyles src="TemplateStyles test/styles1.css" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Remove newlines from tests to make pass(?!) Change-Id: Ib7f4252e4b399edcd5845aa31c60df494a8d8c3e
2019-04-12 21:58:20 +00:00
"<style data-mw-deduplicate=\"TemplateStyles:r{{REV:styles1.css}}\">.mw-parser-output .foo{color:blue}</style>",
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
'Still prefixed despite deprecated no wrapping class' => [
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
$popt3, [],
'<templatestyles src="TemplateStyles test/styles1.css" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Remove newlines from tests to make pass(?!) Change-Id: Ib7f4252e4b399edcd5845aa31c60df494a8d8c3e
2019-04-12 21:58:20 +00:00
"<style data-mw-deduplicate=\"TemplateStyles:r{{REV:styles1.css}}\">.mw-parser-output .foo{color:blue}</style>",
Fix coverage * Fix test for TemplateStylesFontFaceAtRuleSanitizer so it's actually run * Hack up a broken Sanitizer to test a code path in TemplateStylesContent::sanitize() that handles such things. * Ignore an InvalidArgumentException in TemplateStylesContent::processError() that's not worth checking. User input can't hit that, only logic bugs. * Ignore TemplateStylesHooks::getConfig(), it's tested but gets called before PHPUnit starts counting. * Test TemplateStylesHooksTest::onCodeEditorGetPageLanguage() * Test $wgTemplateStylesDisable * Test a back-compat code path in TemplateStylesHooks::handleTag(). Change-Id: I7078e5a353a624aa53fe72de7990b93a77b44cf6
2018-02-06 02:55:05 +00:00
],
Deduplicate embedded style rules Use the facility added in core change I055abdf4d to deduplicate the embedded style rules. Bug: T168333 Change-Id: I98c6d5ca4b474de8826b19355f15a5230aef5650 Depends-On: I055abdf4d73ec65771eaa4fe0999ec907c831568
2017-11-24 19:20:47 +00:00
'Deduplicated tags' => [
Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) To reduce parser cache fragmentation, core is deprecating $parserOptions->setWrapOutputClass( false ) in favor of $parserOutput->getText( [ 'unwrap' => true ] ); Change-Id: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7 Depends-On: Iba16e78c41be992467101e7d83e9c3134765b101
2017-12-22 18:43:15 +00:00
$popt, [],
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
trim( '
<templatestyles src="TemplateStyles test/styles1.css" />
<templatestyles src="TemplateStyles test/styles1.css" />
<templatestyles src="TemplateStyles test/styles2.css" />
<templatestyles src="TemplateStyles test/styles1.css" />
<templatestyles src="TemplateStyles test/styles2.css" />
' ),
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:disable Generic.Files.LineLength
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
trim( '
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
<div class="mw-content-ltr templatestyles-test" lang="en" dir="ltr"><style data-mw-deduplicate="TemplateStyles:r{{REV:styles1.css}}/templatestyles-test">.templatestyles-test .foo{color:blue}</style>
tests: Adjust output format for html changes (self-closing xhtml) Follow-Up: I4bbfa47fbf6e30fb90d920d6d02cdf6e0b1cdb46 Change-Id: I06045e1011de9035f0be759d953f3145293c66f2
2023-05-21 16:07:53 +00:00
<link rel="mw-deduplicated-inline-style" href="mw-data:TemplateStyles:r{{REV:styles1.css}}/templatestyles-test">
Deduplicate embedded style rules Use the facility added in core change I055abdf4d to deduplicate the embedded style rules. Bug: T168333 Change-Id: I98c6d5ca4b474de8826b19355f15a5230aef5650 Depends-On: I055abdf4d73ec65771eaa4fe0999ec907c831568
2017-11-24 19:20:47 +00:00
<style data-mw-deduplicate="TemplateStyles:r{{REV:styles2.css}}/templatestyles-test">.templatestyles-test .bar{color:green}</style>
tests: Adjust output format for html changes (self-closing xhtml) Follow-Up: I4bbfa47fbf6e30fb90d920d6d02cdf6e0b1cdb46 Change-Id: I06045e1011de9035f0be759d953f3145293c66f2
2023-05-21 16:07:53 +00:00
<link rel="mw-deduplicated-inline-style" href="mw-data:TemplateStyles:r{{REV:styles1.css}}/templatestyles-test">
<link rel="mw-deduplicated-inline-style" href="mw-data:TemplateStyles:r{{REV:styles2.css}}/templatestyles-test"></div>
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
' ),
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:enable
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
],
'Wrapper parameter' => [
$popt2, [],
'<templatestyles src="TemplateStyles test/styles1.css" wrapper=".foobar" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr mw-parser-output\" lang=\"en\" dir=\"ltr\"><style data-mw-deduplicate=\"TemplateStyles:r{{REV:styles1.css}}/mw-parser-output/.foobar\">.mw-parser-output .foobar .foo{color:blue}</style></div>",
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
],
'Invalid wrapper parameter' => [
$popt, [],
'<templatestyles src="TemplateStyles test/styles1.css" wrapper=".foo .bar" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Invalid value for TemplateStyles' <code>wrapper</code> attribute.</strong>\n</p></div>",
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
],
'Invalid wrapper parameter (2)' => [
$popt, [],
'<templatestyles src="TemplateStyles test/styles1.css" wrapper=".foo/*" />',
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:ignore Generic.Files.LineLength
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
"<div class=\"mw-content-ltr templatestyles-test\" lang=\"en\" dir=\"ltr\"><p><strong class=\"error\">Invalid value for TemplateStyles' <code>wrapper</code> attribute.</strong>\n</p></div>",
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
],
'Wrapper parameter and proper deduplication' => [
$popt2, [],
trim( '
<templatestyles src="TemplateStyles test/styles1.css" />
<templatestyles src="TemplateStyles test/styles1.css" wrapper=" " />
<templatestyles src="TemplateStyles test/styles1.css" wrapper=".foobar" />
<templatestyles src="TemplateStyles test/styles1.css" wrapper=".foobaz" />
<templatestyles src="TemplateStyles test/styles1.css" wrapper=" .foobar " />
' ),
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:disable Generic.Files.LineLength
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
trim( '
tests: Adjust mw-parser-output div for new attributes lang/dir Add in core with d0a96db0 Follow-Up: Ib130a055e46764544af0f1a46d2bc2b3a7ee85b7 Change-Id: I016093b732fc8c44901632c4d63608c5af41cda5
2023-11-06 19:43:49 +00:00
<div class="mw-content-ltr mw-parser-output" lang="en" dir="ltr"><style data-mw-deduplicate="TemplateStyles:r{{REV:styles1.css}}">.mw-parser-output .foo{color:blue}</style>
tests: Adjust output format for html changes (self-closing xhtml) Follow-Up: I4bbfa47fbf6e30fb90d920d6d02cdf6e0b1cdb46 Change-Id: I06045e1011de9035f0be759d953f3145293c66f2
2023-05-21 16:07:53 +00:00
<link rel="mw-deduplicated-inline-style" href="mw-data:TemplateStyles:r{{REV:styles1.css}}">
Add "wrapper" attribute to <templatestyles/> The wrapper attribute may contain an extra CSS simple selector to include when prefixing. For example, including a template as <templatestyles src="..." wrapper="div.my-template"/> would transform .foo .bar { color:red; } into .mw-parser-output div.my-template .foo .bar{color:red} This can allow particular templates to opt in to the "styles are scoped to the template itself" model that was desired by some when TemplateStyles was being designed; the driving use case in the linked task is doing so for the benefit of side-by-side comparisons of the current and sandboxed versions of a template. Bug: T200441 Change-Id: If49d4c5be31feca95abd21452238fd10ab1916b1
2018-10-17 17:28:43 +00:00
<style data-mw-deduplicate="TemplateStyles:r{{REV:styles1.css}}/mw-parser-output/.foobar">.mw-parser-output .foobar .foo{color:blue}</style>
<style data-mw-deduplicate="TemplateStyles:r{{REV:styles1.css}}/mw-parser-output/.foobaz">.mw-parser-output .foobaz .foo{color:blue}</style>
tests: Adjust output format for html changes (self-closing xhtml) Follow-Up: I4bbfa47fbf6e30fb90d920d6d02cdf6e0b1cdb46 Change-Id: I06045e1011de9035f0be759d953f3145293c66f2
2023-05-21 16:07:53 +00:00
<link rel="mw-deduplicated-inline-style" href="mw-data:TemplateStyles:r{{REV:styles1.css}}/mw-parser-output/.foobar"></div>
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
' ),
build: Swap deprecated @codingStandardsIgnore to phpcs:ignore Bug: T278594 Change-Id: I356955fd31ffa77f8527212a23ddb829941b9505
2021-03-26 23:59:00 +00:00
// phpcs:enable
Use wikimedia/css-sanitizer, and rewrite the hooking wikimedia/css-sanitizer provides a real CSS parser, which should be safer than poking at things with regular expressions. Instead of the strange hybrid model that tried to both process inline CSS and save CSS when the template is saved, it now looks for <templatestyles src="Title" /> during the parse to do all the transclusion of styles. The output method is "<style> tags in the body", pending someone implementing T160563. It now also registers a "sanitized-css" content model, which should pick up the CSS syntax highlighting and will validate the submitted CSS on submit and prevent a save if it's not valid. This patch also takes advantage of LGPL-2.x § 3 to relicense the extension as GPL-2.0+, although at this point none of the LGPL code remains anyway. Bug: T133408 Bug: T136054 Bug: T135788 Bug: T135789 Change-Id: I993e6f18d32a43aac8398743133d227b05133bbd Depends-On: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
2017-02-20 04:33:24 +00:00
],
];
}
}
Reference in a new issue Copy permalink