Commit graph

2324 commits

Author SHA1 Message Date
Adam Wight 93b7bc0756 Drop unnecessary top-level closures
Change-Id: Ie8fbde864cd08f0657e4239f525ef9dd087aee41
2020-12-07 15:24:31 +01:00
Adam Wight 80021704d4 Track parameter property changes
This is temporary interaction tracking to better understand how the
dialog is used.

Bug: T260343
Change-Id: I14afa89e18676818f88c142059128a9f62dcadcb
2020-12-07 14:39:05 +01:00
jenkins-bot e6846281be Merge "Rename "property" variable for clarity" 2020-12-07 11:24:34 +00:00
jenkins-bot fed4b5f415 Merge "Assign reused dependentField value to a variable" 2020-12-07 11:24:32 +00:00
jenkins-bot ea80588a2a Merge "Assign reused propertyInput value to a variable" 2020-12-07 11:24:31 +00:00
jenkins-bot ae40b92523 Merge "Send metrics for template property interactions" 2020-12-07 11:24:28 +00:00
jenkins-bot ef57986ce6 Merge "Send metrics when applying changes" 2020-12-07 11:15:47 +00:00
jenkins-bot 4465cf14cd Merge "Send metrics when opening the dialog" 2020-12-07 11:14:08 +00:00
jenkins-bot 8c82e21699 Merge "Higher-level distinction when creating new TemplateData" 2020-12-07 11:04:36 +00:00
libraryupgrader 791af40917 build: Updating mediawiki/mediawiki-codesniffer to 34.0.0
Change-Id: I20e3fd65fc43a475c3040cc468101051b27fcf8b
2020-12-07 03:11:02 +00:00
Adam Wight eb6b61b3a7 Rename "property" variable for clarity
"props" sounds plural, but it is the name of a single property.

Change-Id: I62184d00d03e297568e1c335f31c961aa6983406
2020-12-04 18:44:48 +00:00
Adam Wight 5206188129 Assign reused dependentField value to a variable
Change-Id: Ie77fd61d5bb7d886ab069472d0294daf4039d4e2
2020-12-04 18:44:40 +00:00
Adam Wight 8e65e4d8fb Assign reused propertyInput value to a variable
Change-Id: Ic8ea8ae283112801266303eb1d2520931e47a418
2020-12-04 18:44:32 +00:00
Adam Wight 415286e377 Send metrics for template property interactions
Bug: T260343
Change-Id: I050eb4b87ccb9c8910847b929b86c3b3cb269b8a
2020-12-04 18:44:01 +00:00
Adam Wight 1d108b5104 Send metrics when applying changes
Bug: T260343
Change-Id: I6fea4195107baf301dd8f66967c86e9c7a762bd1
2020-12-04 18:43:30 +00:00
Adam Wight d8e418671d Send metrics when opening the dialog
Distinguish between create and edit.

Bug: T260343
Change-Id: I5cd29dff0c4db7e024395a9090c465a01527f079
2020-12-04 18:43:23 +00:00
Adam Wight a9a4485b22 Higher-level distinction when creating new TemplateData
This is needed for metrics collection.

The patch shifts responsibility for filling out an empty record when
there is no existing TemplateData, or it's corrupt.

We could clean up further by making logic robust to missing `params`
in the original templatedata, so that an empty structure is simply
`{}`.

Bug: T260343
Change-Id: I6ddc2660257890290cd40c54f9c8507ab5206d6c
2020-12-04 18:43:09 +00:00
Adam Wight b7fee749ab Migrate to package files: ext.templateDataGenerator.editTemplatePage
Change-Id: Ie03284701c1870b06116b7ce6a8ca1759c28d03b
2020-12-04 19:41:50 +01:00
Adam Wight bda6215309 Migrate to package files: ext.templateDataGenerator.data
Bug: T260343
Change-Id: Ifd171b40de704bff8c063da46b711a384238a0f5
2020-12-04 19:41:30 +01:00
jenkins-bot d2e46c5d27 Merge "Migrate to package files: ext.templateDataGenerator.editPage" 2020-12-04 17:41:48 +00:00
jenkins-bot 0ad3562e4b Merge "Migrate from jsduck to jsdoc" 2020-12-04 17:09:34 +00:00
Adam Wight 479a5a4f12 Migrate to package files: ext.templateDataGenerator.editPage
This is trivial, only I'm splitting into its own patch to bisect a
test failure.

Bug: T260343
Change-Id: Ia6d581a0278b21cbfdcfdad0d6193fb965f35814
2020-12-04 17:00:37 +00:00
Adam Wight 1ff3ddc105 Lint with "commonsjs" rules
This will allow us to migrate to ResourceLoader "package files"
modules.

Bug: T260343
Change-Id: Id4c0a018ea6f3d9a54d468fc3e6c35bfdf5ce1dd
2020-12-04 16:39:00 +00:00
Translation updater bot 44d2957dfa Localisation updates from https://translatewiki.net.
Change-Id: I715274ef1716c702fb266a8ff25936793a4f78d0
2020-12-04 08:34:09 +01:00
Translation updater bot eb72f33c94 Localisation updates from https://translatewiki.net.
Change-Id: I6531668dc7b50ef7b0188da274f5c86d05a54e26
2020-12-03 08:33:18 +01:00
Translation updater bot 1d11a24bfb Localisation updates from https://translatewiki.net.
Change-Id: I225089809b2948f640e393d6d7b12ad17016c440
2020-12-02 08:33:11 +01:00
Adam Wight 1010e6fb78 Migrate from jsduck to jsdoc
Bug: T138401
Change-Id: Iae74fdcae5e8c2541416d8cec8de8221cfc282ef
2020-11-30 21:56:30 +01:00
Translation updater bot 61f61d66d3 Localisation updates from https://translatewiki.net.
Change-Id: I7f37f85492702bfcf6b94bbe601c896ccf7238de
2020-11-30 08:47:55 +01:00
Translation updater bot 00a5f419b6 Localisation updates from https://translatewiki.net.
Change-Id: I4bd8a872f006592197197066da3b9bd3245a9368
2020-11-26 08:28:32 +01:00
libraryupgrader 49fc569c12 build: Updating npm dependencies
* grunt-stylelint: 0.15.0 → 0.16.0
* stylelint-config-wikimedia: 0.10.1 → 0.10.3

Change-Id: Ibc5e81ae5199cdce8aaff6cea82badc3ddbb6ae1
2020-11-22 10:56:06 +00:00
libraryupgrader e7b3394edd build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Change-Id: I084cbc85f5be3ceca71c3dac35e0c9fdd7379c9b
2020-11-20 19:45:54 +00:00
Translation updater bot 061a420aad Localisation updates from https://translatewiki.net.
Change-Id: I9d7093ec9ec7810219c860eb4293938594ef58d5
2020-11-19 09:10:40 +01:00
daniel 4478384155 Revert "Add logging for parser cache misses."
We got the info we wanted, the statistics gathering is now just
causing extra ParserCache lookups.

This reverts commit dd81de53d7.
This reverts commit 9a85a1b67e.

Bug: T266200
Change-Id: I830797e287118fbde07e0e22e1304b30ee9f67e5
2020-11-17 21:07:03 +00:00
Translation updater bot e36f217ba6 Localisation updates from https://translatewiki.net.
Change-Id: Ifc49b1980a52b27a5e34f221d98672a540f699d9
2020-11-16 08:38:08 +01:00
Translation updater bot aef3afb2ef Localisation updates from https://translatewiki.net.
Change-Id: Ie4183bd01f7f8b36a56690f7fad4d7257ce3b871
2020-11-13 08:31:05 +01:00
Translation updater bot a0c06962c0 Localisation updates from https://translatewiki.net.
Change-Id: Ic8ce2606952d7c4b83bafbf18342040d71da605e
2020-11-12 08:22:43 +01:00
Translation updater bot c235be7791 Localisation updates from https://translatewiki.net.
Change-Id: I623c0464f18c39519fef95eab042aa5d2283f2a7
2020-11-11 08:36:55 +01:00
Translation updater bot 473e138b6f Localisation updates from https://translatewiki.net.
Change-Id: I9c136796ddf2b44b3173d4b410bace1ee908fd23
2020-11-10 08:42:43 +01:00
Cindy Cicalese 45907dc7d4 Make extension data JSON-serializable #2 - write JSON.
Switching ParserCache to JSON serialization requires
extensions to stop writing non-JSON-serializable objects
into ParserOutput::setExtensionData.

This should be deployed at least 1 train after dependencies.

Bug: T266252
Change-Id: I24dfbcff47b6a317d9928fda8c70da64f2d6bc82
2020-11-09 19:48:47 +00:00
Translation updater bot b9f334f8b9 Localisation updates from https://translatewiki.net.
Change-Id: I566587b60d2310bfff45b075d35b920abd2c09a4
2020-11-09 08:35:50 +01:00
Translation updater bot f6999aff96 Localisation updates from https://translatewiki.net.
Change-Id: I5dfc85fe818e8515bf71cd5bdc32486416a2b61b
2020-11-06 08:34:44 +01:00
jenkins-bot 4a2a36409a Merge "Change the value of 'template-doc-param-type-wiki-page-name' from "Page" to "Page name"" 2020-11-05 14:49:52 +00:00
libraryupgrader 2d6c576b16 build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Additional changes:
* Dropped .inc files from .phpcs.xml (T200956).

Change-Id: Ib6fc0608d7f7aedc792e5b86e0ffdafa42680759
2020-11-04 13:50:00 +00:00
jenkins-bot 5b011b7829 Merge "Apply bucketing to query sizes stats" 2020-11-04 00:07:38 +00:00
daniel dd81de53d7 Apply bucketing to query sizes stats
Change-Id: I921e5bec971fac1303b26322bb0898016c251bea
2020-11-03 20:31:01 +01:00
Translation updater bot ab824ebb7c Localisation updates from https://translatewiki.net.
Change-Id: Ie6cfed275c326ce3a85a18867737712a0cffe952
2020-11-03 08:45:13 +01:00
daniel 9a85a1b67e Add logging for parser cache misses.
This should help us decide whether it would be OK to
rely on the ParserCache to store parsed TemplateData.

This patch should be reverted once we have collected
the desired data.

Bug: T266200
Change-Id: I0631806145d46e4a5e7c177797b8fdfe7a152076
2020-11-02 22:18:38 +01:00
Translation updater bot aa9f53d0e4 Localisation updates from https://translatewiki.net.
Change-Id: I5bb8efaabf0c4ee9fc05c98fd21e962379b2d41c
2020-11-02 08:53:56 +01:00
jenkins-bot 5edb1fd72a Merge "Make extension data JSON-serializable #1 - forward-compat." 2020-10-30 17:56:20 +00:00
Cindy Cicalese b10862a333 Make extension data JSON-serializable #1 - forward-compat.
Transitioning of ParserCache to JSON serialization will add
a requirement that all the extension data is JSON-serializable.

This is the first step in transition - making it forward-compatible.

Bug: T266252
Change-Id: If1c9d9bb5b0039df80a9d9b30c247206d8844c0a
2020-10-30 12:33:20 -04:00