Commit graph

114 commits

Author SHA1 Message Date
Timo Tijhof ba3fe664d4 tests: Use assert.async() instead of QUnit.stop/start
* Remove use of undocumented 'this' inside promise callback,
  use the promise variable instead.
* Remove needless expectCount.

Change-Id: I3a698207440d8085a502fa54da8bb5feddfa1dcb
2017-04-13 13:09:03 -07:00
jenkins-bot a31aaedb88 Merge "Extend 'format' spec to include custom format strings." 2016-12-13 21:52:45 +00:00
jenkins-bot 9e721d2432 Merge "Add VE support" 2016-12-12 21:05:11 +00:00
jenkins-bot af8dedaf37 Merge "Follow-up I9ba06bb3a: Use separate window manager for dialog" 2016-12-07 00:39:17 +00:00
Ed Sanders e539f45589 Add VE support
Bug: T152230
Depends-On: Ic8b11d8052770e7c6550c98799893e9b640309ca
Change-Id: I91c045ef3e08eb7259d2861e65df521024199a53
2016-12-06 21:31:10 +00:00
Ed Sanders 4b0757b293 Follow-up I9ba06bb3a: Use separate window manager for dialog
The dialog wants to show a confirm dialog inside it, so we
need two separate managers.

Change-Id: Ib27b9348d73d1eeee5d353ad906fc33cc374ad66
2016-12-06 21:28:42 +00:00
jenkins-bot 48f9d52a5f Merge "Move icons to RL and generate inverted variants" 2016-12-06 20:53:09 +00:00
Ed Sanders e21a2563ce Move icons to RL and generate inverted variants
Also remove unused parameter icon.

Change-Id: I0ce10a50a0738ba111cfd63bc9cc5de03fae8c8d
2016-12-06 11:53:52 +00:00
Ed Sanders 94d0e73a6b Move all init code over to target
Change-Id: I9ba06bb3a57a7683e246461341c67462cab465d0
2016-12-05 17:02:38 +00:00
Ed Sanders a586d54e93 Abstract out editor manipulation form UI
Create target classes with get/setWikitext methods.

Also refactor some of the window manager code.

Bug: T152230
Change-Id: I7dcc137d79e029b69467ca282d8c52683e022598
2016-12-05 17:01:15 +00:00
Ed Sanders 6565ee4cf5 build: Replace jscs/jshint with eslint
Change-Id: Iff79501de8d80a860eebb4a6e31dc8fca3285505
2016-12-02 22:05:13 +00:00
C. Scott Ananian 5812413f11 Extend 'format' spec to include custom format strings.
Thanks to Thiemo Mättig for the suggestion and specification at
Wikimania 2016 in Esino Lario.

This is an extended version of Thiemo's original specification.  This
version also allows specification of "own line" properties for
templates; that is, whether the template should be preceded/followed
by a newline, as requested by James Forrester.

Bug: T138492
Bug: T135667
Change-Id: Idc6b2680330e6bf5caec2bf6fc86a705d25bc649
2016-09-01 14:14:47 -07:00
jenkins-bot 61360d69ec Merge "Make the help button a help link again" 2016-08-23 17:35:35 +00:00
David Lynch dbe26670af Make the help button a help link again
This gives it more visual indicators that it'll take you somewhere. Its
previous frameless-button appearance made it non-obvious that it was behaving
as a link.

Bug: T142484
Change-Id: I7732bf6db7ac63121d6ed1377c654ae8700895d1
2016-08-23 10:16:47 -05:00
jenkins-bot caef0269ac Merge "Fix renaming of parameters to another existing name" 2016-08-18 16:49:01 +00:00
jenkins-bot e6e6ae376c Merge "Fix renaming of parameters to the same name" 2016-08-18 16:47:45 +00:00
jenkins-bot 9e56136c0e Merge "Warn editors when they're adding blank TemplateData" 2016-08-17 16:47:11 +00:00
Alex Monk 05c83e5212 Fix renaming of parameters to another existing name
If the user tried to rename a parameter to "asd", but "asd" already existed,
we'd append "asd0", and the user would get "asdasd0". But what we actually
wanted to do was change it to "asd0".

Change-Id: I7fa05ed6fca54bc941e1843ebe6872a87383effb
2016-08-16 02:01:45 +01:00
Alex Monk aaa1841580 Fix renaming of parameters to the same name
Bug: T141574
Change-Id: Ifa26b5b215ec489415c47a0fbf72fbf2fcb3e09e
2016-08-16 02:01:27 +01:00
David Lynch 1564abd48d Dialog must listen for changes to the param names
Otherwise the second keystroke made while changing parameter names will cause
an error. I think this code previously assumed the change only happened once,
rather than on-keystroke.

Bug: T142889
Change-Id: I0e9c096a053667c51bbce74ee3ce1bd573ae7d49
2016-08-12 17:31:04 -07:00
Alex Monk 1de010108e Warn editors when they're adding blank TemplateData
Bug: T123207
Change-Id: I512ce01a0c7221e7636d26e546d1cbac5395b76b
2016-07-14 03:01:38 +01:00
Alex Monk 5fe2360d99 Move around parameter renaming logic to update paramOrder
Also make getNewValidParameterKey actually return (probably not necessary for
this commit but I discovered it in the process).

Bug: T138800
Change-Id: I94ec6729b98c126b609b747fe4ce04a5fc02f616
2016-06-29 13:41:04 +01:00
James D. Forrester c8f4e02651 build: Replace csslint with stylelint and bump others
Change-Id: I84a1b850073ffae51c1c35a4f371cbac23b0d94e
2016-05-20 13:14:59 +01:00
jenkins-bot dbd36a61d0 Merge "GUI data: Actually do something useful with the normalized type" 2016-04-08 19:29:41 +00:00
Alex Monk ba36cf6cfe GUI data: Actually do something useful with the normalized type
Nothing uses normalizedType

Bug: T131971
Change-Id: Ic3103a1d6022cc35602dc7f13b8762eac8af7f80
2016-04-08 19:48:48 +01:00
jenkins-bot 74f13b9914 Merge "GUI: Don't set format: null when outputting data" 2016-04-08 16:24:39 +00:00
Alex Monk 040c615165 GUI: Don't set format: null when outputting data
Bug: T131972
Change-Id: Ifa34049be9a04da9b5e6d95e22f3d393ebf562b6
2016-04-06 23:28:25 +01:00
Alex Monk 84b1ddf44c Localise names of types in HTML rendering
Reuses some messages, renaming them in the process.
Changes undefined on the client to unknown.

Bug: T61745
Change-Id: I2cf5c25acbe1c854c33b2eb3f23dc74393a456d4
2016-04-06 19:00:58 +00:00
James D. Forrester 9bb3c382f5 build: Bump devDependencies to latest and make pass
grunt-contrib-csslint   0.5.0  →  1.0.0
 grunt-contrib-jshint   0.11.3  →  1.0.0
 grunt-contrib-watch     0.6.1  →  1.0.0
 grunt-jscs              2.1.0  →  2.8.0

Change-Id: Ia6ca7c477b1c7ce8b3fc54994b1abf361c031eda
2016-03-24 08:54:20 -07:00
Bartosz Dziewoński 8e55adab59 [BREAKING CHANGE] Change default format to null instead of 'inline'
Don't enforce 'inline' as the default format if none is specified.
Instead preserve the unspecified value as 'null'. This allows
third-party tools to provide a better default experience when changing
existing content (e.g. by using smart detection to follow the format
already used).

Bug: T128337
Change-Id: I911c7999e3731c0125fc058118f8d7287d8f88f4
2016-03-01 22:53:27 +00:00
jenkins-bot 97f1b8797e Merge "Avoid calling repopulateParamSelectWidget multiple times on setup" 2016-02-25 20:52:19 +00:00
Ed Sanders 89f8b35018 Avoid calling repopulateParamSelectWidget multiple times on setup
Change-Id: I05ce3d8ff1109980248a0c2389298591f9b54553
2016-02-24 17:34:18 +00:00
jenkins-bot 109ee53725 Merge "Remove matching groups from regex" 2016-02-24 16:01:34 +00:00
Ed Sanders 2b5db1ed30 Remove matching groups from regex
Bug: T127898
Change-Id: I1cd040cafedf84785938564c5610be4601f41862
2016-02-24 15:59:59 +00:00
Ed Sanders 60883bf812 Included aliases in getAllParamNames
They are bound by they same uniqueness constraints as regular
parameter names.

Bug: T111320
Change-Id: Ia9c1593ec69e1aa97a07b769faf8c9f526dd2922
2016-02-24 15:13:20 +00:00
Ed Sanders 9dd781c18b Give drag handle an increased opacity on hover
Change-Id: Ic7f283b4d20cc8ba35924d4f79be6ba7d3414a78
2016-02-22 17:12:08 -08:00
Ed Sanders f11893573a Param list style tweaks
Change-Id: I244b010a4b1a06e33b31d029afaabe9290440e0f
2016-02-23 01:10:49 +00:00
Ed Sanders 4810a7552e Keep JSON data as an object (not a string) until the last possible point
Conversion to wikitext string can all happen in one place, and tests
are cleaner.

Change-Id: I42adc454dad0dcbb33d9395f8ced0b07a6535fed
2016-02-23 01:10:39 +00:00
Ed Sanders 5c7f50de62 Show param label in list if available
It looks like this is how the code was originally intended,
but 'name' and 'key' are the same thing.

Move the key to the 'alias' list where CSS already exists to
colour it differently.

Change-Id: Ieade122633cec14203f7959121e9cd7250bb9f7a
2016-02-21 02:43:54 +00:00
Ed Sanders beaea898c2 Make main template param select widget drag/drop re-orderable
Not having two lists of all the parameters seems like a good idea.

Depends-On: I30d1f7f56230d73eb47ccbf9881c0b952b15bd89
Change-Id: I5b2ba39fb7b98fc50816f63bc4fbfc9fe25e02a5
2016-02-21 02:43:48 +00:00
Ed Sanders 4bb9bb317a Fix splice re-ordering when moving items forward
Bug: T127203
Change-Id: I91824a4dff3faf9fc401e4824e568df3e891ea3f
2016-02-20 17:48:34 +00:00
Ed Sanders 6ac0d165b1 Fix documentation
Change-Id: I8c12afd193679762439ed3b189a8474ccd5b4c03
2016-02-20 17:48:33 +00:00
Bartosz Dziewoński d9e70f4285 Use MenuOptionWidget rather than OptionWidget for MenuSelectWidget items
The current way surprisingly mostly works, but you're supposed to use
the matching class. This fixes some styling inconsistencies.

Change-Id: I3f8ce19b1f96cc051b7ac987fa211d1b5ee9cc71
2016-02-19 18:55:16 +00:00
jenkins-bot 56e191aacb Merge "Fix linting paths and resulting errors" 2016-02-19 18:29:01 +00:00
Ed Sanders 384c9af747 Update language search/result widget
Change-Id: I646d89aa1dddbd31577810f0a8a1d8ddbabe3baa
2016-02-19 10:26:17 -08:00
Ed Sanders ce3ce51558 Fix linting paths and resulting errors
Change-Id: Ib415d306124df53be085e358e7b868aa1ced9fd1
2016-02-19 17:48:51 +00:00
Ed Sanders 2ea0e0e475 Fix case of class names
Change-Id: I74214eac20a52a3fd1f2e520522fbb5527421a2d
2016-02-19 13:16:29 +00:00
jenkins-bot a2eb417304 Merge "Fix mw.TemplateData.SourceHandler.prototype.extractParametersFromTemplateCode return doc" 2016-01-26 03:36:26 +00:00
jenkins-bot ba2565dec3 Merge "Don't show warning about already-known parameters that weren't imported" 2016-01-26 02:27:39 +00:00
jenkins-bot a99d959959 Merge "Try to put TemplateData in an existing noinclude at bottom of the page" 2016-01-25 12:11:58 +00:00