We probably used "edit" as strictly speaking it could be "edit"
or "create", and it's hard to tell which will happen before
inspecting the content.
However "manage" is a poor alternative and not a verb we use
anywhere else. "Edit" argualby covers "create" as well, and will
be much more familiar to users.
Bug: T317468
Change-Id: Ia0b5da50fc87bd250e85faf29613a6f97ca36459
Following examples such as "VisuaEditor" -> "the visual editor"
and "Flow" -> "structured discussions", exposing the "brand" name
of the extension to users is no longer consider best practice.
Instead refer to it simply as "template data".
Bug: T317468
Change-Id: I969ddb013f9b51de8c222bff4e4c5104c5a0ee0f
The Metrics.js script needs this, but the dependency is not specified
anywhere. This "accidentially" works because it's rather common that
the module is required by some other code on the page. I just found a
combination where this is not the case (a blank MediaWiki installation
with nothing but TemplateData, not even the WikiEditor).
Change-Id: I97a7c1d227316a222d7ca54adb400aa8dd769047
* This is most notably when adding a new parameter. The cursor should
start in the input field.
* Focus the first input field when editing a parameter, whatever that
input field is.
* Focus the big JSON editor when editing a map.
Change-Id: I5a3df626810007e83bd2300b540df75bc1b8cac4
There is sometimes a good reason to arrange code like this, especially
when the additional variable name acts as documentation and helps
explaining what's going on. I think this is not the case here.
Change-Id: I46f4a18a4f78f4b03cf063a226de3f43ba13b1a2
The short `|| defaultValue` pattern is very common in JavaScript.
Note that in JavaScript – in contrast to PHP – empty arrays and
objects are not considered "falsy".
Change-Id: I97935c4dc2276d48d53ade3f7b4fdc28b62d89ba
This was always comparing with the English description. The effect of
this was that the comparison was always false and the value always
set, even if it didn't change, resulting in unnecessary events being
fired. So this is only about performance but not really user facing.
Change-Id: Id7a46dbac81e2595478848bbf325eece21815bec
This patch includes two bugfixes:
1. The previous rule with a `p + p` didn't do what it was supposed to
do. It was adding a margin after the 2nd, 3rd and all following <p>
elements, but not between the 1st and the 2nd. It should have been
margin-top instead. The approach in this patch is different and
avoids the need to repead the 0.5em.
2. The red background color was not applied to the input fields any
more because OOUI doesn't use <input> elements any more.
Change-Id: Ia57b742e8b3cd29c1f55cd7e918f26f70eebab18
