Commit graph

2167 commits

Author SHA1 Message Date
thiemowmde da63a3fdc6 Add missing parser tests to cover parser hook and renderer
Without this the entire code in Hooks::render() is uncovered.

Change-Id: Id347b278b6b5eed5f660c317ed21410de7910a1b
2023-03-09 11:46:49 +01:00
Translation updater bot fe03b7710f Localisation updates from https://translatewiki.net.
Change-Id: I8c41a0df492990f1db09b88af916f80d429d4115
2023-03-09 09:06:19 +01:00
Translation updater bot b824ffb96c Localisation updates from https://translatewiki.net.
Change-Id: I53b07d31c5e761fabd5d7a4b685c9f8a08c6b6dd
2023-03-07 08:54:59 +01:00
Thiemo Kreuz 7a32cba3ef Split validation and normalization into separate services
This makes it possible to use these steps independent from each
other. For example, a future patch can get rid of the re-validation
that's done over and over again when the API is called.

A significant change is that this gets rid of an expensive deep
clone. It was necessary before exactly because validation and
normalization was intertwined. Normalized properties would mess with
the later inheritance.

Strictly splitting validation and normalization (and executing them
in this order) solved this. The only downside of this is that
inherited properties are validated twice. But this is much less of a
problem, compared to the deep clone, I would like to argue.

This was always covered by tests. You can still see the tests fail
when you flip the execution order of inheritance and parameter
validation.

Bug: T301337
Change-Id: Ie5728094f9ed813f53b709d8b5283c4b99dc7d63
2023-03-06 13:05:51 +00:00
thiemowmde 962e2828e0 Replace IDatabase with IReadableDatabase where possible
This is a much more narrow interface and really all this code needs
to know.

Change-Id: I2f20fadb8a9630cdb1b7baf9da70e0287db85de2
2023-03-06 12:38:42 +01:00
Translation updater bot 95332c2ef5 Localisation updates from https://translatewiki.net.
Change-Id: I0739dc40be8dbfbdd33c6858e8698ccbc6f264f4
2023-02-27 08:28:20 +01:00
Translation updater bot c389929ffc Localisation updates from https://translatewiki.net.
Change-Id: Id4f2935f145fbe1d97fbbf620c04612322c225af
2023-02-23 08:40:15 +01:00
Translation updater bot bd9af7e96d Localisation updates from https://translatewiki.net.
Change-Id: Ie4213569beaf8d8a3ed9696a4815d7d822f979e5
2023-02-22 09:01:35 +01:00
Translation updater bot 652ed9a3b1 Localisation updates from https://translatewiki.net.
Change-Id: I0b616fc2ccea2bfaa5b6bc51683f81b0749793c7
2023-02-21 08:21:55 +01:00
Translation updater bot 3bcb0458b5 Localisation updates from https://translatewiki.net.
Change-Id: I0d256f330b94a01e929b86430f57de8f5c415a1a
2023-02-20 09:47:26 +01:00
Translation updater bot 3df15c29f5 Localisation updates from https://translatewiki.net.
Change-Id: Ic7d4134ee2b7f14e2c1102c1bb82546ac705b1cc
2023-02-17 08:56:44 +01:00
Translation updater bot 5be63663e2 Localisation updates from https://translatewiki.net.
Change-Id: I0a0d35822144065c60da59cb2d01f78867575427
2023-02-16 08:47:27 +01:00
Translation updater bot f9d453adc2 Localisation updates from https://translatewiki.net.
Change-Id: I81f5966ee9b04eadab5aa182c6e141b45ee267a1
2023-02-13 08:31:14 +01:00
Translation updater bot d7199fa560 Localisation updates from https://translatewiki.net.
Change-Id: Ie310b9e0d9b3ca0d5c37fe9d51ca692be0d5be7b
2023-02-08 08:40:38 +01:00
Translation updater bot ae990174c6 Localisation updates from https://translatewiki.net.
Change-Id: Ia8f3cb568b70aa9b58500c8b49c62aba67d7158b
2023-02-06 08:46:25 +01:00
Translation updater bot 7c2c98edc1 Localisation updates from https://translatewiki.net.
Change-Id: I6c3d2ea5ffeea13bd2109dd359832db848a58140
2023-02-03 08:48:31 +01:00
Sam Smith 0f4d04e83f Use EventLogging::submit() to submit analytics events
EventLogging::logEvent() was marked as deprecated at the beginning of
2021 in I0cfd07295d4b51ca4805c79a28a9a4bd64ff7cc9.

Bug: T318263
Change-Id: I2d89784cc249e97954c9be05169f3060fd69945f
2023-01-30 18:20:16 +00:00
Translation updater bot 0e789fdbb4 Localisation updates from https://translatewiki.net.
Change-Id: I896a195d7317f23db13a279d2aa961b0ccc1420c
2023-01-30 08:30:55 +01:00
Translation updater bot def7355b09 Localisation updates from https://translatewiki.net.
Change-Id: Iec1df56a31e535d8e15a26ac51b9a44050ca8c91
2023-01-27 08:37:10 +01:00
Translation updater bot 0b53f80f43 Localisation updates from https://translatewiki.net.
Change-Id: I812aa4050f97e0f4e1b0ba823f0f99bea3e4f5f2
2023-01-26 08:52:46 +01:00
Translation updater bot a9b684ee15 Localisation updates from https://translatewiki.net.
Change-Id: I25287237b4f3c0b33c83d54cf2d0238122ba842c
2023-01-24 08:49:48 +01:00
Translation updater bot 063ca25270 Localisation updates from https://translatewiki.net.
Change-Id: I794c805a07fd0707f1cfc63229ba871ad115cfda
2023-01-23 08:24:12 +01:00
Translation updater bot 5cfc18f198 Localisation updates from https://translatewiki.net.
Change-Id: I178bc0e4f0769e91c831734a50db4d523659c571
2023-01-20 08:42:54 +01:00
Translation updater bot acc71f28b4 Localisation updates from https://translatewiki.net.
Change-Id: I4b2256bfd4deab1aceb68114c1f91628c2923089
2023-01-19 11:32:25 +01:00
jenkins-bot e507a3e972 Merge "Improve API examples" 2023-01-18 18:30:40 +00:00
Translation updater bot a9720ff610 Localisation updates from https://translatewiki.net.
Change-Id: I49d4a7b5f0efa410cf3e09d9bb915a181eb21b82
2023-01-18 08:30:38 +01:00
EpicPupper 1e0cecd494 Improve API examples
Bug: T271040
Change-Id: I5b9bbc932d887086d647ce89fb77d192a896d32d
2023-01-17 01:08:27 +00:00
Translation updater bot 8da02d58ce Localisation updates from https://translatewiki.net.
Change-Id: If35f31d9c6cd31e1268ee47f3fca62597acc02c1
2023-01-11 09:02:45 +01:00
Thiemo Kreuz ec72e43858 Move var declarations (and initializations) down in Dialog class
Note the code style in this file is already a mixture of some early
declarations and others that happen in place. We mostly prefer the
later nowadays because it makes the code much more readable. Some of
the code touched in this patch was really a little confusing, I would
argue.

Change-Id: Ib2777c6f6c86876c016e50d7bd2fe3d82c611914
2023-01-10 20:27:23 +00:00
jenkins-bot d1b7f188ad Merge "Reduce code duplication when switching dialog panels" 2023-01-10 01:41:11 +00:00
jenkins-bot 5bd60cee9e Merge "Fix broken maps panel in TemplateData editor" 2023-01-10 01:39:18 +00:00
Translation updater bot 5969457cda Localisation updates from https://translatewiki.net.
Change-Id: I920a42dff01c80a6a11ebaf3d9e805e87121a4b6
2023-01-09 09:29:24 +01:00
thiemowmde 73ec256285 Fix broken maps panel in TemplateData editor
A change in OOUI made .addItems() silently ignore non-array input.
The most robust fix is to make all callers follow the documentation
instead of relying on undocumented behavior.

The change to onMapItemRemove is not strictly needed but done to make
this piece of code much more robust.

Change-Id: I95f9a058766720d3809c3e56309326c2a91f2bcd
2023-01-05 16:47:00 +01:00
thiemowmde 8f6493a198 Reduce code duplication when switching dialog panels
Main change is that we don't map between strings and object
references any more but use the object references directly.

Change-Id: Iecc011f62089d902bb5cbd9ff3b4189d3258a2b4
2023-01-05 15:27:13 +01:00
Translation updater bot 5567d3c9d7 Localisation updates from https://translatewiki.net.
Change-Id: I77abf04867f26ed85380fb89ffb1b7a46ebb997e
2023-01-05 09:11:10 +01:00
jenkins-bot 9bca2b9d36 Merge "Set focus to first input field on all panels" 2023-01-04 19:17:52 +00:00
jenkins-bot 3e66ede265 Merge "Use type info instead of repeating individual field names" 2023-01-04 19:05:32 +00:00
Translation updater bot a7860516b8 Localisation updates from https://translatewiki.net.
Change-Id: Iea006af6de78ad14b62523f6dd4568f1a5a4bb5c
2023-01-04 08:29:54 +01:00
Translation updater bot db97ea522d Localisation updates from https://translatewiki.net.
Change-Id: I0559506367f17171dc3e4964f662c54c1755e80c
2023-01-03 08:21:37 +01:00
Translation updater bot 0d3114ac25 Localisation updates from https://translatewiki.net.
Change-Id: I872ae642c661048cc01c353c4defee0e6f2f0e39
2023-01-02 08:44:29 +01:00
Thiemo Kreuz 7d0f0da623 Use type info instead of repeating individual field names
The data structure at the top of Model.js uses types like "string",
"array" and so on. Fields that share a type behave identical. I find
it odd to repeat parts of this data structure in the code. That's
what the types are for.

Change-Id: Iae55c18ececb809a56e40d3179d2cde357309d0a
2022-12-31 10:45:48 +01:00
Translation updater bot 260fdf76df Localisation updates from https://translatewiki.net.
Change-Id: Id95df1299ffc63919eb624ae314d57124ff01e78
2022-12-29 10:02:39 +01:00
jenkins-bot dda14a168c Merge "Fix copy paste mistakes and outdated code documentation" 2022-12-29 01:12:27 +00:00
jenkins-bot 080eacfe08 Merge "Extract named isValidCustomFormatString() method" 2022-12-29 01:06:39 +00:00
jenkins-bot d24fc8ee2f Merge "Streamline code duplication in nested if in Dialog.js" 2022-12-29 01:01:27 +00:00
jenkins-bot 088b0c8600 Merge "Rename message not specific to suggestedvalues" 2022-12-29 01:00:27 +00:00
jenkins-bot b0cb613a58 Merge "Create dialog elements from "type", not from element name" 2022-12-29 00:57:03 +00:00
Translation updater bot 1d86dd01c4 Localisation updates from https://translatewiki.net.
Change-Id: I9f2e6e0086dc4314dc7477bbde4a4c8edaa97b5d
2022-12-26 09:11:18 +01:00
thiemowmde 981054937d Streamline code duplication in nested if in Dialog.js
… by turning the nested `if` around and simplifying the remaining
parts a little. This patch is intentionally minimized. More
meaningful changes will be done in the next patch.

Change-Id: I56cfa5c8ac8ca29acd42bd71786f5433e884e1b2
2022-12-23 12:06:36 +01:00
Translation updater bot 28c1471f10 Localisation updates from https://translatewiki.net.
Change-Id: Ic2e51ff97bd84c5c0c091153406cb69fb2c72ad7
2022-12-22 11:04:48 +01:00