From ef357ab4a2599bfa9b2d15b597dc26439efe00ca Mon Sep 17 00:00:00 2001
From: thiemowmde <thiemo.kreuz@wikimedia.de>
Date: Mon, 18 Sep 2023 17:43:09 +0200
Subject: [PATCH] Remove unused `return true` from addParam() method

It's always true and doesn't make any difference because of this.
I think the idea was to do some validation in the method. This
never happened and is done outside of the method instead (better
separation of concerns).

This is split from I1655174 to make it easier to review.

Change-Id: I48b7da75659365e5a2f72b680d40ee4b5b2904a2
---
 modules/ext.templateDataGenerator.data/Model.js           | 8 ++------
 .../ext.templateDataGenerator.editTemplatePage/Dialog.js  | 8 ++------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/modules/ext.templateDataGenerator.data/Model.js b/modules/ext.templateDataGenerator.data/Model.js
index 5dbe1c4b..2b1547d7 100644
--- a/modules/ext.templateDataGenerator.data/Model.js
+++ b/modules/ext.templateDataGenerator.data/Model.js
@@ -337,10 +337,8 @@ Model.prototype.importSourceCodeParameters = function () {
 
 	// Add sourceCodeParameters to the model
 	this.sourceCodeParameters.forEach( function ( sourceCodeParameter ) {
-		if (
-			existingArray.indexOf( sourceCodeParameter ) === -1 &&
-			model.addParam( sourceCodeParameter )
-		) {
+		if ( existingArray.indexOf( sourceCodeParameter ) === -1 ) {
+			model.addParam( sourceCodeParameter );
 			importedArray.push( sourceCodeParameter );
 		} else {
 			skippedArray.push( sourceCodeParameter );
@@ -386,7 +384,6 @@ Model.prototype.getExistingLanguageCodes = function () {
  *
  * @param {string} key Parameter key
  * @param {Object} [paramData] Parameter data
- * @return {boolean} Parameter was added successfully
  * @fires add-param
  * @fires change
  */
@@ -470,7 +467,6 @@ Model.prototype.addParam = function ( key, paramData ) {
 	// Trigger the add parameter event
 	this.emit( 'add-param', key, this.params[ key ] );
 	this.emit( 'change' );
-	return true;
 };
 
 /**
diff --git a/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js b/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
index da8abfe6..78a75ff0 100644
--- a/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
+++ b/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
@@ -757,14 +757,10 @@ Dialog.prototype.onAddParamButtonClick = function () {
 
 	var newParamKey = this.newParamInput.getValue().trim();
 	if ( this.model.isParamDeleted( newParamKey ) ) {
-		// Empty param
 		this.model.emptyParamData( newParamKey );
 	} else if ( !this.model.isParamExists( newParamKey ) ) {
-		// Add to model
-		if ( this.model.addParam( newParamKey ) ) {
-			// Add parameter to list
-			this.addParamToSelectWidget( newParamKey );
-		}
+		this.model.addParam( newParamKey );
+		this.addParamToSelectWidget( newParamKey );
 	}
 	// Reset the input
 	this.newParamInput.setValue( '' );