wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-28 01:30:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename "property" variable for clarity

Browse source 
"props" sounds plural, but it is the name of a single property.

Change-Id: I62184d00d03e297568e1c335f31c961aa6983406
This commit is contained in:
Adam Wight 2020-12-04 16:25:18 +01:00 committed by Awight
parent 5206188129
commit eb6b61b3a7
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
View file

@ -1081,7 +1081,7 @@ Dialog.prototype.addParamToSelectWidget = function ( paramKey ) {
* @return {jQuery} Editable details page for the parameter * @return {jQuery} Editable details page for the parameter
*/ */
Dialog.prototype.createParamDetails = function () { Dialog.prototype.createParamDetails = function () {
var props, type, propInput, config, paramProperties, var property, type, propInput, config, paramProperties,
paramFieldset, paramFieldset,
typeItemArray = []; typeItemArray = [];
@ -1090,20 +1090,20 @@ Dialog.prototype.createParamDetails = function () {
// Fieldset // Fieldset
paramFieldset = new OO.ui.FieldsetLayout(); paramFieldset = new OO.ui.FieldsetLayout();
for ( props in paramProperties ) { for ( property in paramProperties ) {
config = { config = {
multiline: paramProperties[ props ].multiline multiline: paramProperties[ property ].multiline
}; };
if ( paramProperties[ props ].multiline ) { if ( paramProperties[ property ].multiline ) {
config.autosize = true; config.autosize = true;
} }
// Create the property inputs // Create the property inputs
switch ( props ) { switch ( property ) {
case 'type': case 'type':
propInput = new OO.ui.DropdownWidget( config ); propInput = new OO.ui.DropdownWidget( config );
for ( type in paramProperties[ props ].children ) { for ( type in paramProperties[ property ].children ) {
typeItemArray.push( new OO.ui.MenuOptionWidget( { typeItemArray.push( new OO.ui.MenuOptionWidget( {
data: paramProperties[ props ].children[ type ], data: paramProperties[ property ].children[ type ],
// The following messages are used here: // The following messages are used here:
// * templatedata-doc-param-type-boolean, templatedata-doc-param-type-content, // * templatedata-doc-param-type-boolean, templatedata-doc-param-type-content,
@ -1113,7 +1113,7 @@ Dialog.prototype.createParamDetails = function () {
// * templatedata-doc-param-type-url, templatedata-doc-param-type-wiki-file-name, // * templatedata-doc-param-type-url, templatedata-doc-param-type-wiki-file-name,
// * templatedata-doc-param-type-wiki-page-name, templatedata-doc-param-type-wiki-template-name, // * templatedata-doc-param-type-wiki-page-name, templatedata-doc-param-type-wiki-template-name,
// * templatedata-doc-param-type-wiki-user-name // * templatedata-doc-param-type-wiki-user-name
label: mw.msg( 'templatedata-doc-param-type-' + paramProperties[ props ].children[ type ] ) label: mw.msg( 'templatedata-doc-param-type-' + paramProperties[ property ].children[ type ] )
} ) ); } ) );
} }
propInput.getMenu().addItems( typeItemArray ); propInput.getMenu().addItems( typeItemArray );
@ -1134,7 +1134,7 @@ Dialog.prototype.createParamDetails = function () {
break; break;
} }
this.propInputs[ props ] = propInput; this.propInputs[ property ] = propInput;
// The following classes are used here: // The following classes are used here:
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-actions // * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-actions
@ -1154,9 +1154,9 @@ Dialog.prototype.createParamDetails = function () {
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-type // * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-type
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-uneditablefield // * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-uneditablefield
propInput.$element propInput.$element
.addClass( 'tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-' + props ); .addClass( 'tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-' + property );
this.propFieldLayout[ props ] = new OO.ui.FieldLayout( propInput, { this.propFieldLayout[ property ] = new OO.ui.FieldLayout( propInput, {
align: 'left', align: 'left',
// The following messages are used here: // The following messages are used here:
// * templatedata-modal-table-param-actions // * templatedata-modal-table-param-actions
@ -1175,17 +1175,17 @@ Dialog.prototype.createParamDetails = function () {
// * templatedata-modal-table-param-suggested // * templatedata-modal-table-param-suggested
// * templatedata-modal-table-param-type // * templatedata-modal-table-param-type
// * templatedata-modal-table-param-uneditablefield // * templatedata-modal-table-param-uneditablefield
label: mw.msg( 'templatedata-modal-table-param-' + props ) label: mw.msg( 'templatedata-modal-table-param-' + property )
} ); } );
// Event // Event
if ( props === 'type' ) { if ( property === 'type' ) {
propInput.getMenu().connect( this, { choose: [ 'onParamPropertyInputChange', props ] } ); propInput.getMenu().connect( this, { choose: [ 'onParamPropertyInputChange', property ] } );
} else { } else {
propInput.connect( this, { change: [ 'onParamPropertyInputChange', props ] } ); propInput.connect( this, { change: [ 'onParamPropertyInputChange', property ] } );
} }
// Append to parameter section // Append to parameter section
paramFieldset.$element.append( this.propFieldLayout[ props ].$element ); paramFieldset.$element.append( this.propFieldLayout[ property ].$element );
} }
// Update parameter property fields with languages // Update parameter property fields with languages
this.updateParamDetailsLanguage( this.language ); this.updateParamDetailsLanguage( this.language );