From b87d37f482e4a21c33fe3de3d4d0fd1477b48200 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 13 Sep 2019 03:10:38 +0100 Subject: [PATCH] Merge 'ext.templateDataGenerator.ui.images' into 'ext.templateData.images' Only ever used together as dependencies for module 'ext.templateDataGenerator.editTemplatePage'. In the UI, they provide icons for the same dialog. The 'ext.templateData.images' module is also used in one other place, via addModuleStyles() on NS_TEMPLATE pages that use . The 'template-format-block' and 'template-format-inline' icons are used by the Parser output HTML for the documentation block. Having one unused icon there, preloaded for editing templatedata, seems acceptable given it's so tiny and basically was already being paid for on page views with the mere existence of the module taking up about as much space as the icon itself. Change-Id: If839100feca51d67bba7151878dfddd1bcbc372b --- extension.json | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/extension.json b/extension.json index 9eeec5be..688d6fe8 100644 --- a/extension.json +++ b/extension.json @@ -90,8 +90,7 @@ "ext.templateData.images", "ext.templateDataGenerator.data", "jquery.uls.data", - "jquery.textSelection", - "ext.templateDataGenerator.ui.images" + "jquery.textSelection" ], "messages": [ "comma-separator", @@ -187,20 +186,7 @@ }, "template-format-inline": { "file": "modules/images/inline.svg" - } - } - }, - "ext.templateDataGenerator.ui.images": { - "class": "ResourceLoaderImageModule", - "selectorWithVariant": ".oo-ui-icon-{name}.oo-ui-image-invert", - "selectorWithoutVariant": ".oo-ui-icon-{name}", - "variants": { - "invert": { - "color": "#FFFFFF", - "global": true - } - }, - "images": { + }, "parameter-set": { "file": { "ltr": "modules/images/parameter-set-ltr.svg",