wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-12 01:09:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Renaming misleading "type" variable

Browse source 
"children" is an array. See line #148 in Model.js. What's called "type"
here is just the numeric index in this array.

Change-Id: I73c190f754d113ac90f5df76fb8cc8b7a75fc927
This commit is contained in:
thiemowmde 2022-12-07 15:30:18 +01:00
parent fca0a973a2
commit b53d754639
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
View file

@ -1153,7 +1153,7 @@ Dialog.prototype.addParamToSelectWidget = function ( paramKey ) {
* @return {jQuery} Editable details page for the parameter
*/
Dialog.prototype.createParamDetails = function () {
var property, type, propInput, config, paramProperties,
var property, propInput, config, paramProperties,
paramFieldset,
typeItemArray = [];
@ -1173,9 +1173,9 @@ Dialog.prototype.createParamDetails = function () {
switch ( property ) {
case 'type':
propInput = new OO.ui.DropdownWidget( config );
for ( type in paramProperties[ property ].children ) {
for ( var i in paramProperties[ property ].children ) {
typeItemArray.push( new OO.ui.MenuOptionWidget( {
data: paramProperties[ property ].children[ type ],
data: paramProperties[ property ].children[ i ],
// The following messages are used here:
// * templatedata-doc-param-type-boolean, templatedata-doc-param-type-content,
@ -1185,7 +1185,7 @@ Dialog.prototype.createParamDetails = function () {
// * templatedata-doc-param-type-url, templatedata-doc-param-type-wiki-file-name,
// * templatedata-doc-param-type-wiki-page-name, templatedata-doc-param-type-wiki-template-name,
// * templatedata-doc-param-type-wiki-user-name
label: mw.msg( 'templatedata-doc-param-type-' + paramProperties[ property ].children[ type ] )
label: mw.msg( 'templatedata-doc-param-type-' + paramProperties[ property ].children[ i ] )
} ) );
}
propInput.getMenu().addItems( typeItemArray );