wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-30 18:44:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not add 'required' if not set and false wanted

Browse source 
The 'required' property of a 'Param' is optional and defaults to false.
Thus there is no reason for adding it when it was not set and the user wants it to be false.

Bug: 61761
Change-Id: I2b2fae5d2d8b1dac2ad2e1a965d9ba5bd7372eef
This commit is contained in:
Ltrlg 2014-02-21 20:57:56 +01:00 committed by Krinkle
parent 6e78aaa9b1
commit 6a014700da
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ext.templateDataGenerator.core.js
View file

@ -580,7 +580,7 @@
break; break;
case 'required': case 'required':
newValue = $domEl.prop( 'checked' ); newValue = $domEl.prop( 'checked' );
if ( paramObj[paramProp] !== newValue ) { if ( paramObj[paramProp] !== undefined || newValue === true ) {
paramObj[paramProp] = newValue; paramObj[paramProp] = newValue;
} }
break; break;