wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-15 11:58:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Don't store templatedata pageprop on doc-subpage"

Browse source
This commit is contained in:
jenkins-bot 2018-10-31 15:21:49 +00:00 committed by Gerrit Code Review
parent bce29bdc6e 326558fc77
commit 593d23fd36
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/TemplateDataHooks.php
View file

@ -128,7 +128,7 @@ class TemplateDataHooks {
*
* @return string HTML to insert in the page.
*/
public static function render( $input, $args, $parser, $frame ) {
public static function render( $input, $args, Parser $parser, $frame ) {
$ti = TemplateDataBlob::newFromJSON( $input );
$status = $ti->getStatus();
@ -137,7 +137,17 @@ class TemplateDataHooks {
return '<div class="errorbox">' . $status->getHTML() . '</div>';
}
$parser->getOutput()->setProperty( 'templatedata', $ti->getJSONForDatabase() );
// Store the blob as page property for retrieval by ApiTemplateData.
// But, don't store it if we're parsing a doc sub page, because:
// - The doc subpage should not appear in ApiTemplateData as a documented
// template itself, which is confusing to users (T54448).
// - The doc subpage should not appear at Special:PagesWithProp.
// - Storing the blob twice in the database is inefficient (T52512).
$title = $parser->getTitle();
$docPage = wfMessage( 'templatedata-doc-subpage' )->inContentLanguage();
if ( !$title->isSubpage() || $title->getSubpageText() !== $docPage->plain() ) {
$parser->getOutput()->setProperty( 'templatedata', $ti->getJSONForDatabase() );
}
$parser->getOutput()->addModuleStyles( [
'ext.templateData',