wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-23 23:43:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ParserOutput::getPageProperty() now returns null when key is missing."

Browse source
This commit is contained in:
jenkins-bot 2022-02-19 01:47:48 +00:00 committed by Gerrit Code Review
parent 73f3f79f50 453c4152af
commit 46e072e512
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
includes/Hooks.php
View file

@ -106,18 +106,21 @@ class Hooks {
}
// TODO: Remove when not needed any more, see T267926
// T301915
self::logChangeEvent( $revisionRecord, $parserOutput->getPageProperty( 'templatedata' ) ?? false, $user );
self::logChangeEvent( $revisionRecord, $parserOutput->getPageProperty( 'templatedata' ), $user );
return true;
}
/**
* @param RevisionRecord $revisionRecord
* @param string|false $newPageProperty
* @param ?string $newPageProperty
* @param UserIdentity $user
*/
private static function logChangeEvent( RevisionRecord $revisionRecord, $newPageProperty, UserIdentity $user ) {
private static function logChangeEvent(
RevisionRecord $revisionRecord,
?string $newPageProperty,
UserIdentity $user
) {
if ( !ExtensionRegistry::getInstance()->isLoaded( 'EventLogging' ) ) {
return;
}
@ -129,7 +132,7 @@ class Hooks {
$pageId = $page->getId();
// The JSON strings here are guaranteed to be normalized (and possibly compressed) the same
// way. No need to normalize them again for this comparison.
if ( $newPageProperty === ( $props[$pageId] ?? false ) ) {
if ( $newPageProperty === ( $props[$pageId] ?? null ) ) {
return;
}