Commit graph

1306 commits

Author SHA1 Message Date
libraryupgrader a0478fa896 build: Updating eslint-config-wikimedia to 0.27.0
Change-Id: If1214446c8011d643fb359db9f0e8a469aba3a5a
2024-04-20 01:17:47 +00:00
Jon Robson dda5d1e788 Adjust colors for remaining color contrast issues in night mode
Fixes the remaining issues on
https://en.m.wikipedia.beta.wmflabs.org/wiki/SyntaxHighlight?minervanightmode=1

Follow up to Ic58482b73e520505bde26a47e74f131dd8a51671

Bug: T356956
Change-Id: I71e74980a1ff276d61d2320cfedd92a55b659c7f
2024-04-17 16:52:26 +00:00
Jon Robson 92f155db14 Make syntax highlighting readable in night mode
The existing color of background if set to inherit will not work
in night mode. There does seem to be a background set in pygments.generated
so this probably doesn't need to be defined at all, but I erred on the side
of caution.

When defining a background that is not using a Codex design token
we also want to define a color to avoid the status quo of unreadable
text.

Note: this is a short term fix for making the content readable.
We can theme this in night mode later after further analysis.

Bug: T356956
Change-Id: Ic58482b73e520505bde26a47e74f131dd8a51671
2024-04-16 00:10:42 +00:00
Isabelle Hurbain-Palatin 3bc2ef11b5 Re-enable and fix tests for Parsoid CI
Bug: T214241
Depends-On: I022501851ea45cfd2554f9e914aa6f4fe2b07548
Change-Id: I34e32192047aaf268001b04bb936b3562686118b
2024-04-08 12:00:23 +00:00
jenkins-bot 2eb3bc3633 Merge "Disable a test for Parsoid CI" 2024-04-04 15:48:44 +00:00
Isabelle Hurbain-Palatin 2550f53d9c Disable a test for Parsoid CI
Bug: T214241
Needed-By: I022501851ea45cfd2554f9e914aa6f4fe2b07548
Change-Id: Ie3985837bc3fa679cf9b64cd6ab15b482402c18a
2024-04-03 03:01:10 +00:00
Umherirrender c0703d33ec build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Change-Id: If2acd67c6275e74e487a2e0ce8d34277a70782ca
2024-03-12 20:48:18 +01:00
jenkins-bot cae456cda1 Merge "Allow linelinks prefix to be any character(s)" 2024-03-11 19:15:03 +00:00
jenkins-bot e3cfcbd571 Merge "Allow line ranges to be selected using shift+click" 2024-03-11 19:14:46 +00:00
Ed Sanders d6cc861de7 Allow line ranges to be selected using shift+click
Change-Id: I224de2d2d72525b61608d7b6d0f13ce84a699ef7
2024-03-06 22:30:51 +00:00
Ed Sanders f5dd12e83b Allow linelinks prefix to be any character(s)
Old HTML IDs had to start with Latin letters, but
in HTML5 IDs can use any characters.

Bug: T359214
Change-Id: I6b6733eb07267faca1990bb7445a967405f9327e
2024-03-06 21:32:48 +00:00
Ed Sanders 963859f8c9 VE integration: Remove copyright dates
Change-Id: I424e7bb7ac64297b55a47db058605f528084c35e
2024-02-29 15:13:03 +00:00
Translation updater bot b5628f6dd7 Localisation updates from https://translatewiki.net.
Change-Id: Iba291d3f4b561155cc2057b6b4135a2770cbf863
2024-02-26 08:37:09 +01:00
Translation updater bot 661543164d Localisation updates from https://translatewiki.net.
Change-Id: Iee3cfcfb2d8e0c2c55001fe2bd3bf903a4fb2abe
2024-02-14 08:19:25 +01:00
libraryupgrader 7e6a675a6c build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* eslint-config-wikimedia: 0.25.0 → 0.26.0
* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: Ief4ab2a9dbc1183629342d1cdd9d681e7172e377
2024-02-10 23:26:57 +00:00
Translation updater bot 1cca390380 Localisation updates from https://translatewiki.net.
Change-Id: Ie4f9ac51d153e8941c876fe3393e22583f63cafe
2024-02-09 08:44:20 +01:00
libraryupgrader 74364d4901 build: Updating npm dependencies
* grunt-eslint: 24.0.1 → 24.3.0
* grunt-stylelint: 0.18.0 → 0.19.0
* stylelint-config-wikimedia: 0.15.0 → 0.16.1

Change-Id: Ibcdf5387e580fae80ba20ed79e4db948f6554a4c
2024-02-08 01:29:09 +00:00
Ed Sanders e350f10a7e Don't let native scroll happen when clicking on line links
Update the page hash with history.replaceState instead.

Change-Id: I9d7bc25876aaae929646cd7e5960a8f76ede94f3
2024-02-06 16:33:46 +00:00
libraryupgrader 1e52564851 build: Updating npm dependencies
* eslint-plugin-compat: 4.0.2 → 4.2.0
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
* postcss: 8.4.21 → 8.4.33
  * https://github.com/advisories/GHSA-7fh5-64p2-3v2j
* semver: 7.3.5 → 7.5.4
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
* word-wrap: 1.2.3 → 1.2.5
  * https://github.com/advisories/GHSA-j8xg-fqg3-53r7

Change-Id: I015d0a2ece4d59a26db5501dd48423d9ec5e2b2d
2024-02-04 12:47:46 +00:00
Translation updater bot 5cf5ee307d Localisation updates from https://translatewiki.net.
Change-Id: I0b7904c13320ea624487e2717e7461b1600207a3
2024-01-31 08:29:44 +01:00
thiemowmde 040f45302b Fix GeSHi support, update PHP/JSDocs, use modern PHP
The PHPDoc/JSDoc updates are mostly about generic "array" types that
can be made more specific.

In PHP we can remove documentation when it is 100% identical to the
type declarations in the code.

A few mistakes are fixed as well, e.g. a missing "null".

This patch also made a major mistake visible. It looks like the
$geshi2pygments compatibility map was broken since 2018. The array was
changed from values to keys via I7a852dd and some usages updated, but
one was forgotten.

Change-Id: I480999d21f2f69cba84166bb877aa75882778966
2024-01-22 20:10:04 +01:00
jenkins-bot 73e1073108 Merge "Add a few missing type declarations to properties and methods" 2024-01-22 14:21:55 +00:00
thiemowmde 006455ec37 Add a few missing type declarations to properties and methods
Most of the code in this codebase already uses language-level types.

Change-Id: I1df9439c69eec5ad0b2a9a608729975027a04172
2024-01-22 09:39:30 +01:00
thiemowmde 7a4d59accc Replace preg_replace() with more simple trim()
This does the same as before. Only newlines are trimmed from the
left, but all whitespace from the right.

Change-Id: I6b7c860d8a2fc2a1f28428447ee8f18ab4bbe46c
2024-01-22 09:37:01 +01:00
James D. Forrester ba1962b3ca extension.json: Drop RL targets definitions, no longer honoured
Bug: T328497
Change-Id: I6e8bed27247949b78cf8a8fcfe7097889a285fd0
2024-01-12 08:52:57 -05:00
Umherirrender 890a260032 Use namespaced classes
This requires 1.42 for some new names

Change-Id: I3821d2bca4aa8e7c0fce2a730c070b597c526247
2024-01-05 19:29:59 +01:00
Translation updater bot cdaaa6bfef Localisation updates from https://translatewiki.net.
Change-Id: I7d9c1bd86e813dec2ca3b35123be5fd7f202144d
2023-12-26 14:43:38 +01:00
Translation updater bot af417e2dbc Localisation updates from https://translatewiki.net.
Change-Id: I6daa1319f6242aa18895ea99159ffd0328ecee15
2023-12-21 19:45:59 +01:00
Translation updater bot 1315f06012 Localisation updates from https://translatewiki.net.
Change-Id: Iab33446a14cded3b1610d29c30be66f6081d4f98
2023-12-20 14:05:36 +01:00
Bryan Davis f8d8b55c8b Update Pygments to 2.17.2
Bump embedded Pygments version from 2.16.1 to 2.17.2. Changes
<https://github.com/pygments/pygments/compare/2.16.1...2.17.2>.

New lexers: bazel, jsx, kql, kusto, ldappconf, ldaprc, ldif, lean3, prql,
react, starlink, visualprolog, visualprologgrammar, vyper

Bug: T351744
Change-Id: Idcb40a211c051e74bdfb7c4ee642be64e0dde5ac
2023-12-01 15:43:32 -07:00
Translation updater bot b4b0c0c337 Localisation updates from https://translatewiki.net.
Change-Id: I774c58369eaa49898bf1da0a557706be2c6afbb2
2023-11-27 08:33:34 +01:00
Translation updater bot 9e333b5643 Localisation updates from https://translatewiki.net.
Change-Id: I2db9086f83ada1dd6433067d7adbacd440abab40
2023-11-23 11:57:37 +01:00
Translation updater bot 03dcff4ae6 Localisation updates from https://translatewiki.net.
Change-Id: Ib79e88683c007dce19d0849c34645c9ff2fad8e5
2023-11-22 08:20:51 +01:00
jenkins-bot 36988ac086 Merge "Set hasWikitextInput flag to false" 2023-10-03 20:59:13 +00:00
Isabelle Hurbain-Palatin e4e8f8e076 Set hasWikitextInput flag to false
The content of the SyntaxHighlight extension is not wikitext and
annotations should be stripped from it before rendering.

Bug: T341009
Depends-On: I4e9a7a8bec3cb9532ef8a729fd2c6c4acca5d8a0
Change-Id: Ibada54d517830b1112b59513b090dc4bbdc7c917
2023-10-03 20:52:29 +00:00
Subramanya Sastry 9c125346a8 Re-enable Parsoid testing
I think the syntax for parsoid-compatible may have changed at some
point and these tests probably never ran against Parsoid for a while now.

Change-Id: I9d7b23b180995eeadb4e3d183a0e970040ef6c78
2023-10-02 14:48:04 -05:00
Translation updater bot 12faa8fb06 Localisation updates from https://translatewiki.net.
Change-Id: Ie6473f7f7feb1b00aef33849fb10c468e694e006
2023-09-21 10:16:44 +02:00
gerritbot fc431bcd8d Replace some moved Title class uses, now MediaWiki\Title\Title
Bug: T321681
Change-Id: I7a26d8653e2ed41ab65e8b199c748d1a9e6a80d6
2023-08-19 12:26:03 +00:00
James D. Forrester df82704192 build: Update MediaWiki requirement to 1.41
All extensions in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: I9e5a7dcb0d54c0f763883934939e197b1bc325a9
2023-08-19 14:08:26 +08:00
Translation updater bot 6fcb317ede Localisation updates from https://translatewiki.net.
Change-Id: I37ba72a4e740f1a554caaf685551de6d9570af4e
2023-08-17 12:10:51 +02:00
Bryan Davis 99ce3504ba Update Pygments to 2.16.1
Bump embedded Pygments version from 2.15.0 to 2.16.1. Changes
<https://github.com/pygments/pygments/compare/2.15.0...2.16.1>.

New lexers: asn1, blueprint, bqn, desktop, graphql, openscad, ptx,
systemd, tls, urlencoded, verifpal, yar, yara, zon

Bug: T335460
Change-Id: I9577e2f38c8404698c5079033c3cd9742e8b383f
2023-08-15 04:03:17 +00:00
Umherirrender 7087e991d5 Use HookHandlers for core hooks
The use of "HookHandlers" attribute in extension.json makes it possible
to inject services into hook handler classes in a future patch.

Bug: T271029
Change-Id: I6df44cf4a160e618a6546fb9eec36070bf4b868e
2023-08-14 20:23:40 +02:00
Translation updater bot b50b94da93 Localisation updates from https://translatewiki.net.
Change-Id: Icf385284c421993cce13bb294eaa6b7f1abd50e6
2023-08-08 09:01:40 +02:00
Translation updater bot 65d55394f5 Localisation updates from https://translatewiki.net.
Change-Id: I8bb86c594da02016a31fbf32b98b35dd15a58fff
2023-07-24 09:39:51 +02:00
Translation updater bot f4bbbcab54 Localisation updates from https://translatewiki.net.
Change-Id: I893f20b2729bcf4e2a70585ab7fc59b805a24de1
2023-06-26 12:41:05 +02:00
Translation updater bot 25d2109bec Localisation updates from https://translatewiki.net.
Change-Id: I454398796cb8d049218b54e114739fe143b48648
2023-06-09 09:14:57 +02:00
Daimona Eaytoy 52ac696e25 Replace deprecated MWException
Bug: T328220
Change-Id: Iaf4a9bb4aafc741395d5ccc5a42c6a72b5d42b99
2023-06-08 11:14:08 +00:00
jenkins-bot 81f673bc6d Merge "Pygmentize: Treat Shellbox network loss like non-zero exit code" 2023-06-06 23:55:12 +00:00
Ed Sanders 274cc4ab77 Always use the strict equality flag when using in_array
Change-Id: Iedd51f31db2bc4e5257d211719f8bdcf1abb09dd
2023-06-06 13:35:40 +01:00
Timo Tijhof 682fe922f9 Pygmentize: Treat Shellbox network loss like non-zero exit code
Prior to the shellbox migration, if during the parsing of a page,
pygmentize failed (i.e. non-zero exit from its local shell command,
pretty much the only way a php shell exec could fail), then
SyntaxHighlight would fallback to outputting a preformatted plain
`<pre>`.

The logic still exists in the code, and is still triggered for cases
where the command reached shellbox and its result was "successfully"
communicated to MediaWiki (HTTP 200), with the boxed result reporting
the non-zero exit code on the shellbox server.

However, the more likely scenario in the new setup is that the command
times out or never reaches the server in the first place, in which
case we don't get any shell exit code. Instead, we get a Shellbox
exception since the result is unknowable.

Instead of fatalling the entire pageview with a PHP exception and
HTTP 500 from MW, use the same graceful fallback.

Bug: T292663
Change-Id: Icaa8c34ff97ad8a99d044beab529ef943071269c
2023-06-03 14:25:50 +01:00