Bartosz Dziewoński 5ddc45b62c Actually return errors for action=edit API ... Setting 'apiHookResult' results in a "successful" response; if we want to report an error, we need to use ApiMessage. We already were doing this for action=upload. Now our action=edit API responses will be consistent with MediaWiki and other extensions, and will be able to take advantage of errorformat=html. Additionally, remove incorrect 'message' value from action=upload output. It was anyway redundant to the normal error information. To avoid user interface regressions in VisualEditor, the changes I3b9c4fef (in VE) and I106dbd3c (in MediaWiki) should be merged first. Before: { "edit": { "spamblacklist": "example.com/test|example.net/test", "result": "Failure" } } After: { "errors": [ { "code": "spamblacklist", "data": { "spamblacklist": { "matches": [ "example.com/test", "example.net/test" ] } }, "module": "edit", "*": "The text you wanted to save was blocked ..." } ], "*": "See http://localhost:3080/w/api.php for API usage. ..." } For comparison, a 'readonly' error: { "errors": [ { "code": "readonly", "data": { "readonlyreason": "foo bar" }, "module": "main", "*": "The wiki is currently in read-only mode." } ], "*": "See http://localhost:3080/w/api.php for API usage. ..." } Bug: T229539 Depends-On: I106dbd3cbdbf7082b1d1f1c1106ece6b19c22a86 Depends-On: I3b9c4fefc0869ef7999c21cef754434febd852ec Change-Id: Id36aa6bdb8f873fe7deb8123a7fc774103721c01		2019-09-10 20:44:35 +00:00
..
.eslintrc.json	build: Replace jshint with eslint	2018-11-30 21:14:16 +00:00
ve.init.mw.SpamBlacklistSaveErrorHandler.js	Actually return errors for action=edit API	2019-09-10 20:44:35 +00:00