Commit graph

11 commits

Author SHA1 Message Date
Aude 2745442aec Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent"
For Wikidata, this causes users to be unable to create items. (bug 59797)

In case of Special:NewItem, $context->getWikiPage() does
$context->getTitle() to get the special page and then WikiPage::factory
with the special page $title.  special page does not make a valid
WikiPage and throws an exception.

Previously, $title = special page and was used in getParserOutput.
$title is invalid there but Wikibase never used that variable.

Would be good to make sure $title is actually related to the content.

This reverts commit 508a3706d6.

Change-Id: Ib24515be6e76d3f29e2f9048fbb81e5a25b5857a
2014-01-07 21:57:47 +00:00
Brad Jorsch 508a3706d6 Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent
Using WikiPage::prepareContentForEdit instead of
Content::getParserOutput allows us to share the cached parser output
with other hooks that run during the edit process.

Note SpamBlacklistHooks::filterAPIEditBeforeSave already does this.

Bug: 57026
Change-Id: I8c8b293af2842411fd95d3bc21e966a72b2a78b4
2013-12-14 10:24:33 -05:00
daniel a3defb8b91 (bug 51621) Make SBL aware of ContentHandler.
This changes SpamBlacklist to make use of the new, ContentHandler
aware hooks.

This change also includes some refactoring and cleanup which made
the migration to the new hooks easier.

Change-Id: I21e9cc8479f2b95fb53c502f6e279c8a1ea378a5
2013-08-24 19:55:55 +02:00
Siebrand Mazeland 2e6259f35f (bug 45461) Use email instead of e-mail
Change-Id: Ibad4c4c7c98f5b0c746d62f1b2b41a4a99360ee8
2013-02-27 12:50:47 +01:00
Siebrand Mazeland e9874344aa Maintenance for SpamBlacklist extension.
* Replace deprecated methods. MediaWiki 1.19 required.
* Replace <tt> with <code>.
* Update documentation.
* Use WikiPage instead of Article for doEdit().
* Use __DIR__ instead of dirname( __FILE__ ).
* Remove superfluous newlines.

Change-Id: I3a0e42ca404638f7c7934c316735ad11cbc99d42
2012-09-03 16:50:18 +02:00
jarry1250 20058848ab Other half of fix for bug #30332 ("API spamblocklist error should
provide all blocked URLs").

SpamBlacklist extension to provide all matched URLs to
spamPageWithContent() rather than just one. Performance
hit negligible and zero for all edits that don't hit the
SpamBlacklist (99.999%+).

DEPENDENT ON OTHER HALF OF FIX (now in core):
https://gerrit.wikimedia.org/r/3740

Change-Id: Ia951d5795c5cedb6c3876be89f8a08f110004102
2012-03-27 21:42:49 +01:00
Max Semenik 4a433ff423 Fix r109111: no point in aborting hook execution 2012-02-15 14:58:26 +00:00
Sam Reed f229bcf0fb Fix fixme on r109111 per Tbleher 2012-02-02 22:12:43 +00:00
Robin Pepermans ed81c5b979 Follow-up r109455: make it clear that it's about e-mail *addresses*, also fix consistency: email -> e-mail and E-mail -> e-mail. 2012-01-21 15:05:49 +00:00
John Du Hart aaf4d74d18 Adding Email blacklisting to the SpamBlacklist extension
This relies on r109111
2012-01-18 23:29:37 +00:00
John Du Hart 62b2bde146 Refactored SpamBlacklist to be extendable for other blacklist types
This is the groundwork for Bug 33761
2012-01-17 06:13:46 +00:00