Commit graph

37 commits

Author SHA1 Message Date
Umherirrender 7da5c87df0 Add function documentation
Change-Id: I3a8c0c6576f5a0bb1f68f906a8ec37ec079924f4
2024-11-25 22:16:37 +01:00
Umherirrender 4bac912eb3 Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: Ifa450560a587a9d51de91b6f5a855f82d4fd8fe4
2024-10-20 11:55:49 +02:00
Wandji69 b93b997de5 Use ObjectCacheFactory instead of deprecated ObjectCache methods
Bug: T363770
Change-Id: I235642d059855a8c5f7296095965687ae73c6efb
2024-05-29 18:07:48 +00:00
libraryupgrader fb751efbc5 build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: I7ad279ce54fd99dcdef439718b32baad112de9e9
2024-02-12 19:01:28 +00:00
Umherirrender fc369e9457 Use namespaced classes
This requires 1.42 for some new names

Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: I9a7df2df9407ef10d855bc19db247983682a5fc8
2024-01-05 19:28:12 +01:00
gerritbot effea0bde6 Replace some moved Title class uses, now MediaWiki\Title\Title
Bug: T321681
Change-Id: I36f07ad64f90049b412969654cff0d3da31777e6
2023-08-19 04:19:23 +00:00
Tim Starling 51941a42ec Disable remote loading during PHPUnit tests
Bug: T65015
Change-Id: I205c5e247f314f734178f6c745eaa507f736083a
2023-07-04 09:37:12 +10:00
Reedy 53e7ef575d Drop 'BaseBlacklist' class alias
Depends-On: I724f5f2352bee20a82697fe090e99832405d82af
Change-Id: Idfc003d5f34799398d3bfd28aa532893461b30c9
2022-11-29 14:35:54 +00:00
Thiemo Kreuz f7ab8d10be Make various generic "array" type hints more specific
Includes fixing a misplaced count(). Looks like this issue was
introduced in 9bb2bc11 in 2006.

Change-Id: I27cb11419aa828330f4e06f06295f459b430fdbf
2022-10-04 12:37:47 +02:00
Reedy 52bb0939d9 Namespace extension
Change-Id: Ie53302078d5f405eaa6caef3b7ef4daebf47d877
2022-04-08 13:41:20 +00:00
Umherirrender a5c4f5bb4d Use new namespace for MediaWiki\Revision\SlotRecord
MediaWiki\Storage is alias since 1.35

Change-Id: I24ed7c7893d6b949ab847bb5dfe703ca5d49c39d
2022-02-26 22:17:53 +01:00
libraryupgrader 5cf47545c7 build: Updating composer dependencies
* mediawiki/mediawiki-phan-config: 0.10.6 → 0.11.0
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1

Change-Id: Ib6db3984f5892a13461defbbe9f191ceb75853c8
2021-09-09 11:41:40 +00:00
Reedy 4cbdb4fbc2 Add grepability comments
Collapse one nested if

Change-Id: I0d01239bc9ca3999688df2bb6d6360ccf563d956
2021-03-01 17:38:38 +00:00
Daimona Eaytoy 6ad12a26dc Make User parameter required in BaseBlacklist::filter
Depends-On: Idf346b7d5952c1af1547d178a3634d1116d4f85b
Depends-On: I7fe28c67e5a95de870ac98b4f2571733f4a7d302
Change-Id: I62478bec3a284b7aa56ea94f49be30199a6be3e4
2020-11-24 06:16:42 +00:00
Daimona Eaytoy da1af447e2 Always pass a User object to SpamBlacklist::filter
There are some usages outside of SpamBlacklist that must be fixed. After
doing that, the signature should be updated to make the user
non-optional.

Note: I've changed the signature because external callers only pass the
first two parameters. Hence, it's easier to change it now, add a
User parameter to the callers and then make it non-optional, than having
to pass $preserveLog and $mode in all callers and then swapping the
order (as that would break the world).

Change-Id: I0714eb9dbc6af3c775ab7a81cb4b59e687183f77
2020-11-10 19:13:01 +00:00
Ammar Abdulhamid 4c8c7bbb51 Remove manual passing of $this to closures
For a long time (since PHP 5.4.0) this indirection is unnecessary.

Change-Id: I1bf83f24e9b8762e929520bc94845b77ead511e6
2020-10-26 06:58:12 +00:00
daniel 5b0da2baf3 Ensure instance cache does not interfere with tests.
Tests need a way to rest BaseBlacklist::instances, so they can be sure
they operate on a clean slate. This is also needed to ensure they do not
operate on real settings, targetting a real remote host.

Bug: T262443
Change-Id: Ic320f7a72da7f26e0931ce3d393fc5a61d43d4fc
2020-09-29 17:20:44 +00:00
Umherirrender 1f70c7ce00 Pass function name to HttpRequestFactory::get
Useful for logging
Replace deprecated Http::get with service (since 1.34)

Change-Id: I84382c37295e3b09a660983b206b526f19334568
2020-06-07 13:04:51 +02:00
Timo Tijhof 423a6983bd Remove use of internal $messageMemc variable
Same as I04a0e578d7 in TitleBlacklist extension.

Bug: T189966
Bug: T243175
Change-Id: Ifc14f2ee1f176d025d6d1c6158405277f20a1ac1
2020-03-18 17:14:41 +00:00
libraryupgrader 4d1029117e build: Updating composer dependencies
* jakub-onderka/php-console-highlighter: 0.3.2 → 0.4.0
* mediawiki/minus-x: 0.3.2 → 1.0.0
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.1

Change-Id: I2930f838e914f9b3f7917e773038c197af019851
2020-01-30 12:24:37 +00:00
libraryupgrader 2d3b9f1d61 build: Updating mediawiki/mediawiki-phan-config to 0.9.0
Change-Id: I56fbe7470e6dbc7ee2a2e381dc9e811db4b79224
2019-12-29 00:01:51 +00:00
Umherirrender f287bf7950 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: I326457e7779882bcc945753b9406605e76302e8a
2019-11-04 20:04:48 +01:00
daniel 9d55ccf86c Remove backwards compatible code.
Per Krinkle's comment at
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SpamBlacklist/+/504797/1#message-fb539927b0a2241080960229b9dc2453f6fcd78f>, no backwards compatibility is needed.

Change-Id: Icbf005840d734c7d14a380197f2239a07ba53dbf
2019-09-27 10:52:33 +02:00
daniel 6d559a12fe Support MCR database schema.
This maintains backwards compatibility with MW 1.31.

Cross-wiki loading functionality verified manually.

Bug: T233358
Change-Id: I53e218d8d268060b0b81c5c9bab24b7f5a37917a
2019-09-23 14:49:13 +02:00
Niklas Laxström e74a0120a0 Random cleanups
Change-Id: I0748d1b2062cc8f81175e07c4785eb11e784fe28
2019-09-12 16:19:13 +02:00
Bartosz Dziewoński 2f1456c4e9 Remove backwards compatibility code for Revision::getQueryInfo()
Revision::getQueryInfo() was added in MediaWiki 1.31. We already
require that or later in our extension.json, so we can safely drop it.

The deprecated methods called by this code have been recently removed
(Id35544b879af1cd708f3efd303fce8d9a1b9eb02) and calling them is
causing Phan failures.

Change-Id: I474367d00c6d3917f1416023901132c0649b3163
2019-09-10 22:41:34 +02:00
Derick Alangi b9c0f0709b Avoid usage of deprecated $wgContLang global (dep in 1.32)
Change-Id: Ia87a464c22be764deacd699fb66f96a663ccfe7c
2019-09-02 09:49:39 +01:00
Derick Alangi 4d939a399a Avoid usage of deprecated ObjectCache::getMainWANInstance()
Replacement with services made available in 1.28 and this extension
requires 1.31. So, the replacement is good.

Change-Id: I1960a36541c9578abc3178a3a5ddcac7c32b8292
2019-07-03 13:53:41 +01:00
jenkins-bot 81ae3d404d Merge "Remove deprecation note in comment" 2019-05-31 20:33:34 +00:00
Daimona Eaytoy 25b65a40fe Migrate to new Phan
Bug: T216942
Change-Id: I92c55f8af579a92baa02d9bd1b25b8290f0cd196
2019-03-09 12:42:42 +00:00
Adam Wight 1c9b42b619 Remove deprecation note in comment
The method is alive and well, used by the pageSaveContent hook.

Change-Id: I0764cbfc090b634b30ffe15c77dc303874c87ae2
2019-01-02 11:15:49 -08:00
Umherirrender 2f715fdf33 Add method scope visibility
Change-Id: I405c27b802000155609e8d32efc5016d8b2fba60
2018-11-02 12:54:59 +01:00
libraryupgrader 06c6c73ef4 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: I075a20dc74586318abae470758f3583597692ad3
2018-09-03 19:29:35 +00:00
libraryupgrader 54ac4af184 build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
Change-Id: Ic30d624822b5228f201e6b4183075bd591e3e675
2018-07-27 19:06:44 +00:00
Jack Phoenix 09ca11cd7c wfMemcKey no more!
Change-Id: I7adcbbc1f198230b3c5b6cf6e8cffb34db6d8c9d
2018-06-28 16:45:40 +03:00
Kunal Mehta b5f42b8a74 Add phan configuration
Introduce BaseBlacklist::getSpamBlacklist() and getEmailBlacklist()
as type-documented alternatives to getInstance( 'email/spam' ) so we
don't need to keep documentating types in a comment when using a function
that isn't included in the base class.

Change-Id: Ic8bd8f803ddbce1294707d5f1d62b701e24d8c6e
2018-02-24 17:26:25 -08:00
Kunal Mehta ac0204b70a Move classes to includes/
Change-Id: Ica7abee84a4e17c530cb755687849a998068be70
2018-02-24 17:08:28 -08:00
Renamed from BaseBlacklist.php (Browse further)