The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic
* MediaWiki.Commenting.PropertyDocumentation.WrongStyle
Additional changes:
* Added the `wikimedia/mediawiki` profile in .eslintrc.json (T262222).
* Added the `wikimedia/jquery` profile in .eslintrc.json (T262222).
* Removed global `$`, included in the `wikimedia/jquery` profile (T262222).
* Removed global `mw`, included via `wikimedia/mediawiki` profile (T262222).
* Dropped the emtpy global definition in .eslintrc.json.
Change-Id: Ib0acbf92bcb8327ecd065db5db1083d7b222976c
Additional changes:
* Removed phan-taint-check-plugin from extra, now inherited from mediawiki-phan-config.
Change-Id: I83fff3a5ff566790bc051d7bfffe7f3b124d3de7
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.VariadicArgument.SuperfluousVariadicArgComment
Additional changes:
* Replaced "jakub-onderka" packages with "php-parallel-lint".
Change-Id: I97d1101854d87f7d0d4c8f14b629bee75df6030d
This also lets us remove .minus-x.json, as it now recognizes all three
executables as such under all supported versions of PHP (7.2 to 7.4).
Change-Id: I3eeaf778af9df56ef3783b6f30767397add312f4
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.WrongStyle
Change-Id: Ifa2c7a7febc1e06c28318305cfef0b0103c6e8eb
* grunt-stylelint: 0.10.1 → 0.13.0
* stylelint-config-wikimedia: 0.4.3 → 0.8.0
Additional changes:
* Remove direct "stylelint" dependency in favor of "grunt-stylelint".
* Also sorted "composer fix" command to run phpcbf last.
Change-Id: Ic087c1d4a6f6d7ec48da8c498a9b9d81063ce0e4
The plugin checks and flags potential security issues (XSS, SQLi, etc.)
using static analysis.
See <https://www.mediawiki.org/wiki/Phan-taint-check-plugin> for more
details.
Change-Id: I09c53f9148aad57f73ddf917a84d053e48c07037
The following sniffs are failing and were disabled:
* MediaWiki.Usage.ForbiddenFunctions.popen
* MediaWiki.Usage.ForbiddenFunctions.proc_open
* MediaWiki.Usage.ForbiddenFunctions.shell_exec
Change-Id: I39e352194565a5526c1a8a34992c028fb305b03b
Manually import LuaSandbox's git repository as a composer dependency to
provide the PHP stubs for phan.
Change-Id: I6226b9211f31d829da5a2775c6f5cf3599dd8ebc
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PhpunitAnnotations.NotTestClass
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
Change-Id: I56ea06397c7c2b586cc9dca2425535eb565ea231
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.MissingCovers.MissingCovers
Change-Id: I07b2cf945f44fd5532812a712f7dd40d2f208be2
The following sniffs are failing and were disabled:
* Generic.Files.OneObjectStructurePerFile.MultipleFound
* Squiz.Scope.MethodScope.Missing
The following sniffs now pass and were enabled:
* MediaWiki.Files.OneClassPerFile.MultipleFound
Change-Id: I7499d975eb378abd500619f0026a32b59fe6dda6
The following sniffs now pass and were enabled:
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
Change-Id: I46b57e97547d05722f3c72722e7a6587db96831a
I'm told[1] these keys are for making the exitension installable via
composer, which is something we don't want and is deprecated.
The keys kept are for installing dependencies of the extension via
composer, which we do want.
[1]: See http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/20160823.txt at timestamp 17:46:17.
Change-Id: I87c2ea5960444218646de166ca8dd0e2d730712f
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.OneClassPerFile.MultipleFound
Change-Id: I1d70fb8c7ef406b40303bf21fdc9bc130e0585a6
