wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-24 16:25:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
971 commits 165 branches 0 tags 29 MiB
Commit graph

9 commits

Author SHA1 Message Date
Brad Jorsch aa4d72e3ff Fix uncontroversial phpcs errors 
The following continue to be ignored:
* Generic.Arrays.DisallowLongArraySyntax.Found, because I'm not sure
  Scribunto is ready to abandon old version support in master.
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures,
  because it's overly strict for its purpose.

Squiz.Classes.ValidClassName.NotCamelCaps isn't ignored globally, we
just ignore it explicitly every place it's needed.

Change-Id: I307668da6ef7b3e23da19b1fd1e08914239b99b3
 2016-05-18 16:31:28 -04:00
Thiemo Mättig 55fe0b69d0 Add missing visibility keywords everywhere 
Change-Id: I270d1dd9b6545e15398c2f8b8e9ae533844cc998
 2014-11-14 10:10:23 +01:00
Thiemo Mättig 61af67b819 Fix visibility of setUp/tearDown 
Required for Idf44d31.

Change-Id: If6d270549290bed2d1c7617da0fedbd385f3e96c
 2014-11-12 12:28:58 +01:00
addshore e29c8eda63 Use public instead of var in classes 
Change-Id: I0c059515cbf0fa8ef3846526a989f1a322fcd8ae
 2014-08-17 22:11:26 +01:00
Brad Jorsch 8872dd3eda Update phpunit @group annotations 
Some tests weren't being run as they should have been when phpunit's
--group option was used.

Change-Id: I29ff9a04322b91cc085247e5663dfc7bc67d3439
 2013-11-01 11:56:24 -04:00
Brad Jorsch 981ea4c39f Fix unit test engine↔parser assignment 
In the unit tests, the engine is given a parser, but the parser is not
being associated back with the engine. So in some cases, that could lead
to *another*, default engine being created for certain operations.

Fix that.

Change-Id: I79995c2635d9e470931b84dc1854dae26772bbe3
 2013-03-07 01:42:19 +00:00
Brad Jorsch ce46700ec9 Fix unit tests after I62259b76 
The unit tests never set the title on the engine.

Change-Id: Iefa11cacd4f10a1daa185b2e2a0d9620bbbfa6c6
 2013-02-07 15:59:38 -05:00
Brad Jorsch 10aa7dce46 Fix reference handling in LuaEnvironmentComparisonTest 
The Lua engines cannot handle circular data structures. Avoid returning
one for this test.

Change-Id: I7483c29fa440110bc4567bdd4807b035d7475ffc
 2013-01-24 15:21:53 -05:00
Brad Jorsch 27f9cb5d91 Unit test: verify LuaSandbox and LuaStandalone are equivalent 
We should include a unit test to try to ensure that we don't add
features to one environment and forget about the other.

Change-Id: I72b1acf8eea4a05e05fed1efeb0663a3eff9278a
 2012-12-13 13:53:29 -05:00