wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-09-23 10:22:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Replace assertEmpty with assertCount

Browse source 
Change-Id: I0002bb228701a3a5184ac7f1e38321bf10b23064
This commit is contained in:
Umherirrender 2022-11-24 22:51:38 +01:00 committed by Thiemo Kreuz (WMDE)
parent 64b010e9f7
commit a0732c2db8
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.phpcs.xml
View file

@ -1,7 +1,6 @@
<?xml version="1.0"?>
<ruleset name="Scribunto">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.PHPUnit.AssertEmpty.AssertEmptyUsed" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.popen" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.proc_open" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.shell_exec" />

2
tests/phpunit/Engines/LuaCommon/LuaCommonTest.php
View file

@ -127,7 +127,7 @@ class LuaCommonTest extends LuaEngineTestBase {
);
$leakedGlobals = array_diff( $actualGlobals, self::$allowedGlobals );
$this->assertEmpty( $leakedGlobals,
$this->assertCount( 0, $leakedGlobals,
'The following globals are leaked: ' . implode( ' ', $leakedGlobals )
);
}