wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-24 00:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove "Allow saving code with errors"

Browse source 
This was never really a good idea. If you really want to save incomplete
code, you can put it all in a block comment. Since some modules may still
have errors from before this change, the tracking category for them has
not been removed.

Change-Id: Icb3da00a86b9773287dcd0c9277ad61446ec07ce
This commit is contained in:
Jackmcbarn 2014-09-14 20:32:25 -04:00 committed by Tim Starling
parent 8823c8a70e
commit 9b0060c89a
3 changed files with 1 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
common/Hooks.php
View file

@ -255,19 +255,6 @@ class ScribuntoHooks {
return true;
}
$req = RequestContext::getMain()->getRequest();
$name = 'scribunto_ignore_errors';
$attribs = array(
'tabindex' => ++$tabindex,
'id' => "mw-$name",
);
$checkboxes['scribunto'] =
Xml::check( $name, $req->getCheck( $name ), $attribs ) .
' ' .
Xml::label( wfMessage( 'scribunto-ignore-errors' )->text(), "mw-$name" );
// While we're here, lets set up the edit module
global $wgOut;
$wgOut->addModules( 'ext.scribunto.edit' );
$editor->editFormTextAfterTools = '<div id="mw-scribunto-console"></div>';
@ -312,11 +299,6 @@ class ScribuntoHooks {
return true;
}
$req = RequestContext::getMain()->getRequest();
if ( $req->getBool( 'scribunto_ignore_errors' ) ) {
return true;
}
$engine = Scribunto::newDefaultEngine();
$engine->setTitle( $title );
$status = $engine->validate( $text, $title->getPrefixedDBkey() );

1
i18n/en.json
View file

@ -5,7 +5,6 @@
]
},
"scribunto-desc": "Framework for embedding scripting languages into MediaWiki pages",
"scribunto-ignore-errors": "Allow saving code with errors",
"scribunto-line": "at line $1",
"scribunto-module-line": "in $1 at line $2",
"scribunto-parser-dialog-title": "Script error",

2
i18n/qqq.json
View file

@ -58,7 +58,7 @@
"scribunto-luastandalone-gone": "Exception message.",
"scribunto-luastandalone-signal": "Exception message. Parameters:\n* $1 - (Unused)\n* $2 - an exit status (may also be a signal name)",
"scribunto-luastandalone-exited": "Exception message. Parameters:\n* $1 - (Unused)\n* $2 - an exit status",
"scribunto-module-with-errors-category": "Name of [[mw:Help:Tracking categories|tracking category]] where modules saved with errors are listed.\n\nSee also:\n* {{msg-mw|scribunto-ignore-errors}}\n* {{msg-mw|scribunto-module-with-errors-category-desc}}",
"scribunto-module-with-errors-category": "Name of [[mw:Help:Tracking categories|tracking category]] where modules saved with errors are listed.\n\nSee also:\n* {{msg-mw|scribunto-module-with-errors-category-desc}}",
"scribunto-module-with-errors-category-desc": "Description on [[Special:TrackingCategories]] for the {{msg-mw|scribunto-module-with-errors-category}} tracking category.",
"scribunto-limitreport-timeusage": "Label for the \"Lua time usage\" row in the limit report table.\n\nSee also:\n* {{msg-mw|Scribunto-limitreport-timeusage-value}}",
"scribunto-limitreport-timeusage-value": "Format for the \"Lua time usage\" value in the limit report table. Parameters:\n* $1 - the usage in seconds\n* $2 - the maximum\nSee also:\n* {{msg-mw|Scribunto-limitreport-timeusage}}\n{{Identical|Second}}",