wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-24 00:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Use inline ignore for MediaWiki.Usage.ForbiddenFunctions

Browse source 
This avoids addition of new code with the function,
or at least it gives extra attention on review when new code also uses
the inline ignore

Change-Id: I17981b52d9f96ee5f19ba46cf370c7477c81a72a
This commit is contained in:
Umherirrender 2024-09-23 17:45:44 +02:00 committed by jenkins-bot
parent 286add50b5
commit 7c1ea4284e
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.phpcs.xml
View file

@ -1,10 +1,6 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset name="Scribunto"> <ruleset name="Scribunto">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.popen" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.proc_open" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.shell_exec" />
</rule>
<file>.</file> <file>.</file>
<arg name="extensions" value="php" /> <arg name="extensions" value="php" />
<arg name="encoding" value="UTF-8" /> <arg name="encoding" value="UTF-8" />

2
includes/Engines/LuaStandalone/LuaStandaloneEngine.php
View file

@ -84,7 +84,7 @@ class LuaStandaloneEngine extends LuaEngine {
*/ */
protected function getClockTick() { protected function getClockTick() {
if ( self::$clockTick === null ) { if ( self::$clockTick === null ) {
// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged,MediaWiki.Usage.ForbiddenFunctions.shell_exec
self::$clockTick = intval( @shell_exec( 'getconf CLK_TCK' ) ); self::$clockTick = intval( @shell_exec( 'getconf CLK_TCK' ) );
if ( !self::$clockTick ) { if ( !self::$clockTick ) {
self::$clockTick = 100; self::$clockTick = 100;

2
includes/Engines/LuaStandalone/LuaStandaloneInterpreter.php
View file

@ -156,6 +156,7 @@ class LuaStandaloneInterpreter extends LuaInterpreter {
// warning was generated by that. // warning was generated by that.
error_clear_last(); error_clear_last();
// phpcs:ignore MediaWiki.Usage.ForbiddenFunctions.proc_open
$this->proc = proc_open( $this->proc = proc_open(
$cmd, $cmd,
[ [
@ -205,6 +206,7 @@ class LuaStandaloneInterpreter extends LuaInterpreter {
// Lua 5.1.5 Copyright (C) 1994-2012 Lua.org, PUC-Rio // Lua 5.1.5 Copyright (C) 1994-2012 Lua.org, PUC-Rio
// LuaJIT 2.0.0 -- Copyright (C) 2005-2012 Mike Pall. http://luajit.org/ // LuaJIT 2.0.0 -- Copyright (C) 2005-2012 Mike Pall. http://luajit.org/
$cmd = wfEscapeShellArg( $options['luaPath'] ) . ' -v 2>&1'; $cmd = wfEscapeShellArg( $options['luaPath'] ) . ' -v 2>&1';
// phpcs:ignore MediaWiki.Usage.ForbiddenFunctions.popen
$handle = popen( $cmd, 'r' ); $handle = popen( $cmd, 'r' );
if ( $handle ) { if ( $handle ) {
$ret = fgets( $handle, 80 ); $ret = fgets( $handle, 80 );