wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-24 00:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing & and (int) casts

Browse source 
Bug: T290189
Change-Id: I0bd0d06834f91fbc6a4067987e7e9e9e09b4e740
This commit is contained in:
Thiemo Kreuz 2021-09-08 09:31:55 +02:00 committed by D3r1ck01
parent 973cfccb9b
commit 51592c654f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/engines/LuaCommon/UstringLibrary.php
View file

@ -86,10 +86,10 @@ class Scribunto_LuaUstringLibrary extends Scribunto_LuaLibraryBase {
/**
* Check a string first parameter
* @param string $name Function name, for errors
* @param mixed $s Value to check
* @param mixed &$s Value to check
* @param bool $checkEncoding Whether to validate UTF-8 encoding.
*/
private function checkString( $name, $s, $checkEncoding = true ) {
private function checkString( $name, &$s, $checkEncoding = true ) {
if ( $this->getLuaType( $s ) == 'number' ) {
$s = (string)$s;
} else {
@ -314,8 +314,8 @@ class Scribunto_LuaUstringLibrary extends Scribunto_LuaLibraryBase {
if ( $j < $i ) {
return [ '' ];
}
$i = max( 1, min( $i, $len + 1 ) );
$j = max( 1, min( $j, $len + 1 ) );
$i = max( 1, min( (int)$i, $len + 1 ) );
$j = max( 1, min( (int)$j, $len + 1 ) );
$s = mb_substr( $s, $i - 1, $j - $i + 1, 'UTF-8' );
return [ $s ];
}