wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-09-23 10:22:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use PHP's more recent ?? operator where it makes sense

Browse source 
… as well as avoid an overly complicated printf call where a string
cast does the same.

Change-Id: I66b51572d0f2f9e72b9ef7c32f9a62ebb698d739
This commit is contained in:
thiemowmde 2024-04-26 13:21:14 +02:00 committed by jenkins-bot
parent fbbb56f1ef
commit 4c4392b4f3
3 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Engines/LuaStandalone/LuaStandaloneInterpreter.php
View file

@ -572,7 +572,7 @@ class LuaStandaloneInterpreter extends LuaInterpreter {
// Lua's number type can't represent most integers beyond 2**53, so stringify such keys
if ( is_int( $key ) && ( $key > 9007199254740992 || $key < -9007199254740992 ) ) {
$key = sprintf( '%d', $key );
$key = (string)$key;
}
$s .= '[' . $this->encodeLuaVar( $key, $level + 1 ) . ']' .

5
tests/phpunit/Engines/LuaCommon/LuaEngineTestBase.php
View file

@ -62,10 +62,7 @@ abstract class LuaEngineTestBase extends MediaWikiLangTestCase {
public function __construct(
$name = null, array $data = [], $dataName = '', $engineName = null
) {
if ( $engineName === null ) {
$engineName = self::$staticEngineName;
}
$this->engineName = $engineName;
$this->engineName = $engineName ?? self::$staticEngineName;
parent::__construct( $name, $data, $dataName );
}

5
tests/phpunit/Engines/LuaCommon/LuaEngineUnitTestBase.php
View file

@ -63,10 +63,7 @@ abstract class LuaEngineUnitTestBase extends TestCase {
public function __construct(
$name = null, array $data = [], $dataName = '', $engineName = null
) {
if ( $engineName === null ) {
$engineName = self::$staticEngineName;
}
$this->engineName = $engineName;
$this->engineName = $engineName ?? self::$staticEngineName;
parent::__construct( $name, $data, $dataName );
}