wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-28 02:00:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Kill hack for the PHPUnit migration

Browse source 
Bug: T192167
Change-Id: Ic86f6fc67555d2e678ce46f6ad34a25236b560af
This commit is contained in:
Daimona Eaytoy 2020-01-23 16:21:53 +00:00
parent 3a19bb8b0c
commit 2e1306fa45
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
tests/phpunit/engines/LuaCommon/LuaEngineTestHelper.php
View file

@ -72,7 +72,7 @@ trait Scribunto_LuaEngineTestHelper {
$engineSuite->setName( "$engineName: $className" ); $engineSuite->setName( "$engineName: $className" );
foreach ( $class->getMethods() as $method ) { foreach ( $class->getMethods() as $method ) {
if ( self::isTestMethod( $method ) && $method->isPublic() ) { if ( Test::isTestMethod( $method ) && $method->isPublic() ) {
$name = $method->getName(); $name = $method->getName();
$groups = Test::getGroups( $className, $name ); $groups = Test::getGroups( $className, $name );
$groups[] = 'Lua'; $groups[] = 'Lua';
@ -113,23 +113,6 @@ trait Scribunto_LuaEngineTestHelper {
return $suite; return $suite;
} }
/**
* Temporary helper for the duration of PHPUnit 8 migration
* @fixme Remove after migration is over
*
* @param ReflectionMethod $method
* @return bool
*/
private static function isTestMethod( ReflectionMethod $method ) : bool {
// PHPUnit 6
if ( method_exists( TestSuite::class, 'isTestMethod' ) ) {
return TestSuite::isTestMethod( $method );
}
// PHPUnit 8
return Test::isTestMethod( $method );
}
/** /**
* @return ScribuntoEngineBase * @return ScribuntoEngineBase
*/ */