wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-24 08:14:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Suppress wrong phan errors

Browse source 
\BagOStuff::makeKey() and \BagOStuff::makeGlobalKey() can take
any number of arguments but phan gives out PhanParamTooMany
and this breaks master avoiding anything to be merged

Change-Id: I4b313606e03565182552d9c581feccabaa408022
This commit is contained in:
Amir Sarabadani 2019-07-22 14:43:28 +02:00 committed by jenkins-bot
parent e5097e6145
commit 0cfb5422dc
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/common/ApiScribuntoConsole.php
View file

@ -23,6 +23,7 @@ class ApiScribuntoConsole extends ApiBase {
} }
$cache = ObjectCache::getInstance( CACHE_ANYTHING ); $cache = ObjectCache::getInstance( CACHE_ANYTHING );
// @phan-suppress-next-line PhanParamTooMany
$sessionKey = $cache->makeKey( 'scribunto-console', $this->getUser()->getId(), $sessionId ); $sessionKey = $cache->makeKey( 'scribunto-console', $this->getUser()->getId(), $sessionId );
$session = null; $session = null;
$sessionIsNew = false; $sessionIsNew = false;

1
includes/common/Hooks.php
View file

@ -210,6 +210,7 @@ class ScribuntoHooks {
} }
$cacheVersion = '1'; $cacheVersion = '1';
// @phan-suppress-next-line PhanParamTooMany
$key = $cache->makeGlobalKey( __METHOD__, $cacheVersion, $threshold ); $key = $cache->makeGlobalKey( __METHOD__, $cacheVersion, $threshold );
// This is a classic "read-update-write" critical section with no // This is a classic "read-update-write" critical section with no