wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-30 19:14:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Suppress phan false positives in LuaSandboxEngine::formatLimitData()

Browse source 
Most of this function deals with values for the single
scribunto-limitreport-profile key, where $value is an array of
strings.  Phan's security check plugin was getting confused because
*in general* the $value passed to a ParserLimitReportFormat hook can
be almost anything.

Change-Id: I0ef5ef71f00a92bd5db0df340725c88595fcb0c6
This commit is contained in:
C. Scott Ananian 2020-10-23 11:46:02 -04:00 committed by jenkins-bot
parent 664c866980
commit 0cd8904842
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/engines/LuaSandbox/LuaSandboxEngine.php
View file

@ -127,7 +127,10 @@ class Scribunto_LuaSandboxEngine extends Scribunto_LuaEngine {
}
}
/** @inheritDoc */
/**
* @inheritDoc
* @suppress SecurityCheck-DoubleEscaped phan false positive
*/
public function formatLimitData( $key, &$value, &$report, $isHTML, $localize ) {
global $wgLang;
$lang = $localize ? $wgLang : Language::factory( 'en' );
@ -146,6 +149,7 @@ class Scribunto_LuaSandboxEngine extends Scribunto_LuaEngine {
if ( $key !== 'scribunto-limitreport-profile' ) {
return true;
}
'@phan-var string[] $value';
$keyMsg = wfMessage( 'scribunto-limitreport-profile' );
$msMsg = wfMessage( 'scribunto-limitreport-profile-ms' );