wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-11-27 17:50:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Updating mediawiki/mediawiki-codesniffer to 33.0.0

Browse source 
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic
* MediaWiki.Commenting.PropertyDocumentation.WrongStyle

Additional changes:
* Added the `wikimedia/mediawiki` profile in .eslintrc.json (T262222).
* Added the `wikimedia/jquery` profile in .eslintrc.json (T262222).
* Removed global `$`, included in the `wikimedia/jquery` profile (T262222).
* Removed global `mw`, included via `wikimedia/mediawiki` profile (T262222).
* Dropped the emtpy global definition in .eslintrc.json.

Change-Id: Ib0acbf92bcb8327ecd065db5db1083d7b222976c
This commit is contained in:
libraryupgrader 2020-11-04 09:55:45 +00:00 committed by Umherirrender
parent a133d61b97
commit 00fc2c3f1e
4 changed files with 20 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
.eslintrc.json
View file

@ -1,11 +1,18 @@
{
"root": true,
"extends": "wikimedia",
"extends": [
"wikimedia",
"wikimedia/mediawiki",
"wikimedia/jquery"
],
"env": {
"browser": true
},
"globals": {
"mw": false,
"$": false
"rules": {
"no-jquery/no-global-selector": "warn",
"no-jquery/no-parse-html-literal": "warn",
"no-jquery/no-global-selector": "warn",
"mediawiki/class-doc": "warn",
"mediawiki/msg-doc": "warn"
}
}

5
.phpcs.xml
View file

@ -1,6 +1,11 @@
<?xml version="1.0"?>
<ruleset name="Scribunto">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.WrongStyle" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.popen" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.proc_open" />

2
composer.json
View file

@ -1,7 +1,7 @@
{
"require-dev": {
"mediawiki/lua-sandbox": "3.0.1",
"mediawiki/mediawiki-codesniffer": "31.0.0",
"mediawiki/mediawiki-codesniffer": "33.0.0",
"mediawiki/mediawiki-phan-config": "0.10.3",
"mediawiki/minus-x": "1.1.0",
"php-parallel-lint/php-console-highlighter": "0.5.0",

6
includes/engines/LuaCommon/UstringLibrary.php
View file

@ -5,21 +5,21 @@ use UtfNormal\Validator;
class Scribunto_LuaUstringLibrary extends Scribunto_LuaLibraryBase {
/**
* Limit on pattern lengths, in bytes not characters
* @var integer
* @var int
*/
private $patternLengthLimit = 10000;
/**
* Limit on string lengths, in bytes not characters
* If null, $wgMaxArticleSize * 1024 will be used
* @var integer|null
* @var int|null
*/
private $stringLengthLimit = null;
/**
* PHP until 5.6.9 are buggy when the regex in preg_replace an
* preg_match_all matches the empty string.
* @var boolean
* @var bool
*/
private $phpBug53823 = false;