2012-01-28 16:22:18 +00:00
|
|
|
<?php
|
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
class Scribunto_LuaSandboxEngine extends Scribunto_LuaEngine {
|
|
|
|
public $options, $loaded = false;
|
2012-09-05 09:39:58 +00:00
|
|
|
protected $lineCache = array();
|
2012-02-06 22:14:47 +00:00
|
|
|
|
2012-04-05 07:58:02 +00:00
|
|
|
public function getLimitReport() {
|
2012-01-28 16:22:18 +00:00
|
|
|
$this->load();
|
2012-04-13 10:38:12 +00:00
|
|
|
$lang = Language::factory( 'en' );
|
2012-09-05 09:39:58 +00:00
|
|
|
|
|
|
|
$t = $this->interpreter->getCPUUsage();
|
|
|
|
$s = 'Lua time usage: ' . sprintf( "%.3f", $t ) . "s\n" .
|
2012-04-30 06:36:21 +00:00
|
|
|
'Lua memory usage: ' . $lang->formatSize( $this->interpreter->getPeakMemoryUsage() ) . "\n";
|
2012-09-05 09:39:58 +00:00
|
|
|
if ( $t < 1.0 ) {
|
|
|
|
return $s;
|
|
|
|
}
|
|
|
|
$percentProfile = $this->interpreter->getProfilerFunctionReport( LuaSandbox::PERCENT );
|
|
|
|
if ( !count( $percentProfile ) ) {
|
|
|
|
return $s;
|
|
|
|
}
|
|
|
|
$timeProfile = $this->interpreter->getProfilerFunctionReport( LuaSandbox::SECONDS );
|
|
|
|
|
|
|
|
$s .= "Lua Profile:\n";
|
|
|
|
$cumulativePercent = $cumulativeTime = 0;
|
|
|
|
$num = $otherTime = $otherPercent = 0;
|
|
|
|
$format = " %-59s %8.0f ms %8.1f%%\n";
|
|
|
|
foreach ( $percentProfile as $name => $percent ) {
|
|
|
|
$time = $timeProfile[$name] * 1000;
|
|
|
|
$cumulativePercent += $percent;
|
|
|
|
$cumulativeTime += $time;
|
|
|
|
$num++;
|
|
|
|
if ( $cumulativePercent <= 99 && $num <= 10 ) {
|
|
|
|
// Map some regularly appearing internal names
|
|
|
|
if ( preg_match( '/^<mw.lua:(\d+)>$/', $name, $m ) ) {
|
|
|
|
$line = $this->getMwLuaLine( $m[1] );
|
|
|
|
if ( preg_match( '/^\s*(local\s+)?function ([a-zA-Z0-9_.]*)/', $line, $m ) ) {
|
|
|
|
$name = $m[2] . ' ' . $name;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$s .= sprintf( $format, $name, $time, $percent );
|
|
|
|
} else {
|
|
|
|
$otherTime += $time;
|
|
|
|
$otherPercent += $percent;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ( $otherTime ) {
|
|
|
|
$s .= sprintf( $format, "[others]", $otherTime, $otherPercent );
|
|
|
|
}
|
|
|
|
return $s;
|
|
|
|
}
|
|
|
|
|
|
|
|
protected function getMwLuaLine( $lineNum ) {
|
|
|
|
if ( !isset( $this->lineCache['mw.lua'] ) ) {
|
|
|
|
$this->lineCache['mw.lua'] = file( $this->getLuaLibDir() . '/mw.lua' );
|
|
|
|
}
|
|
|
|
return $this->lineCache['mw.lua'][$lineNum - 1];
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
2012-04-04 05:10:47 +00:00
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
function newInterpreter() {
|
|
|
|
return new Scribunto_LuaSandboxInterpreter( $this, $this->options );
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
class Scribunto_LuaSandboxInterpreter extends Scribunto_LuaInterpreter {
|
2012-09-05 09:39:58 +00:00
|
|
|
var $engine, $sandbox, $libraries, $profilerEnabled;
|
2012-01-28 16:22:18 +00:00
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
function __construct( $engine, $options ) {
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
if ( !extension_loaded( 'luasandbox' ) ) {
|
2012-04-19 07:40:56 +00:00
|
|
|
throw new Scribunto_LuaInterpreterNotFoundError(
|
|
|
|
'The luasandbox extension is not present, this engine cannot be used.' );
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
}
|
2012-04-13 10:38:12 +00:00
|
|
|
$this->engine = $engine;
|
|
|
|
$this->sandbox = new LuaSandbox;
|
|
|
|
$this->sandbox->setMemoryLimit( $options['memoryLimit'] );
|
|
|
|
$this->sandbox->setCPULimit( $options['cpuLimit'] );
|
2012-09-05 09:39:58 +00:00
|
|
|
if ( is_callable( array( $this->sandbox, 'enableProfiler' ) ) ) {
|
|
|
|
$this->profilerEnabled = true;
|
|
|
|
$this->sandbox->enableProfiler( 0.002 );
|
|
|
|
}
|
2012-04-13 10:38:12 +00:00
|
|
|
}
|
2012-01-28 16:46:15 +00:00
|
|
|
|
2012-04-24 10:40:40 +00:00
|
|
|
protected function convertSandboxError( $e ) {
|
|
|
|
$opts = array();
|
|
|
|
if ( isset( $e->luaTrace ) ) {
|
|
|
|
$opts['trace'] = $e->luaTrace;
|
|
|
|
}
|
|
|
|
$message = $e->getMessage();
|
|
|
|
if ( preg_match( '/^(.*?):(\d+): (.*)$/', $message, $m ) ) {
|
|
|
|
$opts['module'] = $m[1];
|
|
|
|
$opts['line'] = $m[2];
|
|
|
|
$message = $m[3];
|
2012-09-05 09:39:58 +00:00
|
|
|
}
|
2012-04-24 10:40:40 +00:00
|
|
|
return $this->engine->newLuaError( $message, $opts );
|
|
|
|
}
|
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
public function loadString( $text, $chunkName ) {
|
2012-01-28 16:22:18 +00:00
|
|
|
try {
|
2012-04-13 10:38:12 +00:00
|
|
|
return $this->sandbox->loadString( $text, $chunkName );
|
|
|
|
} catch ( LuaSandboxError $e ) {
|
2012-04-24 10:40:40 +00:00
|
|
|
throw $this->convertSandboxError( $e );
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
2012-04-13 10:38:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public function registerLibrary( $name, $functions ) {
|
|
|
|
$realLibrary = array();
|
|
|
|
foreach ( $functions as $funcName => $callback ) {
|
|
|
|
$realLibrary[$funcName] = array(
|
|
|
|
new Scribunto_LuaSandboxCallback( $callback ),
|
2012-09-05 09:39:58 +00:00
|
|
|
$funcName );
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
2012-04-13 10:38:12 +00:00
|
|
|
$this->sandbox->registerLibrary( $name, $realLibrary );
|
2012-01-28 16:22:18 +00:00
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
# TODO: replace this with
|
|
|
|
#$this->sandbox->registerVirtualLibrary(
|
|
|
|
# $name, array( $this, 'callback' ), $functions );
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
public function callFunction( $func /*, ... */ ) {
|
|
|
|
$args = func_get_args();
|
|
|
|
$func = array_shift( $args );
|
|
|
|
try {
|
|
|
|
return call_user_func_array( array( $func, 'call' ), $args );
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
} catch ( LuaSandboxTimeoutError $e ) {
|
2012-04-23 11:36:13 +00:00
|
|
|
throw $this->engine->newException( 'scribunto-common-timeout' );
|
2012-04-13 10:38:12 +00:00
|
|
|
} catch ( LuaSandboxError $e ) {
|
2012-04-24 10:40:40 +00:00
|
|
|
throw $this->convertSandboxError( $e );
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-04-30 06:36:21 +00:00
|
|
|
public function getPeakMemoryUsage() {
|
|
|
|
return $this->sandbox->getPeakMemoryUsage();
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
2012-04-27 05:36:48 +00:00
|
|
|
|
|
|
|
public function getCPUUsage() {
|
|
|
|
return $this->sandbox->getCPUUsage();
|
|
|
|
}
|
2012-09-05 09:39:58 +00:00
|
|
|
|
|
|
|
public function getProfilerFunctionReport( $units ) {
|
|
|
|
if ( $this->profilerEnabled ) {
|
|
|
|
return $this->sandbox->getProfilerFunctionReport( $units );
|
|
|
|
} else {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
}
|
2012-04-13 10:38:12 +00:00
|
|
|
}
|
2012-04-05 07:58:02 +00:00
|
|
|
|
2012-04-13 10:38:12 +00:00
|
|
|
class Scribunto_LuaSandboxCallback {
|
|
|
|
function __construct( $callback ) {
|
|
|
|
$this->callback = $callback;
|
2012-04-05 07:58:02 +00:00
|
|
|
}
|
2012-01-28 16:22:18 +00:00
|
|
|
|
2012-09-05 09:39:58 +00:00
|
|
|
/**
|
|
|
|
* We use __call with a variable function name so that LuaSandbox will be
|
|
|
|
* able to return a meaningful function name in profiling data.
|
|
|
|
*/
|
|
|
|
function __call( $funcName, $args ) {
|
2012-01-28 16:22:18 +00:00
|
|
|
try {
|
2012-04-13 10:38:12 +00:00
|
|
|
return call_user_func_array( $this->callback, $args );
|
|
|
|
} catch ( Scribunto_LuaError $e ) {
|
|
|
|
throw new LuaSandboxRuntimeError( $e->getLuaMessage() );
|
2012-04-04 06:10:32 +00:00
|
|
|
}
|
2012-01-28 16:22:18 +00:00
|
|
|
}
|
|
|
|
}
|