wikimedia/mediawiki-extensions-Scribunto
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto synced 2024-12-11 16:06:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Scribunto/tests/phpunit/engines/LuaSandbox/SandboxTests.lua

19 lines
454 B
Lua
Raw Normal View History

Refactor unit tests The existing unit tests work, but the setup is really not amenable to the addition of additional tests in a modular fashion. This splits things out so there is a framework for tests in Lua, and all a module has to do on the Lua side is supply a list of functions to call and results to expect. And then on the php side, only one array entry and two short functions need to be added to LuaSandboxEngineTest to run the tests. Change-Id: Ib241b246aa0c7223c33887b38a5858582d7d31b0
2012-12-19 20:10:01 +00:00
local testframework = require( 'Module:TestFramework' )
More tests and some related bug fixes * Added tests for the engine classes. * Added some tests that run under Lua. * In the chunk names, fixed truncation of module names at 60 bytes by using an "=" prefix instead of @. * Fixed a bug in mw.clone() which was causing the metatable to be set on the source table instead of the destination. * Put restricted setfenv/getfenv in the cloned environment rather than the base environment, they work better that way. * In setfenv(), check for getfenv() == nil, since that's what our own restricted getfenv returns. * Fixed getfenv() handling of numeric arguments: add one where appropriate. Change-Id: I2b356fd65a3fcb348c4e99a3a4267408fb995739
2012-04-19 07:40:56 +00:00
Refactor unit tests The existing unit tests work, but the setup is really not amenable to the addition of additional tests in a modular fashion. This splits things out so there is a framework for tests in Lua, and all a module has to do on the Lua side is supply a list of functions to call and results to expect. And then on the php side, only one array entry and two short functions need to be added to LuaSandboxEngineTest to run the tests. Change-Id: Ib241b246aa0c7223c33887b38a5858582d7d31b0
2012-12-19 20:10:01 +00:00
local function setfenv1()
Fix tests Iaa880531 added extra frames in the call stack, so the frame being tested by the "setfenv invalid level" and "getfenv invalid level" tests was no longer invalid. Bug: T175065 Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
2017-09-05 19:37:39 +00:00
setfenv( 10, {} )
More tests and some related bug fixes * Added tests for the engine classes. * Added some tests that run under Lua. * In the chunk names, fixed truncation of module names at 60 bytes by using an "=" prefix instead of @. * Fixed a bug in mw.clone() which was causing the metatable to be set on the source table instead of the destination. * Put restricted setfenv/getfenv in the cloned environment rather than the base environment, they work better that way. * In setfenv(), check for getfenv() == nil, since that's what our own restricted getfenv returns. * Fixed getfenv() handling of numeric arguments: add one where appropriate. Change-Id: I2b356fd65a3fcb348c4e99a3a4267408fb995739
2012-04-19 07:40:56 +00:00
end
Refactor unit tests The existing unit tests work, but the setup is really not amenable to the addition of additional tests in a modular fashion. This splits things out so there is a framework for tests in Lua, and all a module has to do on the Lua side is supply a list of functions to call and results to expect. And then on the php side, only one array entry and two short functions need to be added to LuaSandboxEngineTest to run the tests. Change-Id: Ib241b246aa0c7223c33887b38a5858582d7d31b0
2012-12-19 20:10:01 +00:00
local function getfenv1()
Fix tests Iaa880531 added extra frames in the call stack, so the frame being tested by the "setfenv invalid level" and "getfenv invalid level" tests was no longer invalid. Bug: T175065 Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
2017-09-05 19:37:39 +00:00
assert( getfenv( 10 ) == nil )
More tests and some related bug fixes * Added tests for the engine classes. * Added some tests that run under Lua. * In the chunk names, fixed truncation of module names at 60 bytes by using an "=" prefix instead of @. * Fixed a bug in mw.clone() which was causing the metatable to be set on the source table instead of the destination. * Put restricted setfenv/getfenv in the cloned environment rather than the base environment, they work better that way. * In setfenv(), check for getfenv() == nil, since that's what our own restricted getfenv returns. * Fixed getfenv() handling of numeric arguments: add one where appropriate. Change-Id: I2b356fd65a3fcb348c4e99a3a4267408fb995739
2012-04-19 07:40:56 +00:00
end
Refactor unit tests The existing unit tests work, but the setup is really not amenable to the addition of additional tests in a modular fashion. This splits things out so there is a framework for tests in Lua, and all a module has to do on the Lua side is supply a list of functions to call and results to expect. And then on the php side, only one array entry and two short functions need to be added to LuaSandboxEngineTest to run the tests. Change-Id: Ib241b246aa0c7223c33887b38a5858582d7d31b0
2012-12-19 20:10:01 +00:00
return testframework.getTestProvider( {
{ name = 'setfenv invalid level', func = setfenv1,
expect = "bad argument #1 to 'old_getfenv' (invalid level)",
},
{ name = 'getfenv invalid level', func = getfenv1,
expect = "bad argument #1 to 'old_getfenv' (invalid level)",
},
} )
Reference in a new issue Copy permalink