Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
<?php
|
|
|
|
|
2013-02-05 04:26:19 +00:00
|
|
|
if ( PHP_SAPI !== 'cli' ) exit;
|
2012-04-19 07:40:56 +00:00
|
|
|
require_once( dirname( __FILE__ ) .'/../LuaCommon/LuaInterpreterTest.php' );
|
|
|
|
|
2013-11-01 15:53:56 +00:00
|
|
|
/**
|
|
|
|
* @group Lua
|
|
|
|
* @group LuaStandalone
|
|
|
|
*/
|
2012-04-19 07:40:56 +00:00
|
|
|
class Scribunto_LuaStandaloneInterpreterTest extends Scribunto_LuaInterpreterTest {
|
2014-08-17 21:11:26 +00:00
|
|
|
public $stdOpts = array(
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
'errorFile' => null,
|
|
|
|
'luaPath' => null,
|
|
|
|
'memoryLimit' => 50000000,
|
|
|
|
'cpuLimit' => 30,
|
|
|
|
);
|
|
|
|
|
2014-11-12 11:43:44 +00:00
|
|
|
private function getVsize( $pid ) {
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
$size = wfShellExec( wfEscapeShellArg( 'ps', '-p', $pid, '-o', 'vsz', '--no-headers' ) );
|
|
|
|
return $size * 1024;
|
|
|
|
}
|
|
|
|
|
2014-11-12 11:43:44 +00:00
|
|
|
protected function newInterpreter( $opts = array() ) {
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
$opts = $opts + $this->stdOpts;
|
|
|
|
$engine = new Scribunto_LuaStandaloneEngine( $this->stdOpts );
|
|
|
|
return new Scribunto_LuaStandaloneInterpreter( $engine, $opts );
|
|
|
|
}
|
|
|
|
|
2014-11-12 11:43:44 +00:00
|
|
|
public function testGetStatus() {
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
$startTime = microtime( true );
|
|
|
|
if ( php_uname( 's' ) !== 'Linux' ) {
|
|
|
|
$this->markTestSkipped( "getStatus() not supported on platforms other than Linux" );
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
$interpreter = $this->newInterpreter();
|
|
|
|
$status = $interpreter->getStatus();
|
|
|
|
$pid = $status['pid'];
|
|
|
|
$this->assertInternalType( 'integer', $status['pid'] );
|
|
|
|
$initialVsize = $this->getVsize( $pid );
|
|
|
|
$this->assertGreaterThan( 0, $initialVsize, 'Initial vsize' );
|
|
|
|
|
|
|
|
$chunk = $this->getBusyLoop( $interpreter );
|
|
|
|
|
|
|
|
while ( microtime( true ) - $startTime < 1 ) {
|
|
|
|
$interpreter->callFunction( $chunk, 100 );
|
|
|
|
}
|
|
|
|
$status = $interpreter->getStatus();
|
|
|
|
$vsize = $this->getVsize( $pid );
|
|
|
|
$time = $status['time'] / $interpreter->engine->getClockTick();
|
|
|
|
$this->assertGreaterThan( 0.1, $time, 'getStatus() time usage' );
|
|
|
|
$this->assertLessThan( 1.5, $time, 'getStatus() time usage' );
|
|
|
|
$this->assertEquals( $vsize, $status['vsize'], 'vsize', $vsize * 0.1 );
|
|
|
|
}
|
2013-11-01 00:04:12 +00:00
|
|
|
|
2014-11-12 11:43:44 +00:00
|
|
|
public function testFreeFunctions() {
|
2013-11-01 00:04:12 +00:00
|
|
|
$interpreter = $this->newInterpreter();
|
|
|
|
|
|
|
|
// Test #1: Make sure freeing actually works
|
|
|
|
$ret = $interpreter->callFunction(
|
|
|
|
$interpreter->loadString( 'return function() return "testFreeFunction #1" end', 'test' )
|
|
|
|
);
|
|
|
|
$id = $ret[0]->id;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$this->assertEquals(
|
|
|
|
array( 'testFreeFunction #1' ), $interpreter->callFunction( $ret[0] ),
|
|
|
|
'Test that function #1 was not freed while a reference exists'
|
|
|
|
);
|
|
|
|
$ret = null;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$testfunc = new Scribunto_LuaStandaloneInterpreterFunction( $interpreter->id, $id );
|
|
|
|
try {
|
|
|
|
$interpreter->callFunction( $testfunc );
|
|
|
|
$this->fail( "Expected exception because function #1 should have been freed" );
|
|
|
|
} catch ( Scribunto_LuaError $e ) {
|
|
|
|
$this->assertEquals(
|
|
|
|
"Lua error: function id $id does not exist.", $e->getMessage(),
|
|
|
|
'Testing for expected error when calling a freed function #1'
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test #2: Make sure constructing a new copy of the function works
|
|
|
|
$ret = $interpreter->callFunction(
|
|
|
|
$interpreter->loadString( 'return function() return "testFreeFunction #2" end', 'test' )
|
|
|
|
);
|
|
|
|
$id = $ret[0]->id;
|
|
|
|
$func = new Scribunto_LuaStandaloneInterpreterFunction( $interpreter->id, $id );
|
|
|
|
$ret = null;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$this->assertEquals(
|
|
|
|
array( 'testFreeFunction #2' ), $interpreter->callFunction( $func ),
|
|
|
|
'Test that function #2 was not freed while a reference exists'
|
|
|
|
);
|
|
|
|
$func = null;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$testfunc = new Scribunto_LuaStandaloneInterpreterFunction( $interpreter->id, $id );
|
|
|
|
try {
|
|
|
|
$interpreter->callFunction( $testfunc );
|
|
|
|
$this->fail( "Expected exception because function #2 should have been freed" );
|
|
|
|
} catch ( Scribunto_LuaError $e ) {
|
|
|
|
$this->assertEquals(
|
|
|
|
"Lua error: function id $id does not exist.", $e->getMessage(),
|
|
|
|
'Testing for expected error when calling a freed function #2'
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test #3: Make sure cloning works
|
|
|
|
$ret = $interpreter->callFunction(
|
|
|
|
$interpreter->loadString( 'return function() return "testFreeFunction #3" end', 'test' )
|
|
|
|
);
|
|
|
|
$id = $ret[0]->id;
|
|
|
|
$func = clone $ret[0];
|
|
|
|
$ret = null;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$this->assertEquals(
|
|
|
|
array( 'testFreeFunction #3' ), $interpreter->callFunction( $func ),
|
|
|
|
'Test that function #3 was not freed while a reference exists'
|
|
|
|
);
|
|
|
|
$func = null;
|
|
|
|
$interpreter->cleanupLuaChunks();
|
|
|
|
$testfunc = new Scribunto_LuaStandaloneInterpreterFunction( $interpreter->id, $id );
|
|
|
|
try {
|
|
|
|
$interpreter->callFunction( $testfunc );
|
|
|
|
$this->fail( "Expected exception because function #3 should have been freed" );
|
|
|
|
} catch ( Scribunto_LuaError $e ) {
|
|
|
|
$this->assertEquals(
|
|
|
|
"Lua error: function id $id does not exist.", $e->getMessage(),
|
|
|
|
'Testing for expected error when calling a freed function #3'
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
Added tests and fixed bugs
* Added unit tests for the two Lua interpreter classes
* Fixed a bug in checkType()
* Have Scribunto_LuaSandboxInterpreter throw an exception on construct
when the extension doesn't exist, to match the standalone behaviour.
* In Scribunto_LuaSandboxInterpreter, removed debugging statements
accidentally left in.
* Convert LuaSandboxTimeoutError to the appropriate common error
message.
* Moved the option munging from the sandbox engine to the interpreter,
so that the interpreter can be unit tested separately.
* Use /bin/sh instead of bash for lua_ulimit.sh, since dash is smaller
and still supports ulimit.
* Use exec to run the lua binary, so that the vsize of the shell doesn't
add to the memory limit.
* Added a quit function to the standalone interpreter. Unused at present.
* Don't add a comma after the last element of a table in a Lua
expression.
* Make the SIGXCPU detection work: proc_open() runs the command via a
shell, which reports signals in the child via the exit status, so
proc_get_status() will never return a valid termsig element.
* In MWServer:call(), fixed a bug causing the return values to be
wrapped in an array.
* Fixed a misunderstanding of what select() does.
* In MWServer:getStatus(), fixed indexes so that vsize will be correct.
Removed RSS, since it wasn't used anyway and turns out to be measured
in multiples of the page size, and I couldn't be bothered trying to
fetch that from getconf. Return the PID and vsize as numbers rather
than strings.
* Added a simple table dump feature to MWServer:debug().
* Fixed brackets in MWServer:tostring().
* Added missing Linux 32-bit binary.
Change-Id: Ibf5f4656b1c0a9f81287d363184c3fe9d2abdafd
2012-04-16 04:41:08 +00:00
|
|
|
}
|