Go to file
thiemowmde f0742e7ba3 Use existing data-pos attribute instead of pixel calculations
This click handler is assigned to many different elements. Not all
of them can be used as a source for a data-pos="…" attribute. But a
lot can.

Again, this patch alone will not actually fix T352169. But it will
improve the situation a lot, according to my local tests. Many of
the clicks will start to work fine on RTL wikis because the
problematic pixel-based getRevisionPositionFromLeftOffset
calculations are not used any more.

Steps to reproduce: Go to a RTL page with a very long history, e.g.
https://he.wikipedia.org/wiki/Special:Diff/38031767?uselang=he
Click on one of the gray bars in the right half of the slider. This
will not work, i.e. the slider will not move to this position but
to a totally different one. This is the bug described in T352169.

I noticed that a browser zoom other than 100% can cause many more
problems that are unrelated to this patch. Please test with 100%.

Bug: T352169
Change-Id: Ife49557c891736bc94df6087658f76326791f61b
2024-02-09 16:27:05 +00:00
.phan Upgrade RevisionSlider to use newer phan 2019-03-03 12:06:21 +05:30
i18n Localisation updates from https://translatewiki.net. 2024-02-07 08:27:31 +01:00
modules Use existing data-pos attribute instead of pixel calculations 2024-02-09 16:27:05 +00:00
resources/ext.RevisionSlider.helpDialog build: Update 'svgo' to latest v3.2.0 and re-minify SVGs 2024-01-16 00:17:03 +01:00
src Merge "Various tiny clean-ups" 2024-01-12 09:48:13 +00:00
tests Fix rounding error in revisionsPerWindow calculation 2024-02-09 12:19:31 +01:00
.eslintrc.json build: Update devDependencies 2022-03-17 22:55:02 +00:00
.gitignore Add /tests/selenium/log to .gitignore file 2020-10-16 10:25:44 +03:00
.gitreview Whoops, track not trace 2016-10-24 17:03:28 -07:00
.phpcs.xml build: Remove unneeded Squiz.WhiteSpace.FunctionSpacing 2019-10-25 20:33:03 +02:00
.stylelintrc.json stylelint: Enable selector-pseudo-element-colon-notation 2023-03-30 00:42:20 +02:00
.svgo.config.js build: Update SVGO to v3.0.2 2023-06-14 12:38:31 -07:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 2018-08-19 15:55:48 +00:00
composer.json build: Updating dependencies 2023-04-29 09:51:30 +00:00
COPYING Add license file 2019-10-23 08:44:22 +02:00
extension.json Use MediaWiki\ResourceLoader\ImageModule instead of ResourceLoaderImageModule 2023-12-01 13:27:37 +00:00
Gruntfile.js build: Update devDependencies 2022-03-17 22:55:02 +00:00
jsduck.json Add a simple JSDuck config file 2016-06-22 14:40:27 +02:00
package-lock.json build: Update 'svgo' to latest v3.2.0 and re-minify SVGs 2024-01-16 00:17:03 +01:00
package.json build: Update 'svgo' to latest v3.2.0 and re-minify SVGs 2024-01-16 00:17:03 +01:00
README.md Add hint for browser tests to README.md 2020-11-12 11:58:40 +01:00

RevisionSlider extension

This MediaWiki extension shows a slider allowing selecting and comparing of revisions on a diff page

Installation

Check out this extension into the extensions folder of your MediaWiki installation and add the following line to your LocalSettings.php:

wfLoadExtension( 'RevisionSlider' );

Tests

Before executing tests run the following in the root directory of the extension once:

composer install
npm install

For the tests run:

composer test
node_modules/.bin/grunt test

QUnit Tests

See https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Run_the_tests

Browser Tests

See tests/selenium/README.md