mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider
synced 2024-11-23 23:13:29 +00:00
f0742e7ba3
This click handler is assigned to many different elements. Not all of them can be used as a source for a data-pos="…" attribute. But a lot can. Again, this patch alone will not actually fix T352169. But it will improve the situation a lot, according to my local tests. Many of the clicks will start to work fine on RTL wikis because the problematic pixel-based getRevisionPositionFromLeftOffset calculations are not used any more. Steps to reproduce: Go to a RTL page with a very long history, e.g. https://he.wikipedia.org/wiki/Special:Diff/38031767?uselang=he Click on one of the gray bars in the right half of the slider. This will not work, i.e. the slider will not move to this position but to a totally different one. This is the bug described in T352169. I noticed that a browser zoom other than 100% can cause many more problems that are unrelated to this patch. Please test with 100%. Bug: T352169 Change-Id: Ife49557c891736bc94df6087658f76326791f61b |
||
---|---|---|
.phan | ||
i18n | ||
modules | ||
resources/ext.RevisionSlider.helpDialog | ||
src | ||
tests | ||
.eslintrc.json | ||
.gitignore | ||
.gitreview | ||
.phpcs.xml | ||
.stylelintrc.json | ||
.svgo.config.js | ||
CODE_OF_CONDUCT.md | ||
composer.json | ||
COPYING | ||
extension.json | ||
Gruntfile.js | ||
jsduck.json | ||
package-lock.json | ||
package.json | ||
README.md |
RevisionSlider extension
This MediaWiki extension shows a slider allowing selecting and comparing of revisions on a diff page
Installation
Check out this extension into the extensions
folder of your MediaWiki installation and add the following line to your LocalSettings.php
:
wfLoadExtension( 'RevisionSlider' );
Tests
Before executing tests run the following in the root directory of the extension once:
composer install
npm install
For the tests run:
composer test
node_modules/.bin/grunt test
QUnit Tests
See https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Run_the_tests
Browser Tests
See tests/selenium/README.md