mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider
synced 2024-11-14 19:24:42 +00:00
346846f16c
This is closely related to Ied0b974 which fixed a similar, if not the same rounding issue. Note the following might be different depending on e.g. the operating system. My Ubuntu+Chromium shows the following behavior: * The RTL scroll type is correctly detected as "negative" with all zoom factors below and up to 100%. * When the zoom factor is 110%, 125%, or 150% the scrollLeft value is not 0 but something like 0.909090876 or 0.200000002. * It's 0 again at 175% and 200%. * Bad at 250%. Good at 300%. Bad at 400%. And so on. No rhyme or reason. The current Firefox version also ends in the "negative" branch, but doesn't have the same rounding errors. It's always a perfect 0 in Firefox. This makes it look like a bug in Chrome's engine. We don't know how old it is, but based on the information in T352169 it might be a relatively new bug that didn't exist when this code was originally written in 2016 (see I7c903c2). For reference, this is what's supposed to happen here: Browsers with the scroll type "negative" (which are apparently all current Chrome and Firefox versions) won't allow scrollLeft to be a positive number on an RTL page. When you scroll to the left in such browsers the numbers get negative. The detection code tries to set the number to +1 anyway. We expect the browser to ignore this invalid call and still report the previous 0. This mostly works in Chrome as well. For example, setting scrollLeft to +100 wont set it to +100 but to … some random number between >=0 and <1, depending on the current zoom factor? o_O? I suspect we can remove this detection code entirely, or at least change the default to "negative". But this needs more testing with more browsers. Let's start with this tiny fix. Bug: T352169 Change-Id: I22cbb8881578e96165097d4fcc812baadc22d7fa |
||
|---|---|---|
| .phan | ||
| i18n | ||
| modules | ||
| resources/ext.RevisionSlider.helpDialog | ||
| src | ||
| tests | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| .svgo.config.js | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| extension.json | ||
| Gruntfile.js | ||
| jsduck.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
RevisionSlider extension
This MediaWiki extension shows a slider allowing selecting and comparing of revisions on a diff page
Installation
Check out this extension into the extensions folder of your MediaWiki installation and add the following line to your LocalSettings.php:
wfLoadExtension( 'RevisionSlider' );
Tests
Before executing tests run the following in the root directory of the extension once:
composer install
npm install
For the tests run:
composer test
node_modules/.bin/grunt test
QUnit Tests
See https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Run_the_tests
Browser Tests
See tests/selenium/README.md