wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-15 11:40:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/extensions/RevisionSlider
134 commits 274 branches 0 tags 22 MiB
JavaScript 89.2%
Less 6%
PHP 4.8%
Go to file
Leszek Manicki 0251b952cb Improve SliderView rendering tests 
Current rendering test passes but not really because test results meet
expectations but rather by accident.
Test revisions lacked ids, and current way of rendering revision made
all revision bars have id equal to "undefined" string. That made test
pass, although it is not what is expected (we expect three revisions
in tests but not that three revisions have the same id, and each of them
gets a pointer assigned to - the might look interesting in the browser,
though). Also the test will fail as soon as the way of rendering
revisions is switched to standard use of jquery's attr() instead of
handcrafting the HTML in the RevisionListView class.

This patch adds missing IDs to test Revisions where needed, and also
set config vars that are required to render Slider properly.
This also adds tests for cases where the exception is thrown.

This also makes RevisionList initialization consistent. RevisionList
expect to receive an array of revision data in a format that API
returns. Tests provided arrays of Revision objects instead. That
also works with a difference that API-like format uses "revid" as a field
containing revision ID, while Revision objects use a field named "id".
The way RevisionList was used in tests actually lead to have each
revision initialized twice, and on the second initialization it lost
its ID (due to field name difference). This changes test to provide
a API-like array instead of arrays of Revision objects to RevisionList.

Change-Id: I147270f28381038d05f8bcfd2317e8c269b2e458
2016-05-31 14:56:08 +02:00
i18n Localisation updates from https://translatewiki.net. 2016-05-30 22:25:51 +02:00
modules Merge "Fix opacity on load in IE & Edge" 2016-05-31 10:38:56 +00:00
resources Adjust arrow styles 2016-05-30 11:54:24 +02:00
tests Improve SliderView rendering tests 2016-05-31 14:56:08 +02:00
.csslintrc Add csslint for CSS codestyle checks 2016-05-19 13:10:57 +02:00
.gitignore Initial commit. 2016-04-19 16:35:37 +02:00
.gitreview Add .gitreview 2016-04-18 13:54:12 +02:00
.jscsrc Initial commit. 2016-04-19 16:35:37 +02:00
.jshintignore Initial commit. 2016-04-19 16:35:37 +02:00
.jshintrc If the slider fails to load then fail nicely! 2016-05-12 09:46:39 +01:00
composer.json composer.json mediawiki/mediawiki-codesniffer to 0.7.1 2016-05-09 09:20:53 +01:00
extension.json Merge "Adjust arrow styles" 2016-05-30 10:51:27 +00:00
Gruntfile.js Add csslint for CSS codestyle checks 2016-05-19 13:10:57 +02:00
package.json Add csslint for CSS codestyle checks 2016-05-19 13:10:57 +02:00
phpcs.xml Initial commit. 2016-04-19 16:35:37 +02:00
README.md Add Readme with install and test instructions. 2016-05-11 17:44:35 +02:00
RevisionSlider.hooks.php Use correct time offset based on server and user settings 2016-05-13 11:02:20 +00:00

README.md

RevisionSlider extension

This MediaWiki extension shows a slider allowing selecting and comparing of revisions on a diff page

Installation

Check out this extension into the extensions folder of your MediaWiki installation and add the following line to your LocalSettings.php:

wfLoadExtension( 'RevisionSlider' );

Tests

Before executing tests run tho following in the root directory of the extension once:

composer install
npm install

For the tests run:

composer test
node_modules/.bin/grunt test

QUnit Tests

See https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Run_the_tests