The changes in the response (invalid:true instead of invalid:"" and UTF-8
encoding instead of JSON escaping) does not matter here.
Change-Id: I0b2382e373527973c8cbc75ce9213b3b6e9dafb9
When the ESC key is pressed, aborts the drag and returns the sliders to
their original positions
Bug: T140965
Depends-On: Ib0f386c6a2447740f44591be70c34cf4a83b88c4
Change-Id: I2dfc2fa03d2c7705fa2947dffa07fbce8ed3b185
E.g. in combination with FlaggedRevs extension, the RevisionSlider
was positioned between FlaggedRevs headers and diffs which looked odd.
Still todo: in combination with FlaggedRevs there is still an issue
with the connector-lines that should be fixed.
Bug: T151450
Change-Id: Ieb1a21549092063729f66656127f59918ec07c90
Looks like custom settings used in a test for number separator
transformation added in Icc9bc09675151645055c7e7f706472a15cc81b0f
influenced RevisonSlider's tests resulting in test failure if
that core test was run before RS test.
Relevant RevisionSlider tests now are ignoring any custom value.
Any value before the test is restored after the test run, though,
in case other tests relied on this (which does not seem to be a case).
Bug: T153121
Change-Id: Ida81b93e4d081b6948e760995a92d182ad79fe0f
The inline padding on the widget element seems to be the original reason
for the flickering. To reflect the CSS it needed to be moved to the
button element.
I overlooked this when fixing the lazy load patch.
https://gerrit.wikimedia.org/r/#/c/323193/16..17/RevisionSlider.hooks.php
This patch fixes it by removing the now doubled padding on the
widget element.
Change-Id: Ie904f619e8c84474653d2ba40d9f9e62e74fa9db
With the parent of this commit (current master)
Loading the RevisionSlider JS without it expanded increases
the request size by roughly 767KB on first request and 242KB
on subsequent requests.
The large size of the first request is mainly down the to
dependancies of the slider.
This lazy loading patch means the RevisionSlider JS
only causes an increase of 184 KB per request.
If the user has the bar expand by default the main JS will
be loaded straight away (and the lazy JS will not be).
This patch also means that when only the bar is loaded the
pin button to set auto expand will not be shown.
This will be added once the RevsionSlider is loaded.
Bug: T151668
Change-Id: I054a82e9ea2aa89326464632e744497239f7adba
Tabs are hooked up to JS events which will break
if they are replaced, just switch out the oldid
in the edit link as that is all that changes.
Change-Id: Iea073f8d435a511ba91cdc0c7bdb9e8f1ec1d4ac
