Commit graph

8 commits

Author SHA1 Message Date
WMDE-Fisch 187e1e5194 Stabilize ruby selenium browser tests
- added sleep to let scripts load
- changed cookie setting to use vanilla JS
- replace deprecated visible methods
- fixed element definitions
- fixed indentation
- removed unused code

Change-Id: I21047f7c529eee7e22f84fe1023c9e23b74cffa0
2018-08-14 07:52:22 +00:00
Thiemo Kreuz 407c1de800 Use cookie to dismiss help dialog and fix failing browser tests
I have seen this failing:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium-jessie/9255/console

The idea is to pre-set this cookie so the help dialog never shows up
in the first place. The tests do not need to look for the element, click
it, wait for the dialog to close. This should even speed up the browser
tests, I believe.

Also this adjustes waiting conditions in several places to address
timing issues with failing browser tests.

Since these tests should be replaced by Node.js on the long run I
added "sleep" in the cases although it's not recommended.

Change-Id: Ida381faa390aa62ebaadd3713864676be80abd51
2018-07-03 16:44:28 +02:00
WMDE-Fisch edd9ed4dcb Add rubocop rules and make it pass
Change-Id: Ie0f7ea20c9f79a005a253b41c120ed40d884a1b8
2017-03-08 12:24:05 +01:00
WMDE-Fisch 12e6631dde Update tests to Selenium 3
The waitr click on the checkbox seems to be broken or is broken with
intend since the actual OOUI checkbox has an opacity of 0.

Additionally when_visible fails when the element is not present yet.
The the way to go here seems to wait for the element to be there
and then check for visibility.

Also made use of PageObject method for checkboxes, the name selector
and the link element.

Bug: T158074
Change-Id: I2c3d6d963c8bcdc420bfbc57c1c2380bce7ef2f1
2017-03-01 17:26:12 +01:00
Tobias Gritschacher c2f4b64a3a Refactor help browsertest
- Applied the Given-When-Then rule
- Created alias of "close-help-dialog" step for readability

Bug: T146276
Change-Id: Icc8aeb8720025bd3c6d6bc811713fac48a9919dd
2016-10-10 14:52:24 +00:00
WMDE-Fisch 2c6bd11eda Avoid errors when elements are not loaded yet
Introduced when_visible where it might be usefull to avoid
flacky browser-tests.

Change-Id: I2c8c58aae1bc859062395a1795513d445ecb37f8
2016-08-31 18:28:50 +02:00
addshore 50fdb7b1c9 Timeline browser tests
This adds tests for navigating the timeline using the back
and forward buttons.
It also makes sure that the buttons are disabled / enabled
at the correct times.

Bug: T133278
Change-Id: I9834dd3d3bf107557b15fdd105a946902d53b8f2
2016-07-05 11:44:23 +02:00
addshore 6101897460 Add browser tests for tutorial / help dialog
Testing the visibility / presence of things around
the dialog appears to be hard and the DOM for the dialog
remains unchanged when shown / hidden as far as I can see.

These tests test that the dialog is only shown once per
user.
And that the sequence of the dialog works in regards to the correct
buttons being present at the correct times.

Bug: T133278
Change-Id: Ia86cb69573da3e888c2897b8b50f1d2e5c61d8d4
2016-07-04 13:39:19 +00:00