addshore
fc213c8880
Flip toggle button in 2 missing cases
...
- The first case is when the slider is collapsed and the auto
expand is switched on, the slider expands and now the toggle
switches.
- The second case is when the slider is loaded expanded, the toggle
now loads in the correct direction
Bug: T150846
Change-Id: I75610308c9f169fb926953a12dc5108e0fba23bf
2016-11-17 10:59:40 +00:00
WMDE-Fisch
f17850d6e6
Clean up logging in code
...
Change-Id: Iad9f6846f9a80e7c6e82d930f643a92c8f42cab6
2016-11-16 15:42:04 +01:00
James D. Forrester
3269f791f5
build: Bump eslint-config-wikimedia to v0.3.0 and make pass
...
Change-Id: I774e05c4393eca8b4719f335a124efcb3d2a6dd5
2016-11-15 16:48:38 -08:00
Tobias Gritschacher
518aea3ead
Clean-up browsertests
...
- add Gemfile.lock
- use recent version of gems
- ditch README and link to wiki documentation
- clean-up environments
Change-Id: I76bb1d491911abbc0c0bb4387b436ab3ff2cebc2
2016-11-14 12:07:41 +01:00
Translation updater bot
8d6316f232
Localisation updates from https://translatewiki.net .
...
Change-Id: Iaacdd3c15c3241e1667f6c600059304fee3927d8
2016-11-10 23:34:47 +01:00
Tobias Gritschacher
d079937e43
Fix browsertests README
...
Change-Id: I4ec4c22a69b4cf896b0f5a719f47ea84b7faaec3
2016-11-09 13:33:29 +01:00
WMDE-Fisch
a8a129d627
Move lines into container
...
Bug: T149175
Change-Id: I4e231ff450661eaeaabae0fd2883914bb62101dc
2016-11-08 15:45:59 +01:00
WMDE-Fisch
df9d94ca60
Draw lines between pointers and related columns
...
Introducing a new class that draws lines between the pointers
and the related diff columns. Lines are redrawn when pointers
were moved. A colored border is added to the diff columns and
readded when the diff changes.
Bug: T149175
Change-Id: Iadf779368c58da7779c769bda8e9bd3fc5afcffa
2016-11-08 13:46:14 +01:00
jenkins-bot
bf9cde5d66
Merge "Remove negative margin"
2016-11-03 12:23:40 +00:00
WMDE-Fisch
6f8e23f7d9
Remove negative margin
...
The top pointer hovers a few pixel over the slider line. Thats
not intended.
Change-Id: I5424ea72ccf2828d638c1fc4e9e2e345ba7bf94e
2016-11-03 13:00:40 +01:00
jenkins-bot
53dbf1b741
Merge "Add margin to pin button"
2016-11-03 10:46:10 +00:00
Tobias Gritschacher
1bef050429
Add margin to pin button
...
This also fixes the "border-overlapping-issue" when hovering
the pin button in Chrome.
Bug: T145726
Bug: T145519
Change-Id: I6d3788ca5f54937f84c6a7f0fcc456ddf4b665d7
2016-11-02 14:16:02 +01:00
WMDE-Fisch
c73cc114a7
Merge OOUI setting of attributes
...
Change-Id: I06ed509e2d47ef0369133e3c0da5b85935a9089e
2016-11-01 15:51:27 +01:00
Translation updater bot
fd915fdda5
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia312111bff1f6b3c215ba86f182956241bb929d4
2016-10-30 22:45:25 +01:00
Translation updater bot
d734150fbc
Localisation updates from https://translatewiki.net .
...
Change-Id: I4230776db94f0d5cdf72fd5b08339a1c7e8283b7
2016-10-29 22:52:10 +02:00
Translation updater bot
9a1b3d0b38
Localisation updates from https://translatewiki.net .
...
Change-Id: I57c3e79d622b58ac573efafa530aa602c859eafd
2016-10-27 23:21:21 +02:00
addshore
c824428d41
Only show in beta feature list when enabled as a betafeature
...
Bug: T149092
Change-Id: Iab021a8699845cfc302353c453ebdc1c125d7fd9
2016-10-25 15:21:32 +01:00
jenkins-bot
bb4666ae88
Merge "Store settings for anonymous users"
2016-10-25 13:29:24 +00:00
Chad Horohoe
ee4b365bef
Whoops, track not trace
...
Change-Id: I953b9346322ead2bee5fcfd14329ea0e106074d6
2016-10-24 17:03:28 -07:00
Chad Horohoe
090e1c4066
Swapping defaultbranch for trace
...
The former is a maintenance nightmare when branching.
Bug:T146293
Change-Id: I4a4c67ca421f38e1231f0ca00eadfd55a000e892
2016-10-24 16:38:18 -07:00
WMDE-Fisch
300c552334
Store settings for anonymous users
...
Introducing the Settings class handling settings for all users.
Use hidden user prefs for logged-in users and localStorage or
cookies for anonymous users.
Bug: T145494
Change-Id: I8676873c87d5656c55365706f1ccefa604caae4d
2016-10-24 16:46:42 +02:00
jenkins-bot
530295db60
Merge "Add a betaFeature switch"
2016-10-24 14:46:00 +00:00
addshore
02991a7bd0
Add a betaFeature switch
...
This config option allows the extension to be deployed
on a site that has the BF extension enabled while not using
it (ie, being a default feature)
Bug: T148644
Change-Id: I2539e4762d7c1c34ea24f98fdf24c2aecb3d27b0
2016-10-24 13:08:58 +00:00
jenkins-bot
f266017c33
Merge "Don't nest mw-content-text element when reloading diff"
2016-10-24 09:22:43 +00:00
addshore
1e1c2f5943
Don't nest mw-content-text element when reloading diff
...
Bug: T144391
Change-Id: I5763c6c4288bfcfef03df0cd949715d21430c9af
2016-10-24 09:53:08 +01:00
addshore
066d905d33
Fix my author entry
...
Change-Id: I8bbdc9b4a39c235170ba3bfba71c78b453a3176a
2016-10-22 14:43:59 +00:00
jenkins-bot
b47ffaf801
Merge "Fix selecting betafeature in browsertests"
2016-10-22 10:53:50 +00:00
Translation updater bot
e67cc39ac7
Localisation updates from https://translatewiki.net .
...
Change-Id: I56ebdab1994b1a6355f6bf0b4e97d6ab1f86f9dc
2016-10-21 22:37:45 +02:00
Tobias Gritschacher
69e3a7dd6e
Fix selecting betafeature in browsertests
...
this broke due to https://gerrit.wikimedia.org/r/#/c/315850/
Bug: T148841
Change-Id: I8997ec6d8bb210b87bb984a8f6aed2ba10dbd3f6
2016-10-21 17:29:01 +02:00
Translation updater bot
35a00afc94
Localisation updates from https://translatewiki.net .
...
Change-Id: I48842261c8eff2e8f41f5a9ab100306d70758f08
2016-10-20 23:48:30 +02:00
Translation updater bot
8717c28f3a
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifad55e49544180a892056948545aacd21dfca135
2016-10-18 22:40:30 +02:00
Ed Sanders
62c5b4cff9
Prevent selecting the same revision twice
...
Bug: T141254
Change-Id: Ic51605dca1484ce66ce9764a2291c8a947f9d376
2016-10-14 10:25:10 -07:00
jenkins-bot
5d7c37a858
Merge "Throttle the window resize event handler"
2016-10-14 09:24:26 +00:00
jenkins-bot
8987ccdcec
Merge "Update linters and remove redundant ones"
2016-10-14 08:28:15 +00:00
Ed Sanders
79c0305b09
Throttle the window resize event handler
...
Drag-resizing a window results in hundreds of events being fired,
so limit this to one event every 250ms.
Change-Id: Ie3ace9001cd840a5d790cd269c4ae3c77649079a
2016-10-14 08:25:35 +00:00
jenkins-bot
64f6724128
Merge "Avoid parseInt"
2016-10-14 08:25:30 +00:00
jenkins-bot
ef111d2342
Merge "Compute and cache directionality once"
2016-10-14 08:25:29 +00:00
Ed Sanders
08aef9f5f4
Update linters and remove redundant ones
...
eslint covers jshint and jscs rules.
Change-Id: Ieff7a050021e504575a774c7c9ba987b23380294
2016-10-13 12:05:10 -07:00
Ed Sanders
a020b238e9
Avoid parseInt
...
Where we know the number contains only numerals, just cast
straight to a number using '+' operator. When getting computed
css from jQuery, use more suitable position methods instead.
Change-Id: Ia58b41a4522a1ef5a1516852821573c47e8dc9c9
2016-10-13 11:58:55 -07:00
jenkins-bot
5688a81a54
Merge "Refactor timeline browsertests"
2016-10-13 15:32:48 +00:00
jenkins-bot
a77023a78b
Merge "Refactor tooltips browsertests"
2016-10-13 15:31:11 +00:00
Tobias Gritschacher
f3a239aa24
Refactor timeline browsertests
...
- Applied the Given-When-Then rule
- Added separate accessors for disabled arrow elements
Bug: T146276
Change-Id: I0278ef607f96851ed69e7373b952f5d02139cb0c
2016-10-13 15:22:57 +00:00
Tobias Gritschacher
3ca7099cc6
Refactor tooltips browsertests
...
- Applied the Given-When-Then rule
Bug: T146276
Change-Id: Ie9eb48cafd85ef7a00c9d9f9fd626fab5f128824
2016-10-13 15:22:46 +00:00
jenkins-bot
846fca04c2
Merge "Update beta feature screenshots to use proper layout and colours"
2016-10-13 15:21:55 +00:00
Ed Sanders
5e73b6badc
Update beta feature screenshots to use proper layout and colours
...
Bug: T144428
Change-Id: I60e90436a6e99f7d5131b4cfe0ff4d9e956bcb94
2016-10-13 15:02:31 +00:00
WMDE-Fisch
8fef5ac005
Fix order when executing pointer update
...
This should always happen before updating the diff.
Change-Id: Icf6b52c3495e42e188bfa5d5307f91d0558cc7a4
2016-10-13 16:51:11 +02:00
WMDE-Fisch
a111213d36
Wait for pointers to finish moving in browsertests
...
This will avoid checking pointer data prematurely when
they are still moving and the diff was not reloaded yet.
Change-Id: I3c29a43940e40b7c338a00b3520e5aa6b237ea4a
2016-10-13 16:41:19 +02:00
Ed Sanders
d728cda396
Compute and cache directionality once
...
Computed CSS ($.css) is relatively slow, and directionality
should never change, so just compute it once.
Change-Id: I6519fa7f54599c498e22a348dfaedd940c860955
2016-10-12 21:07:28 -07:00
Tobias Gritschacher
da8f7fb064
Update pointer position attributes immediately
...
Update attributes right after setting position and
don't wait until revisions are refreshed.
Change-Id: Ic32a554d6939806ce95d4e7b441ee08965b81940
2016-10-12 15:31:38 +02:00
Tobias Gritschacher
5553fe0688
Remove obsolete step
...
Bug: T146276
Change-Id: I9b1b8e2aa87b88bd18d58a46834e6090284314ee
2016-10-12 11:48:06 +02:00