Commit graph

397 commits

Author SHA1 Message Date
Leszek Manicki c745c917c3 Wait for auto expand button before checking its state in browser tests
Change-Id: I8b8e43f14f6e6aa2ee619d823f93fdfeabb469ac
2016-09-06 17:44:52 +02:00
Leszek Manicki 8e7fe2434d Add eslint, to be used instead of jscs and/or jshint
First I jumped on replacing both jscs and jshint with eslint but
it might be premature decision. Although linting with eslint
is possible (like in there is wikimedia config for eslint)
it is still not clear should it

But in case the change happens we will be ready.

Apart from config stuff this changes few bits spotted by eslint:
improves some indentation, removes weird spaces, completes some
doc blocks, changes IIFE forms in tests. These changes do not
seem controversial.

Change-Id: I9f8bf0f5745da8e662685f4cd879ea4baa609c01
2016-09-05 09:47:11 +02:00
Translation updater bot b411c98225 Localisation updates from https://translatewiki.net.
Change-Id: Iaa60d379f31cd3a24fe242c8f6981d2ed5dfa732
2016-09-04 22:32:07 +02:00
jenkins-bot 6807aabbad Merge "Add licence, home page URL and repository URL to package.json" 2016-09-02 07:57:00 +00:00
Translation updater bot 3695d07000 Localisation updates from https://translatewiki.net.
Change-Id: Ib2006d820f27959f36da9ad79d6230bdb4007415
2016-09-01 23:27:14 +02:00
jenkins-bot ea9c83aa80 Merge "Close tooltips when clicking somewhere outside of them" 2016-09-01 12:42:16 +00:00
jenkins-bot 50313505fd Merge "Avoid having multiple revision tooltips at once" 2016-09-01 12:38:50 +00:00
Leszek Manicki 98150d9904 Add licence, home page URL and repository URL to package.json
Change-Id: I7dac5a5d5e62cb89c093f91c105bd0a5aa5115df
2016-09-01 14:28:55 +02:00
WMDE-Fisch 9be2aa5a56 Close tooltips when clicking somewhere outside of them
Added the revisions to the exception to avoid tooltips beeing
closed and opened again when clicking on a revision-bar to
load it.

Bug: T143090
Change-Id: Ib8011a52c469ad715e97c1c42e7489c5b31aa4a8
2016-09-01 13:25:24 +02:00
WMDE-Fisch 2277651f44 Avoid having multiple revision tooltips at once
When rendering several RevisionListView items e.g. by loading and adding
more revisions each one had its own 'currentTooltip' so the elements
where not exclusive. This patch fixes that by looking for the class
objects when closing tooltips or changing wrapper highlighting.

Tooltip timeouts are still per-list but that should not affect the
behavior with multiple lists.

Bug: T143090
Change-Id: I23c61547e1a925da1c0b7e7a475ad61e6ed1b1b6
2016-09-01 13:18:12 +02:00
jenkins-bot 3dcfec7f5e Merge "Update URL in print footer when reloading a diff" 2016-09-01 09:57:38 +00:00
jenkins-bot 8a7b124c26 Merge "Improve tooltip handling" 2016-09-01 08:27:05 +00:00
jenkins-bot d0d055fd9d Merge "Use progress bar instead of text when initializing the slider" 2016-09-01 07:52:52 +00:00
jenkins-bot 73e822ebdf Merge "Avoid errors when elements are not loaded yet" 2016-09-01 07:43:00 +00:00
WMDE-Fisch a0cb76f747 Improve tooltip handling
Reordering of stuff and splitting conditions seems to fix some of wiredness.
Mouseenter and Mouseleave are the better events in these cases.

Change-Id: I66d71b1d4f394199949475dc42ca085169e0584f
2016-09-01 07:40:49 +00:00
Translation updater bot f9a4ebb5b3 Localisation updates from https://translatewiki.net.
Change-Id: I3ad2a21c94ec09101f8a8c588c93b24e020c7a80
2016-08-31 22:37:46 +02:00
Leszek Manicki 686bc5df9a Use progress bar instead of text when initializing the slider
Bug: T139233
Change-Id: I27d24c8d6fc5a357b4af9bf929799a237fd200d9
2016-08-31 18:32:54 +02:00
WMDE-Fisch 2c6bd11eda Avoid errors when elements are not loaded yet
Introduced when_visible where it might be usefull to avoid
flacky browser-tests.

Change-Id: I2c8c58aae1bc859062395a1795513d445ecb37f8
2016-08-31 18:28:50 +02:00
Leszek Manicki f10e137897 Update URL in print footer when reloading a diff
Print version of the page contains a "Retrieved from" link
referring to a particular revision. URL should be adjusted when
revisions are switched in the slider

Change-Id: Icca3c452ae6926a997b22d3bf9632591fbc0b58d
2016-08-31 15:54:09 +02:00
jenkins-bot e34c42782c Merge "Simplify visiblity checks for tooltips" 2016-08-31 12:20:46 +00:00
jenkins-bot f4d7447fad Merge "Remove not need browser test helper method" 2016-08-31 12:20:39 +00:00
jenkins-bot ddf94dd141 Merge "Do not include Revision Slider in the printable version of the page" 2016-08-31 12:17:16 +00:00
WMDE-Fisch 2da20ba593 Simplify visiblity checks for tooltips
Change-Id: I2eba136a92054df7431dedb7a83f5af38f4d01e9
2016-08-31 12:47:18 +02:00
Leszek Manicki e55f28f877 Remove not need browser test helper method
Slipped in in Id561485344cba9b136666fe31b086151467de19e

Change-Id: Iba279cd7f1b09709ac3f316fa5b7c14a30256d4c
2016-08-31 12:27:39 +02:00
jenkins-bot 3f6815858c Merge "Add button to have revision slider expanded automatically" 2016-08-31 08:27:02 +00:00
Translation updater bot a026a8cc32 Localisation updates from https://translatewiki.net.
Change-Id: I3835cf5657641dffabbfd41951156902129875f2
2016-08-30 23:03:50 +02:00
Leszek Manicki 6502728184 Add button to have revision slider expanded automatically
This adds a button which allows a user to make revision slider
automatically expand on each diff page (disabled by default).
User's choice is stored as a hidden user preference.

This is a bit hacky as it squeezes a button on top
of another button (100% wide expand/collapse button).
This also adjusts styles of ToggleButtonWidget so
the button looks more like a frameless button, although
it is created as a framed one (to have inverted behaviour
when button is in its "on" state).

The button only gets visible when Resource Loader finishes
loading JS and CSS to avoid button jumping around the top
of slider window before "right" styles are applied.

Bug: T142196
Change-Id: Id561485344cba9b136666fe31b086151467de19e
2016-08-30 13:57:12 +02:00
Leszek Manicki 6c8c275690 Do not include Revision Slider in the printable version of the page
Change-Id: I477e80b82a74ac02e48759fc912200350cfc1824
2016-08-29 08:23:00 +00:00
jenkins-bot 1153261782 Merge "Reload category links when reloading the diff after revisions change" 2016-08-29 08:07:00 +00:00
Translation updater bot 0b0bebf817 Localisation updates from https://translatewiki.net.
Change-Id: I95459fbf536e5e754d313b3968f6db367c00048f
2016-08-28 22:41:12 +02:00
Translation updater bot 9526cc2971 Localisation updates from https://translatewiki.net.
Change-Id: I11149d4b64b4e46a8a8c32edef69103dfe285dcc
2016-08-26 22:33:50 +02:00
Leszek Manicki a64dc43963 Reload category links when reloading the diff after revisions change
Bug: T143843
Bug: T143204
Change-Id: I6871ef106729e598329647d2726bef4755c45299
2016-08-25 14:01:42 +02:00
Translation updater bot 741f4079d2 Localisation updates from https://translatewiki.net.
Change-Id: I4992dceefde56f5ce51ae6e94c843e665380fff3
2016-08-24 22:38:25 +02:00
Translation updater bot ab238ebc4c Localisation updates from https://translatewiki.net.
Change-Id: I6792cec94d94e10c7a36b50a75d51844c32ed282
2016-08-24 10:36:19 +02:00
jenkins-bot 805b92dd1a Merge "Use moment.js's localized date and time format" 2016-08-23 10:19:07 +00:00
Leszek Manicki 4df5bab52b Rephrase the label of the slider visibility toggle button
Bug: T142651
Change-Id: I64ef7db74e24a0fcb0f34f96e5de2419a4ac53bb
2016-08-23 11:36:19 +02:00
jenkins-bot 3c1c284de5 Merge "Highlight revision bar when hovering revision wrapper." 2016-08-21 11:04:45 +00:00
jenkins-bot 923d9608e2 Merge "Expand draggable/clickable pointer area." 2016-08-21 11:01:23 +00:00
jenkins-bot 01cf07fc12 Merge "Remove transition on revision wrapper hover." 2016-08-21 10:58:14 +00:00
jenkins-bot 6c365b1274 Merge "Remove 1px height from pointer container." 2016-08-21 10:54:45 +00:00
Translation updater bot 0998da3b98 Localisation updates from https://translatewiki.net.
Change-Id: Ibeb8423d672da2264b9bfaae0e63f2eb11f1833b
2016-08-19 22:42:24 +02:00
Jakob Warkotsch 188c5d58c8 Remove transition on revision wrapper hover.
Bug: T143116
Change-Id: I85dbb9e9c46a022d701dc956051304090daa44fc
2016-08-19 16:18:17 +02:00
Jakob Warkotsch c5687cde9a Highlight revision bar when hovering revision wrapper.
Bug: T143115
Change-Id: I4e4d749e4d1b9644db66a476731a052c450caa3c
2016-08-19 14:57:11 +02:00
Jakob Warkotsch 19d98c55df Remove 1px height from pointer container.
Bug: T143113
Change-Id: Id9eee9451cc2437adbf3c3e109b26bec028134ca
2016-08-19 14:44:05 +02:00
Jakob Warkotsch 2625c6f1aa Expand draggable/clickable pointer area.
Bug: T143091
Change-Id: I43d8635542e489d816aea0b8ab3366207f27546c
2016-08-19 14:15:06 +02:00
Leszek Manicki 4f81f54272 Add type hints to getBetaFeaturePreferences
Change-Id: I3f72dbfae1e35a65789a420a71a7aab4f49ad05b
2016-08-19 12:05:17 +02:00
WMDE-leszek 2a00a235cf Merge "Reload side panel when loading a new diff." 2016-08-18 13:55:58 +00:00
Jakob Warkotsch 2a25f73fc5 Remove unused message.
Change-Id: I3a266e1576aeec50c618568d7a05ab3ad29d39f1
2016-08-18 15:26:54 +02:00
Jakob Warkotsch a88c05c1f6 Reload side panel when loading a new diff.
Bug: T143204
Change-Id: I1034c756f094c9a3b12cfdd65c94f036fc0e4eee
2016-08-18 15:00:55 +02:00
Leszek Manicki d2a4c63107 Expand slider if there are space for more revision at the beginning
After resizing a window there might be more space at the beginning
of the slider "axis" than there are revisions loaded so far. In such
case the slider should be expanded, so more revisions are loaded
to fill the whole available space.

Change-Id: Ied8abe294967328112afb1fe4d14b2e29ed2c092
2016-08-17 14:35:01 +02:00