Reintroduces IIFE closures in test files because variables were
declared in the global namespace, and "const" now causes hard errors.
Bug: T339323
Change-Id: I69e9d7a29591137f185f3e5ab02dea590ec4dff6
Due to some change in the test setup, possibly related to the new
Vector skin, the slider now has more space and the need to scroll
triggers at a later point.
Change-Id: I5411d5a31714761434135e65d916f57f1e437003
WebdriverIO has dropped support of sync mode, hence changed to async.
Update npm packages: @wdio/*, wdio-mediawiki
because async mode needs at least @wdio v7.9.
Remove npm packages: @wdio/dot-reporter and @wdio/sync.
Bug: T300798
Change-Id: I053ea6b5fbfdcff279f4eb10cf2429155690bd72
The new mw eslint config comes with node 12 and the change will be
quite big due to the lock file. I wanted to keep the diff of actual
code changes seperate.
- Applied all code style recommendations
- Removed one test that's not giving any value
- Changed regex .match to .test for performance and convinience
Change-Id: I578be8c6460c7a4d1220354c028a9bfd9bb86d13
It's never used in another context but together with the
….Slider module.
Motivated by the confusion about the two types of require()
introduced in Idf1cc79.
Bug: T233279
Change-Id: I922d7ab56fd3ce80bc901f1a5d7174df6fe6756d
It's never used in another context but together with the
….Slider module as well as the ….init module. The ….init
module continues to require the ….Slider module, so all
dependencies are still met.
Motivated by the confusion about the two types of require()
introduced in Idf1cc79.
Bug: T233279
Change-Id: I4b4ef69f3074d57f884763c092a515ce976daaef
It's never used in another context but together with the
….Slider module.
Motivated by the confusion about the two types of require()
introduced in Idf1cc79.
Bug: T233279
Change-Id: I7c98a41051e6d83ab3524cb14a709002feec2d78
Update npm packages: @wdio/* and webdriverio.
Also adding a fallback for the case, that the slider does
not open as expected.
It seems, that the update is causing some issues when
waiting for the module state. Waiting for the lazy module
in DiffPage.ready() should make sure, that the event to
trigger the opening of the slider is in place. This seems
to fail sometimes.
Bug: T274579
Change-Id: Icd597fc5aaa857879a8af310166867d433ba0678
wdio-mediawiki v1.1.1:
- Includes wdio-defaults.conf.js file that vastly simplifies wdio.conf.js.
- Replaces @wdio/spec-reporter with @wdio/dot-reporter.
- Introduces video recording.
Some part of the new setup seems to influnce they way how resize is applied
to the window. The fix makes sure it works as expected.
Bug: T283597
Change-Id: I20697815591243367b5a8bdd1cd1cc173a1ddc77
… and replace them with more trivial `function …() {}`. I
believe this does not make any difference. But I feel this
makes the code a little more straightforward.
The motivation for this patch is because a few other patches
change some of these function declarations, leaving a (in my
opinion) confusing mixture of styles behind.
Change-Id: Ib8928c4176a963afcf1fee1c785dd7bdc86c9706
Reducing the width further leads to a strange behavior were it fails.
Locally this test is about 30% faster this way.
Change-Id: I5f950041ccf0f2f326ad6d9023d300e6a344f902
Directly measure the jQuery animation using its custom
pseudo-selector. Previously, we had been relying on a side-effect.
Change-Id: I0db8077e9ed86d5be025d089e0467654789bb13f
`aria-disabled` is a bit of a hack, but maybe more robust than
coupling to the OOUI internal class name.
Bug: T267205
Change-Id: I5c1f547f2d25d9acaa74d63da03cd215be82bd71
The numbering in the content of the test revisions was slightly changed
to fit the data-pos attribute numbering in the revision tags.
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267201
Change-Id: Ifa25b881c6aa1e94a934532606c944a33f5648dd
I don't understand how others are running the tests, but I need this
configuration in order to run. They also appear in the
mediawiki/core wdio.conf.js .
Bug: T180247
Change-Id: Ic75bac41e0bf3cda3b23a4489e02f1dde2300740
These test do not add much value. Expanding the interface is an
essential step done in all other tests. Therefore the only test
ported is manually collapsing the interface.
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267198
Change-Id: I7beabc1a91f22dc8b7094318bf90684a3deb63f7
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.
Bug: T267198
Change-Id: I75baea2bd104666ba7f6a15ba79e10f7967cddb3
