Commit graph

451 commits

Author SHA1 Message Date
WMDE-Fisch a2ca2c031e Add node selenium tests for revision highlight feature
The patch adds a first package of node selenium tests including
test for the user and tag filters.

The classes for user- and tag-rows were re-added to have better
access via selectors.

Change-Id: I8c53d9c923820e177d83ee900cee08e93cd3f65b
2019-04-11 17:58:53 +02:00
James D. Forrester 153ecb8990 build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0
Change-Id: I5a5aede4114b0e6d370904a08f10b327b4968a2d
2019-04-04 00:56:01 +00:00
WMDE-Fisch 6ddf000c0e Slighlty improve filter highlight UI
- move border to right so when the text starts there's a straight line
- increase right margin to fit mock
- adjust border radius so it's most probably always more than the line height

Bug: T218770
Change-Id: I76a2f096d14bf4d912686a71e5771ead1c7db3e6
2019-04-03 10:54:49 +02:00
WMDE-Fisch a96b079e8f Unify highlighting CSS classes
Change-Id: Iceb094075d1fb1bd4aca53c120dbc3c6ccd39eb6
2019-03-25 17:30:47 +01:00
WMDE-Fisch 55c558169b Retrieve revision list in highlighting method
This moves the retrieval of the revisions into the method setting the
highlighting. The check for undefined did not to much since the rev
var would still remain undefined.

Change-Id: I1acf540f135af4c16fb80d633b3690473ada7833
2019-03-25 17:21:03 +01:00
srish 6ee7f910b7 Add filters for tags
* Uses the existing implementation of highlighting revisions from the same user
* Shows bubble next to tags in Tooltip
* When you hover on a bubble, tag row is circled, and revisions with a specific tag gets highlighted. When hovering ends, highlighting ends. But, if there is an active filter available, all previous states are restored accordingly.
* When you click on a bubble, in addition to highlighting revisions and tag row, any previous tag or user filter is removed.

Bug: T203581
Change-Id: I824a027a7f542eb7227545870553e58ec23542bb
2019-03-25 16:57:57 +01:00
Ed Sanders 57f9876e27 build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I8aeddc384d25318e8618bb617884205f1c0c1f00
2019-02-10 16:54:28 +00:00
gopavasanth cbf6d4b76c Quick CSS fix
Changed RevSlider tooltip user-row bubble height and width

Bug: T213643
Change-Id: I31278bf00730ba5993a881b695ebff2df2da7f6a
2019-01-16 17:54:33 +01:00
Thiemo Kreuz 2a2d01ffc9 Remove redundant checks for .length on jQuery objects
jQuery objects behave fine when they don't contain anything. No need
to check the .length before. This is one of the essential feature of
jQuery.

I'm also simplifying some setTimeout the same way. clearTimeout will
never fail. It will ignore numbers that never represented a timeout,
or have been cleared before. Note how the property was never set back
to -1. So this code was kind of incomplete anyway. I suggest to fix it
this way around, instead of trying to set -1.

Change-Id: Ic15812ead9d93f8eb07831aeb75577df2abdff07
2019-01-14 09:40:55 +01:00
srish ee10c6e665 Change the DOM order of pointers and rebuild styling
Initial patch for introducing keyboard shortcuts reversed the blue and yellow lines. To fix that issue, the DOM order for pointer lines were put back to the original state in https://gerrit.wikimedia.org/r/#/c/473217/. Now, this patch tries to put the tabbing order in place reversing the changes made for the fix as per discussion in https://phabricator.wikimedia.org/T162119#4753481 and style changes.

Bug: T162119
Change-Id: Ic84503de0a877095c118abddb8066aeb667bc03c
2018-12-07 13:02:39 +00:00
jenkins-bot 401c775ced Merge "Fixed Pointers and Pointer lines alignment" 2018-12-07 11:49:18 +00:00
Ed Sanders 6ea28c8cdc build: Update devDependencies
Change-Id: Ic278699f631ddc08243ceb68678c0715a19c4304
2018-12-04 18:05:18 -05:00
gopavasanth ae42b85975 Fixed Pointers and Pointer lines alignment
Bug: T210232
Change-Id: Iddb574442db4d0ea525b0806596663de79d3ec2e
2018-11-24 22:15:43 +05:30
jenkins-bot bebfbd788b Merge "Highlight revisions from the same user" 2018-11-22 14:37:31 +00:00
gopavasanth 9a7db48893 Highlight revisions from the same user
*Fixed Border Overlapping.
*Incresed 10% Darkness to the Highlited Revisions.

Bug: T136105
Change-Id: Ie7ba7631f9fe254391ad28be373de7bff4fd2ed1
2018-11-22 00:26:41 +05:30
Ed Sanders e62f46dd80 Remove obsolete aliases from closures
Bug: T208951
Change-Id: Icf10ea6bbc09542e69c0cd583a4ee4f2f76a3f43
2018-11-16 16:33:52 +00:00
Thiemo Kreuz (WMDE) e227de5a48 Fix (accidentally?) reversed blue and yellow lines
This reverts parts of the patch I4d8db23 (T162119) that have
accidentally been done, as far as I can tell.

Note the revert in this patch here is untested and might partly break
the keyboard navigation feature introduced via T162119. However, I
strongly suggest to fix the bug T208238 first, and look back at
T162119 later, possibly via a newly created ticket.

Bug: T162119
Bug: T208238
Change-Id: I0c03e472b72ddd1414d3ca61970dba15158a8486
2018-11-13 14:43:23 +00:00
Volker E f1cea8c889 Fix icon position of arrow buttons
Also
- fix arrow width to one size of `20px` and
- make use of `.box-sizing` mixin in one occurrence.

Bug: T207905
Depends-on: I09aea78f8ebde37cf4f7de9bf0e14894c76ee722
Change-Id: Ibf4a6c8b77877a34668e91b0f5cf6c11a23e9f88
2018-10-25 09:47:20 -07:00
Volker E 618850af6e Replace 'help' by 'helpNotice' icon
A free-standing, frameless button like this is better off with an
icon like 'helpNotice', part of OOUI since v0.28.2. It is a step
back to the original help icon appearance, the new one is still
available for example to use on toolbars.

Bug: T206753
Change-Id: I3d4102de2209e94fa732c1d1962c757fb7bca331
2018-10-11 10:50:56 +00:00
jenkins-bot 7b1688a2af Merge "Highlight revisions from the same user" 2018-10-10 09:27:21 +00:00
jenkins-bot ed42723579 Merge "Add keyboard shortcuts to move between revisions" 2018-10-10 09:26:05 +00:00
srish 1675096c7b Add keyboard shortcuts to move between revisions
* Added `tabindex` on yellow and blue knobs to enable tabbing
* Used some of the logic of draggable functionality to support moving between revisions with keyboard shortcuts
* Also changed the source order of old and new pointer. Old pointer comes first in the DOM

Bug: T162119
Change-Id: I4d8db2352915c44aa11617edea5bcb0ac92ddc93
2018-10-05 17:38:40 -07:00
gopavasanth 154180ba52 Highlight revisions from the same user
Completed subtasks

* Added bubble in the Tootltip
* Added border on clicking or hovering the bubble
* Highlites Bubble on hover
* When Clicked or hover on the Bubble: Highlights
  revisions from the same user
* Added filter revisions.

Bug: T136105
Change-Id: I64cfef395ce1812d501980067edffe210fc99227
2018-10-05 19:12:44 +05:30
Ed Sanders 351bdcfae7 build: Update linters
Change-Id: If21c9dbeba945d54c6bcf9b6e4edd586c5b411ca
2018-09-13 21:58:39 +01:00
jenkins-bot fdcf11a787 Merge "Rework and cleanup ext.RevisionSlider.DiffPage code" 2018-09-11 02:24:07 +00:00
jenkins-bot 4a50097767 Merge "Show tags data on the tooltip in Revision Slider" 2018-09-04 14:39:36 +00:00
jenkins-bot cef99ee67e Merge "Run hook with actual (non-detached) content node" 2018-09-04 09:11:17 +00:00
Thiemo Kreuz 48396b78c7 Rework and cleanup ext.RevisionSlider.DiffPage code
This is a direct follow up to the change done in I885f8e7. I found the
code very hard to read after the change, and tried to rearrange it a
little bit. This is what I came up with. What the code does is entirely
untouched.

This also rearranges the replaceWith calls so the replacements are done
from top to bottom.

This patch also avoids calling mw.config.set multiple times.

Change-Id: I1cbce8e8aa030d6ba5cd7d19ab26fa363e13474b
2018-09-04 10:52:16 +02:00
Bartek Łukawski a7b966162e Run hook with actual (non-detached) content node
`$.fn.replaceWith` removes content from the DOM. Therefore, the
new content object was not being passed on by the hook.

Change-Id: I885f8e789b806a9ae09de1ed31a19a3f9db8144f
2018-08-30 15:08:51 +00:00
gopavasanth e4c31f762b Replace custom 'pin' by 'pushPin' icon
Modified CSS of the pushPin

Bug: T194613
Change-Id: Ifdaa2567c67a45fd44bea7cc4718f29c4e1a58fd
2018-08-30 20:31:04 +05:30
gopavasanth 548019e16d Added keypress() to mw-revslider-toggle-button
On tapping Enter or Space the Rev-Slider Opens

Bug: T199212
Change-Id: I08ab018c3e89d25ab8d4e72963e9cbd4971f7068
2018-08-29 16:07:18 +00:00
srish 6934b90d87 Show tags data on the tooltip in Revision Slider
Approach followed:
- Include tags as an additional parameter in rvprop field to fetch revision tags
- Use API Tags to fetch available change tags for a wiki along with their display names
- At the time of fetching revision data rebuild the revision list with tags containing display names
- Display tags one in each line on the tooltip

Bug: T180429
Change-Id: Ieba8b79ed408ff50b3f7d4bcfd7b2fa8cca83278
2018-08-28 23:22:12 -07:00
srish dd4310aece Replace loading bar of revision slider with three moving bubbles
Using rawElement function to generate a new html element for loading spinner.
This replaces the progress bar widget.

Bug: T161640
Change-Id: I949bce945def25de561c0ae0df971c3f609586ce
2018-08-14 09:31:16 +00:00
Thiemo Kreuz 2d5b40c40b Make use of JavaScript "in" feature instead of "undefined"
Change-Id: I914f7281101bc4873eff3574c884253775e9b4bb
2018-08-02 09:35:37 +02:00
gopavasanth c1fada0773 RevisionSlider: Fix missing pin icon
Added show() and hide() for mw-revslider-auto-expand-button in collapse and expand function.

Bug: T200263
Change-Id: Ic24a175dfe8d19853e32669f12b9f17e26730d6b
2018-07-24 18:46:22 +05:30
jenkins-bot 4a6175b641 Merge "Limit fetchUserGenderData to maximum 50 users" 2018-07-04 11:54:33 +00:00
Thiemo Kreuz 3520a606c9 Limit fetchUserGenderData to maximum 50 users
The 50 is the default. The worst-case scenario here is that users
beyond this limit don't have a gender for a while, until the next call
to the same API endpoint fetches the next 50 users with an unknown
gender.

Doing multiple API calls in advance is not worth it, in my opinion.

Bug: T197858
Change-Id: I0fdcc7ea96a6a5ee3934600c6f0fdc65263276e8
2018-07-04 10:44:27 +00:00
Anmol Wassan 4ab8460fde Indicator flip issue on expand/collapse
The arrow in Revision Slider flips on expand and collapse which is not according to the standard of OOUI.

Bug: T198626
Change-Id: I4205a2260e8507a09f2950566e5033bd58a74345
2018-07-04 10:41:35 +00:00
WMDE-Fisch 20edda4b82 Minor fixes around log animation time
Addressing comments in Ic9fe89c7e3f984d3390260805e2480a0f8ffd0c9

Change-Id: I9a989946f50788d8b47f40a0aa00408b7aa86cb8
2018-05-28 17:12:16 +02:00
Peter Grassberger 16163b4964 Adjust sliding animation time of pointers on short distances
animation duration now has a factor that is dependent on
the square root of the animation distance.

Bug: T161883
Change-Id: Ic9fe89c7e3f984d3390260805e2480a0f8ffd0c9
2018-05-24 18:33:11 +02:00
Ed Sanders 20b098f211 Tweaks OOUI overrides
Change-Id: I089191499b91763c4b36473726cc2701887934fc
2018-03-23 00:55:03 +00:00
Volker E 1986749ff8 Hygiene: Use “OOUI” as unified name in code comments
Bug: T182360
Change-Id: I3085c97db5b9e49ff06a9626dce74f3dc93f7cc3
2018-01-31 22:23:47 -08:00
Volker E e868a33116 Refactor RevisionSlider toggle button CSS
including:
- Using LESS for nested CSS
- Overrule `margin` of frameless OOUI `mw-revslider-toggle-button`
- Removing CSS that had no effect since some time
- Removing `!important` where not longer needed

Change-Id: I1ba01061ebafe799ca62dbb6ce5e79459612af23
2017-11-17 12:06:06 +00:00
jenkins-bot 4c5e32e925 Merge "Replace border-color with WikimediaUI palette one" 2017-11-01 12:07:40 +00:00
jenkins-bot 54ac49ea1e Merge "Remove obsolete CSS .mw-revslider-button-active rule" 2017-11-01 10:49:47 +00:00
jenkins-bot df84c7b8a5 Merge "Use LESS nesting features" 2017-11-01 09:31:10 +00:00
Volker E d6bf659239 Replace border-color with WikimediaUI palette one
Replacing `#ccc` with WikimediaUI color palette's `#c8ccd1`.

Change-Id: Idb7f7b67c2df7a2dac61d09de46bf527713ab465
2017-10-31 20:06:41 -07:00
Volker E 4df0a58755 Remove obsolete CSS .mw-revslider-button-active rule
Removing unused CSS rule for `.mw-revslider-button-active`, which
is not in use anywhere.

Change-Id: Id1c7e8e17b03b54105266bca0418b285840de4f7
2017-10-31 18:55:21 -07:00
Ed Sanders b9f0e2adfe Use LESS nesting features
Change-Id: I6d14b0533510840fb96a56ec3bc38e0bca7a70d0
2017-10-30 21:24:22 +00:00
jenkins-bot 7ff4712b4f Merge "Use LESS color calculation for blue/yellow slider styling" 2017-10-30 12:36:57 +00:00
Ed Sanders 684c6c4b0c Use LESS color calculation for blue/yellow slider styling
Change-Id: I7220acf4b5c4a70f56cde67269c09cd3bf757f19
2017-10-27 19:54:43 +01:00
Ed Sanders bc17a6e9ab Fix collpase button margin/padding
Change-Id: Ia5f2aec089b27085f1dcc4f3e3d49b0a09e4dc26
2017-10-27 12:04:11 +01:00
Ed Sanders 28b436eb16 Cast strings to numbers
Change-Id: Iafbb0ed5197cc7e92ebfc2fb9365c1903ce9ffef
2017-10-27 10:49:01 +01:00
Addshore b86be90b06 Reintroduce improved hover and bar clicking
This patch mainly reintroduces the option to click on bars and move
the pointers with it. To do this, 'ghost' pointers are introduced
to show what would happen when bars are clicked. The pointers moved
differ depending on where the user clicks on a bar. Pointers are
still not allowed to change positions, so in some cases booth pointers
move with one click. See the task description.

The patch also includes some renaming and also refactoring of the
click handling in general. Furthermore bar hover mechanics are handled
by the RevisionListView class now.

Moving both pointers is not possible when it would push one of them of
limits.

Bug: T172092, T173566
Change-Id: I32a8256f7667e03081324d54accdf03a17454faf
2017-08-29 09:19:13 +00:00
WMDE-Fisch dcfb074916 Fix typo and set optional values
Change-Id: I43174f7c28e0f665decf88f92f9175bb4c69a3cb
2017-08-23 17:01:03 +02:00
jenkins-bot c13e687cb0 Merge "Revert "Reintroduce hover and bar clicking"" 2017-08-17 14:08:22 +00:00
WMDE-Fisch 1d2811f3d9 Revert "Reintroduce hover and bar clicking"
We want to make an announcement first.

This reverts commit 0da5702f82.

Change-Id: Icbf5fb99c3fbb87a47106e25d9d80685e86cba32
2017-08-17 13:52:53 +00:00
mdew192837 61e5d029cd Fix unnecessary reloading of diff
Currently, when dragging a pointer over another revision but not
releasing it until it is at the same location, the diff still reloads
This change stores the initial positions and comparing at the end.

Bug: T163425
Change-Id: I430650d12bfeb3ce4af59abe91f18cc2b861a3de
2017-08-12 10:45:16 -05:00
WMDE-Fisch 0da5702f82 Reintroduce hover and bar clicking
Bug: T172092
Change-Id: I496143f2425eccd0028cc1980fc7189a457c70a2
2017-08-11 17:54:48 +02:00
mdew192837 8f9b30b3ac Reduce confusion for mw.util.getUrl()
Currently, `this` is passed as the parameter for pageName, making it
seem like getUrl() can take in an object as the first parameter, when
it should be a string. This works right now because of a tertiary
operator that fetches what we need. To reduce confusion, we should
pass null instead.

Change-Id: Ieea30a4933f3e3fdeb8331c5c544bf1eb034e6b7
2017-08-10 13:49:38 -05:00
Pmlineditor ea187d6944 Convert date in Revision Slider tooltip to link
Bug: T171067
Change-Id: Iedcefdebe99138dc58bec50aaa7e9560d9101c96
2017-08-10 11:46:53 -04:00
mdew192837 d665c03e0a Monobook uses x-small and a globalWrapper to make everything inside
of it appear normal. However, the revslider-tooltips are not inside
this globalWrapper, and thus need a separate CSS rule.

Bug: T166231
Change-Id: I2115688fee75145349e062b9586713a56541afa0
2017-08-09 10:49:24 -05:00
WMDE-Fisch 7c58766b48 Update scroll type detection
Port of a fix in the original source:
1c6d684503

Change-Id: I2d53e467b79d586efc079a15ebc0a52382352f9e
2017-08-06 23:49:48 +02:00
WMDE-Fisch ab5ae5fb98 Remove workaround for OOUI bug
Change-Id: I51d18287736de0ab5d44a74764e3e0b46892c9c6
2017-07-19 11:11:36 +02:00
Ed Sanders b1f2613d79 Use core wgDiffOldId/wgDiffNewId JS config values
Newly introduced in a469795efc5bc1c585c9f84ee289ee099833661d.
This will require MediaWiki 1.30.

Change-Id: I9897a77b24e258bf037f8ec6cafa1d0684bf867d
2017-07-18 16:16:05 +00:00
WMDE-Fisch cf5d602a53 Update eslint and fix issues
Change-Id: I0e3ad763398430608c30bb22741a57c81b2b7062
2017-07-14 12:28:45 +02:00
WMDE-Fisch ab874bdd57 Improve doc, naming and pointer updates
Several improvments including documentation, naming and refactoring:
- bundeling of methods setting, redrawing and loading new diffs
- renamed and improved documentation around some methods in that area
- fixed some leftovers from past refactoring not using new methods

Change-Id: Idf1afcd6ce9210951d28655128a47150f6b7a2aa
2017-07-14 10:19:33 +00:00
WMDE-Fisch 553e48e65a Move scrollType detection to utils
Change-Id: I465e0b74a7d7a6682b22bdd6e7aafb794bce9b24
2017-07-14 10:19:28 +00:00
WMDE-Fisch ada6498b81 Move data pos attr to PointerView
Change-Id: I46c3dceaddae84b279625caec3349aa10d931048
2017-07-14 12:18:51 +02:00
WMDE-Fisch 60f29e11cc Let pointers block each other at the ends of the slider
Bug: T168265
Change-Id: I072e0ddd5f6ab19f5676a0910ffa2e10c258a4a1
2017-07-11 12:37:01 +02:00
WMDE-Fisch 4a9ee131d3 Refactor pointer class names
Pointers can always be identified as the pointer for the "older" and
"newer" revisions. Class nameing was cleaned up and changed accordingly.

Change-Id: Id17878e780b5a405b196fdc5ec7429eeaef5bd4c
2017-07-11 10:17:24 +02:00
WMDE-Fisch 90d90a2f3c Refactor pointer position access
Pointers do not change roles anymore. Older and Newer pointer will
always stay the same. Removed and refactored some logic in that
regard.

Change-Id: I60cf58fb9d0728a9644ed29cac335ebbe7f3de11
2017-07-11 00:42:36 +02:00
WMDE-Fisch 94f9daef82 Minor optimisation and clean up
- reused jquery element
- removed unused method
- fixed doc type
- merged some css

Change-Id: Iadd9d7cb464691b39b7c251b401f687b3d5008b3
2017-07-10 22:41:43 +00:00
WMDE-Fisch edfd885543 Remove last SliderViewTwo parts
Bug: T165747
Change-Id: I9ac410613361e567bd825f096eb12bbb3edc5cde
2017-07-05 10:22:33 +02:00
WMDE-Fisch d299926ff9 Merge/Remove revisionWrapperClickHandler code
Change-Id: I1060f94d81dcfcf4457cea27e71a5d92c22a2186
2017-07-04 12:16:57 +00:00
WMDE-Fisch 05925e3ab0 Merge remaining pointer methods
Change-Id: I89562e445481b9785cf18e02ea02040105632af7
2017-07-04 12:16:49 +00:00
WMDE-Fisch c6f24f2100 Merge container and pointer building and dependencies
Change-Id: I52ac8b42e39b3a37c0bac6b7fff5a676d7c2ecfe
2017-07-04 14:02:58 +02:00
WMDE-Fisch fc5c13f359 Merge draggableDragAction and dependencies
Also temporarily deactivate browser tests for bar clicking.

Change-Id: I347533ef445cb3c37e420beebcc79919e56a1223
2017-07-04 10:56:40 +00:00
jenkins-bot ef2604f00f Merge "Improve support for screenreaders" 2017-06-27 11:23:27 +00:00
WMDE-Fisch c78cf805cd Add fallback background color for linear gradient
Change-Id: I61ff34e29f12fdbb46c30c08428ad5e9bfe1517f
2017-06-22 13:54:10 +02:00
WMDE-Fisch 6ffe96bc4c Fix errors leading to wrong slider scroll postions
The detection touched in this patch addresses slightly different
kinds of RTL handling in browsers. The detection how things are
handled seems to be broken in the mentioned Chrome V8 versions.

The workaround takes care of that issue. With Chrome V8 6.0 this
should be fixed and the workaround can be removed.

P.S.: Credits to Leszek for the idea what's actually going on.

Bug: T168299
Change-Id: I068c2fb6ba60189004c0ec6661fcd346af16126c
2017-06-21 15:21:08 +02:00
WMDE-Fisch 12e34322bc Merge SliderViewTwo CSS into main CSS
Bug: T165747
Change-Id: I1949591063bb8d2df7ddf3bc0c33247ece1bd522
2017-06-21 10:13:32 +02:00
WMDE-Fisch 5f8bf83849 Improve support for screenreaders
This patch improves screenreader support by applying some basic
rules and improving the OOjs UI usage. Things done here:

- make use of 'aria-label' attribute to label interactive buttons
- use connect method on help button to allow keyboard interaction
- give hint on help button that it opens a dialog
- communicate state of autoexpand button
- add attributes to make screenreaders understand the accordion
mechanism if the slider widget

See:
https://www.w3.org/TR/wai-aria-practices/#button
https://www.w3.org/TR/wai-aria-practices/#accordion

Bug: T165489
Change-Id: I7a174e5971a751ec54d4d5115d5441f0a577c103
2017-06-12 09:14:22 +00:00
jenkins-bot 172b9c1832 Merge "Adjust pin layout to new OOjs UI defaults" 2017-06-06 11:42:49 +00:00
WMDE-Fisch fe8bddd881 Adjust pin layout to new OOjs UI defaults
Bug: T166803
Change-Id: I3153b948f3e0a069d6a9869a07e235fcbf8b9e57
2017-06-06 13:04:15 +02:00
jenkins-bot 9c92ef5188 Merge "Adjust z-indexes to work with Modern skin" 2017-06-06 10:56:09 +00:00
WMDE-Fisch 0525f0bdb2 Do not assume that revIds increase in time
This patch fixes issues with the RevisonSlider assuming that the higher
revision id belongs to the newer revision. Min/Max methods to decide what
the diff and what the oldid is are removed and the usage of methods is
adjusted accordingly.

Also the test for switchover pointers is removed since this will not work
with the patch.

Bug: T164455
Change-Id: If5d9cbb8ebd872aee376d249942e6881c8edb984
2017-06-01 18:29:22 +02:00
WMDE-Fisch fce6b2e950 Adjust z-indexes to work with Modern skin
Bug: T166209
Change-Id: I54e7310d215c44ef3e139e940bf61dbee52bf5a8
2017-05-24 13:41:31 +00:00
pppery 4ed9851610 Fix handling of escape key
Previously, pressing ESC aborted the dragging of the slider, but this
was broken by I64cca7a7547310bee64ad95f500b722c362bbb45, which refactored
uses of a variable that was previously a closure into two separate functions.

Bug: T140965
Change-Id: I6b7bc383128d8c7d99da469706bff881f1329cd9
2017-05-22 15:22:55 -04:00
Andrew-WMDE 96a366ddb0 Update help dialogue to explain new sliding mechanism
- works with the setting var to switch help text
 - minified new SVGs with svgo
 - adjusted new SVGs dimensions
 - updated accompanying text

Bug: T162773
Change-Id: I3da66a006977fa6b1999686ba4f415e891f4ea02
2017-05-09 19:50:39 +02:00
WMDE-Fisch 31b9fe31ef Convert touch events to mouse events on pointers
This will make the pointers work on touch devices. The events responsible
for the touch drag and move are converted to mouse actions that will
trigger the draggable.

When using Chrome on touch devices and zooming the offset of elements
calculated by jQuery is wrong. There is a workaround that seems to work
and also seems to not break behavior with normal browsers and on other
devices. Since this only seems to be a problem in Chrome the fix will
only applied to Chrome browsers to avoid performance los on others.

Also introduced a script file for static utility methods.

Bug: T164249
Change-Id: I245f77eb836afded249f3b5ebb7129dab08d0017
2017-05-08 12:55:31 +02:00
Ed Sanders c6465dee07 build: Update eslint to 0.4.0 and make pass
Change-Id: I6e3e2f30615996c57650127cde9738d3a6dd9ae5
2017-05-04 21:06:08 +00:00
jenkins-bot 095c3ea863 Merge "Throw errors, not strings" 2017-05-03 09:33:09 +00:00
Ed Sanders 4e9689ce36 Throw errors, not strings
Change-Id: I65bad18f2526283ba426aed8ff7da9121f230770
2017-05-03 09:47:14 +01:00
WMDE-Fisch 72d19630ad Let revision bars leave space for the pointer line end border
The end border for the pointer lines can not be displayed because the
bars on the biggest revisions used all the height. This patch reduces
the max height of the bars slightly and refactores the calculating method.

Bug: T163436
Change-Id: Idfa6bdb9f85221063e13f3ec16b22fcfbe6cbd9c
2017-04-25 15:29:18 +02:00
WMDE-Fisch 3c4c9fed0d Fix OOjs UI tooltip position
The latest OOjs UI update seem to fix tooltip center positioning.
Margins added manually are removed now.

Change-Id: I883a5026002fae6fbda230b407303a4f2b82914d
2017-04-19 13:08:24 +00:00
WMDE-Fisch 9e6f44cb06 Tooltips when hovering slider lines in the SliderViewTwo
This change enables tooltips when hovering the slider lines. To avoid
interference of these events when dragging a variable is set to keep
track of the dragging state.

Bug: T162602
Change-Id: I45c1b73ca470d7b8fcf8b95e15187864e35e907f
2017-04-19 11:26:51 +00:00
WMDE-Fisch 624b4786ec Introduce RevisionsListView element
This will avoid several jQuery calls.

Change-Id: I1934bcfde97415ca0c01465037f34d2555b6daa4
2017-04-19 11:26:44 +00:00
WMDE-Fisch de86ba0a3e Refactor offset based position calculation
This also fixes some issues with RTL and dragging.

Bug: T162914
Change-Id: I76896f94bf68d4ff0fe143d3f2050c21570052d1
2017-04-13 17:00:49 +00:00
Ed Sanders 187ba30937 Fix alignment of expand icon
Also fix loading of styles for lazy.css to avoid FOUC and
inline style hacks.

Bug: T162804
Change-Id: Ie5a462993075f87b776f8a1f0494b5fe563df079
2017-04-12 18:22:55 +01:00