Commit graph

400 commits

Author SHA1 Message Date
addshore 590742edd8 Pointers browser tests
Bug: T133278
Change-Id: Id94681550aa3e2f02137e6b432dfe06d2b80b9b7
2016-07-05 13:47:31 +01:00
WMDE-Fisch 4f4f500854 Simplify conditions
Change-Id: I7e1a46c865c070f5c804833b9f0b05c5208ff163
2016-07-05 13:23:16 +02:00
addshore 1e65ec602f Tooltip browser tests
Bug: T133278
Change-Id: I7ee7143ab3fcd9c2fe41604c370d9c4e2e7a9d20
2016-07-05 11:57:36 +01:00
jenkins-bot 7d00324b5c Merge "Timeline browser tests" 2016-07-05 09:59:07 +00:00
addshore 50fdb7b1c9 Timeline browser tests
This adds tests for navigating the timeline using the back
and forward buttons.
It also makes sure that the buttons are disabled / enabled
at the correct times.

Bug: T133278
Change-Id: I9834dd3d3bf107557b15fdd105a946902d53b8f2
2016-07-05 11:44:23 +02:00
jenkins-bot 36f4020b9f Merge "Make RevisionList expect list of Revision object" 2016-07-05 08:32:47 +00:00
Leszek Manicki 8e2365502b Make RevisionList expect list of Revision object
Despite its documentation the "constructor" of RevisionList tends
to expect array of revision data in a format returned by API instead
of array of Revision objects.
Due to different name of ID fields in Revision object and in API array,
if "real" Revision object is passed to RevisionList, its ID is lost.

This changes RevisionList so that it only accepts an array of Revision
objects. This provides better abstraction.

This is basically a revert of I147270f28381038d05f8bcfd2317e8c269b2e458
which aimed at the same problem but suggested solution doesn't seem right.

Change-Id: Ic45cdd3e7b707a8c6a19eecf0a84d4c11696cd1f
2016-07-05 00:01:46 +02:00
Leszek Manicki a5c441ecd3 Fix parameter type in docblock
Change-Id: I62e9f2035d869aec5bee02f628623962fab17be9
2016-07-04 23:58:22 +02:00
Translation updater bot 64050f8736 Localisation updates from https://translatewiki.net.
Change-Id: I0bc805b58ecd33f3302a63cb69d5588652039dc5
2016-07-04 22:33:24 +02:00
addshore 1671a07d7d Allow browser tests to add more revisions easily
This allows an arbitrary number of revisions to be created
on a page very easily.
The page created will have a name relating to RevisionSlider
suffixed by a random float.

The base logic for this is taken from:
Ic165f108517c534a4b1c12883621b3624c7b0336

This patch also removes the @vagrant tags as RevisonSlider
is not yet in vragrant.
Please see T139296 for the ticket to add it.

Bug: T133278
Change-Id: I8a25db411bee2fa44555a23d1a840907a185c998
2016-07-04 14:58:14 +01:00
addshore 6101897460 Add browser tests for tutorial / help dialog
Testing the visibility / presence of things around
the dialog appears to be hard and the DOM for the dialog
remains unchanged when shown / hidden as far as I can see.

These tests test that the dialog is only shown once per
user.
And that the sequence of the dialog works in regards to the correct
buttons being present at the correct times.

Bug: T133278
Change-Id: Ia86cb69573da3e888c2897b8b50f1d2e5c61d8d4
2016-07-04 13:39:19 +00:00
jenkins-bot 488f8ec8a8 Merge "Make QUnit tests language-setting-proof" 2016-07-04 13:29:13 +00:00
WMDE-Fisch 471ee2eb47 Remove empty test file
Change-Id: Ica247e802cb9f2abfb1de97b87a6100af4376aef
2016-07-04 14:02:01 +02:00
WMDE-Fisch a27925152a Make QUnit tests language-setting-proof
There seems to be no good way to enforce language on the QUnit tests. It works
for the number formatting by setting the user language on the fly but for everything
else it fails. I simplified some tests and skip some tests or asserts when the language
is not 'en'.

I also added a helper to have conditions for skipping tests. This should be part of
QUnit IMO.

Still I dont know if this is something we should care about at all or just assume, that
devs will know what they do when they try to run tests.

Change-Id: I624ccf3984434e06200abffe7ccdd25b396251af
2016-07-04 11:59:49 +00:00
Translation updater bot b4acd41f22 Localisation updates from https://translatewiki.net.
Change-Id: Id4ea958d6e219fe8126fd0a71bb0583c61d803ca
2016-07-03 22:41:33 +02:00
Translation updater bot 4e228a8721 Localisation updates from https://translatewiki.net.
Change-Id: I4a8453bcd0f95ef7d29b9470aa254d243bce5b2f
2016-07-02 22:54:03 +02:00
Translation updater bot 33653a359f Localisation updates from https://translatewiki.net.
Change-Id: I735f0813117e932ee2885a8da9b5af640c209d04
2016-07-01 23:26:49 +02:00
Jakob 4c70dea9f4 Merge "Prefix all classes and IDs with mw-revslider" 2016-07-01 15:06:16 +00:00
jenkins-bot 24f800e88f Merge "Fix linting path for test files and make a pass" 2016-07-01 10:46:40 +00:00
jenkins-bot 804b95240e Merge "Add remoteExtPath to tests module" 2016-07-01 10:46:37 +00:00
jenkins-bot 0d3e78bcef Merge "Replace csslint with stylelint and make a pass" 2016-07-01 10:46:35 +00:00
Ed Sanders a5f36af0f3 Prefix all classes and IDs with mw-revslider
Bug: T139105
Change-Id: Ia92396ec4f8acea39398173c81842d66257dc519
2016-07-01 11:27:23 +01:00
Ed Sanders cdd4a6bd83 Fix linting path for test files and make a pass
Change-Id: Iee023c901d6e87c6d23ce78a57c16c73d90e3efb
2016-07-01 11:26:18 +01:00
Ed Sanders 237c181c69 Add remoteExtPath to tests module
Change-Id: If923759dfdb9979f91d707c685f91b24ef2aeb33
2016-07-01 11:24:59 +01:00
Jakob e822d1420d Merge "Add PLURAL hint to qqq" 2016-07-01 10:11:21 +00:00
Ed Sanders 7b463c52eb Replace csslint with stylelint and make a pass
Change-Id: I7f3d1cd867399fa23b087daa89970ebe305c46d9
2016-06-30 21:21:28 +01:00
Ed Sanders 30ae1431c6 Bump linting packages and sort
Change-Id: I71166bf48b31144689a3bc01d465d34188e99f84
2016-06-30 21:10:38 +01:00
Jakob f2f24b1b11 Merge "Add more QUnit tests for public methods" 2016-06-30 15:08:15 +00:00
WMDE-Fisch f7ae734b99 Add more QUnit tests for public methods
Added tests for DiffPage, HelpDialog and RevisionListView.
Slightly refactored RevisionListView to improve testability.

Bug:T137964
Change-Id: I07dc8059d5a90bdd6623fd7748d36ba212763e15
2016-06-30 17:01:10 +02:00
WMDE-leszek 200f3e1ddd Merge "Start browser tests (Initial test for beta feature switch)" 2016-06-30 14:01:29 +00:00
addshore d7caa6c1f3 Start browser tests (Initial test for beta feature switch)
This adds 1 simple browser test to make sure that the placeholder
for the revision slider loads when the beta feature is enabled and
does not load when it is disabled

More tests will follow.

Bug: T133278
Change-Id: I5be9014b6c5ac03128c034fd866141e89fd7a0ed
2016-06-30 14:46:37 +01:00
WMDE-leszek 2964b673d5 Merge "Show a tooltip for the questionmark that opens the help text." 2016-06-30 13:11:46 +00:00
Jakob Warkotsch 80aafa27d9 Show a tooltip for the questionmark that opens the help text.
Bug: T138945
Change-Id: I6c3235bdf228d051c7039f188ff62d1137377bca
2016-06-30 15:07:18 +02:00
Leszek Manicki 946c7656f3 Make username in the toolip a link, another approach
This makes Mediawiki render the link. Unfortunately, it is
not rendering redlinks for not exisiting pages.

Also updates qqq.json i18n file which was missing in
Ifb2f33febbdf0f7c9584941b71596abb47fb8088

Bug: T138944
Change-Id: If336984362358193a6c43144ace2f818dbe0633d
2016-06-30 14:27:16 +02:00
Leszek Manicki 22dc00571f Make username in the tooltip a link
Bug: T138944
Change-Id: Ifb2f33febbdf0f7c9584941b71596abb47fb8088
2016-06-30 13:17:07 +02:00
Leszek Manicki 8e5189422a Highlight revision "wrapper" when mouse inside a tooltip
Bug: T138946
Change-Id: I93da2bc2fad36dc2927fe4123f91cab470cb3553
2016-06-30 11:52:57 +02:00
jenkins-bot 7152202b17 Merge "Add own message for minor edit" 2016-06-28 21:09:35 +00:00
WMDE-Fisch 6ea3775f46 Add PLURAL hint to qqq
Change-Id: I86107d8b7e58a5554eef43b201b3529ea944467b
2016-06-28 16:47:55 +02:00
WMDE-Fisch cd6c95f387 Replace article by page
Since the compared revisions do not only resemble article
revisions, using page everywhere might be the better option.

Change-Id: Ic215a02970bf39c35d4f516cdf292be95b590c77
2016-06-28 15:11:33 +02:00
WMDE-Fisch 64c84fd573 Add own message for minor edit
Change-Id: I644d200c05e9d3cad6ef14aa48757e8d58e919f0
2016-06-28 13:48:25 +02:00
Translation updater bot 3d77a27c1e Localisation updates from https://translatewiki.net.
Change-Id: Ida00ff02f83ef66b277f25b12e451974a1d70b38
2016-06-27 23:08:19 +02:00
addshore d5809a08c2 Move qunit tests to a directory
Change-Id: I5aa8d951e8fb77321748af341a1a17277aad9820
2016-06-27 12:24:47 +01:00
Translation updater bot 7dea8d75e1 Localisation updates from https://translatewiki.net.
Change-Id: I7a44209440935699e473f57bfd2658e364e19a95
2016-06-26 14:20:56 +02:00
WMDE-leszek 53335ddb56 Merge "Bump version number to 1.0.0 and add authors" 2016-06-25 14:22:34 +00:00
WMDE-Fisch a2d4b2cbc8 Use username for username label
After changing this several times to address concerns related to
GENDER, decided to use the mediawiki standard here also used
in the core code. For translators a hint was added that GENDER
is not supported here so an appropriate translation should be
chosen by them.

Bug: T136367
Change-Id: Icc2a8e6fc08761367c4ab6bb2a446262f8aa86e6
2016-06-25 16:12:44 +02:00
WMDE-leszek 33cf55a6f4 Merge "Bold tooltip labels and color-coded change size" 2016-06-25 14:07:55 +00:00
Translation updater bot bea73a100f Localisation updates from https://translatewiki.net.
Change-Id: I80b9bbd505e83295f2e04b0d4f54b8d17361fd8a
2016-06-25 14:55:47 +02:00
jenkins-bot 8bfed7caf1 Merge "Make a symbol on the "Show help" button translatable" 2016-06-25 11:40:18 +00:00
WMDE-Fisch 1d436fcfea Bold tooltip labels and color-coded change size
Also introduced language specific number formating. Therefore removed the
'bytes' message. Plural form will be computed in the size messages directly.

Comment label and value were split so the parsed comment can be used
plain without parsing the html again.

Bug: T137183
Change-Id: I12f30cb518e3cc5210528d5b22737dde868a0325
2016-06-24 17:51:36 +02:00
jenkins-bot 6633a87147 Merge "Make revision tooltips hoverable." 2016-06-24 15:50:37 +00:00