Commit graph

1228 commits

Author SHA1 Message Date
WMDE-Fisch 040dd9c945 Factor out setting of cursor pointers
Change-Id: Idb66dcd1daeff48dcce3a39be32eae7c8e17acc8
2017-04-06 07:29:12 +00:00
WMDE-Fisch f978f8690c Fade out pointer lines while dragging / pointer animations
Bug: T162259
Change-Id: I54d6a9bc33b93c0785b2a808b4d1482789d91317
2017-04-06 07:29:02 +00:00
WMDE-Fisch a79fd1624a Fix phan checks
Phan now can run and pass without BetaFeatures extension beeing installed.

Change-Id: I0bb8433fc9f882ff8e021785aba78f707cec00a1
2017-04-06 09:24:36 +02:00
WMDE-Fisch 218b85d0bb Remove 4px pointer margins
It seems the magic done with the 4px margin and its calculations
are not really needed. Getting rid of this does not only clean
the code but is also very helpfull for the new slider logic.

Change-Id: Iae86b8024d3b56517bdc4db5e8baec69bd61afbf
2017-04-05 09:42:49 +00:00
WMDE-Fisch 268944a0b3 Remove browser tests for beta feature setting
The browser tests do not gain very much from the beta
feature tests and the default setting having the extension
only availible as a beta feature slows down the tests in
general.

Furthermore removing this will make it easier to let tests
pass for the temporary change in the slider logic.

Change-Id: I7377a6f11aa103af76d14fea3cbb34572495192a
2017-04-05 11:24:40 +02:00
WMDE-Fisch a72b31b280 Renamed container offset variable
Change-Id: I6fc2d51f5a591dcf4898abb1ae010a433131a0d9
2017-04-03 11:05:51 +02:00
Translation updater bot 1e36399cab Localisation updates from https://translatewiki.net.
Change-Id: I9622b5753151bc668bede919eace49230fb64157
2017-04-01 22:59:55 +02:00
Translation updater bot ce08b131c4 Localisation updates from https://translatewiki.net.
Change-Id: I392e387cd812d6106a6f98d4bacb8450bf41cb0f
2017-03-28 22:56:37 +02:00
jenkins-bot 16d9e74760 Merge "Move arrow button logic to own class" 2017-03-27 22:45:37 +00:00
jenkins-bot 7abac9b03e Merge "Move helper button logic to own class" 2017-03-27 22:44:09 +00:00
WMDE-Fisch b0227f24b4 Renamed firstVisibleRevision to oldestVisibleRevison
The meaning of first in this context was totally unclear and not
very usefull. It turns out, that the "first" revision is always
the oldest and the last is always the newest revision.

Change-Id: I009438777908a5f4a8833f8f5cb7d3041057741c
2017-03-27 21:04:31 +02:00
WMDE-Fisch 97c85abdf2 Move arrow button logic to own class
Change-Id: I56e52d8b11f8557d759dc495512d9754e8f441f6
2017-03-27 18:56:59 +00:00
WMDE-Fisch 7e277fbd9d Move helper button logic to own class
Change-Id: I8fdfeb3344974b3cee7ce07bcf2ceea9308fffe6
2017-03-27 18:56:34 +00:00
jenkins-bot 216b959c75 Merge "Use tabs in json" 2017-03-27 08:18:13 +00:00
Translation updater bot 451c6e5b69 Localisation updates from https://translatewiki.net.
Change-Id: I516cd57706d777c68ace8f4c278f0c0a19617f96
2017-03-26 22:41:17 +02:00
Umherirrender 5202e7ef2b Use tabs in json
Change-Id: If29e145a10e39151a6febca23df2b298aa2b2b51
2017-03-25 10:56:02 +01:00
jenkins-bot 5abd483832 Merge "Factor out relative pointer index" 2017-03-24 14:43:25 +00:00
jenkins-bot abcd2158cd Merge "Factor out draggable options" 2017-03-24 11:00:00 +00:00
Ed Sanders b00f11ebd2 Update wgRevisionId when changed by slider
Bug: T161257
Change-Id: I1ede31dc9ce67fdc596f117f48ce4bfdde54c2cc
2017-03-23 21:48:11 +00:00
WMDE-Fisch 277d714ec3 Factor out relative pointer index
Change-Id: If0843bea19089c1a91228a0c01f8ac65e44f7f3f
2017-03-23 17:54:12 +01:00
WMDE-Fisch c2510ab082 Factor out draggable options
Change-Id: I64cca7a7547310bee64ad95f500b722c362bbb45
2017-03-23 17:42:49 +01:00
WMDE-Fisch c01d07bc1f Add documentation for new methods
Also some minor refactoring in the pointer method.

Change-Id: I986036277d2b6e65cbed9f39c81f9f03ad0e9e3c
2017-03-23 12:46:24 +01:00
WMDE-Fisch 981e9d4a7e Bundle slider construction
Change-Id: I7202755ee49d1cb42d68f997750170defdc3304c
2017-03-22 18:56:11 +01:00
WMDE-Fisch 394f812d9b Extract pointer rendering
Change-Id: I9e0200faf477c2c9476574059c46d1f8b003537b
2017-03-22 13:32:17 +00:00
WMDE-Fisch 06bb204fac Extract pointer and revisions container rendering
Change-Id: I2f65a173c2020a5a0ed276d064f0a45104982497
2017-03-22 13:32:10 +00:00
WMDE-Fisch 9c80fda6f8 Extract rendering of arrows
Change-Id: Ie639cca4bfcd3fe3f8b81556d900dbcdc3232f83
2017-03-22 13:32:02 +00:00
WMDE-Fisch e611e40833 Extract rendering of help button
Change-Id: I1db2a87c70ffce126478533836ea0ab4e21e3a08
2017-03-22 13:27:48 +00:00
WMDE-Fisch 8e361bcb36 Fix failing browser tests with new OOUI
Change-Id: I1c7c2511b3690e48c51ff1ca65a99c71185d3793
2017-03-22 14:13:01 +01:00
WMDE-Fisch f5e5c7a19c Increase browser test stability
The last times tests failed randomly at that point. The should
inrease stability there.

Change-Id: If679fc52cc501680b0f3feb6c27e3827a8b6fc6e
2017-03-21 13:35:02 +01:00
Translation updater bot 9a928bb055 Localisation updates from https://translatewiki.net.
Change-Id: I5e4678f88f00cabaff17c4ad3bb787afe8573c3e
2017-03-17 22:43:38 +01:00
addshore b3c42837b1 Document RevisionSliderBetaFeature setting
Change-Id: If7041f8e540701f2d81a3e8279d47db07db19049
2017-03-17 12:06:10 +00:00
Translation updater bot 659171ec99 Localisation updates from https://translatewiki.net.
Change-Id: Ie9e3c17ebabfa6a418c970ea7dd831c4f73ec332
2017-03-16 23:27:38 +01:00
WMDE-Fisch 89b1f8a4da Rename CSS classes for help text
The is now consistent with other CSS naming and MW rules.

Change-Id: I4bcffe2d22692d1784ebb53c49f49c94f412486f
2017-03-16 15:53:39 +01:00
jenkins-bot 5404348c81 Merge "Add rubocop rules and make it pass" 2017-03-15 13:55:51 +00:00
Translation updater bot c555565325 Localisation updates from https://translatewiki.net.
Change-Id: I6df489ec61bf805b99344028f14d343d3dea2e0e
2017-03-14 22:48:35 +01:00
addshore e530fa7ef9 Order & add extension.json authors
Order is based on number of commits.

Change-Id: Ia94cbc188c5f451b1d38ee43ddc665c05003d9e3
2017-03-08 19:55:15 +00:00
WMDE-Fisch edd9ed4dcb Add rubocop rules and make it pass
Change-Id: Ie0f7ea20c9f79a005a253b41c120ed40d884a1b8
2017-03-08 12:24:05 +01:00
WMDE-Fisch aa7daf4758 Rename $rev to $revisionContainer in ListView
Meanings are more clear now.

Change-Id: I3ff9fd0df4748c68ab363a47bda84ec8d1464fc4
2017-03-06 10:14:03 +01:00
jenkins-bot 7f851a48ca Merge "Refactor usage of OOjs UI tooltips" 2017-03-04 17:21:37 +00:00
jenkins-bot ab79b6c0f4 Merge "Fix arrow css for OOjs UI v0.19.4" 2017-03-04 17:17:11 +00:00
jenkins-bot 159b2d4290 Merge "Update tests to Selenium 3" 2017-03-04 17:13:24 +00:00
jenkins-bot 89729ad529 Merge "clean up and update gems" 2017-03-04 17:11:18 +00:00
WMDE-Fisch fbac5c69a4 Refactor usage of OOjs UI tooltips
This patch changes the way OOjs UI tooltips are constructed.
Until now we did not use the full potential of the widget.

Some strange behaviour remains and it seems we can not use
'horizontalPosition' here. Therefore the direction is passed
down to the RevisionsListView to center the tooltip manually
and margins are set for the help and arrow tooltips.

Bug: T159428
Change-Id: I0a67340da4d94f2f6b29e507f94fc695b44b71f9
2017-03-03 14:31:07 +00:00
WMDE-Fisch 2ee4d4415b Fix arrow css for OOjs UI v0.19.4
Also reordered the css so arrow related stuff is now
in the same area.

Bug: T159434
Change-Id: I851e1c208394306df0d0d595dd1131af70e946f8
Depends-On: Ifa1c6cb355a0c4f5073c93e37939cfc2f6653c81
2017-03-03 14:30:57 +00:00
WMDE-Fisch c5b214fab9 Quick fix for misplaced tooltips on RTL wikis
This is a quick fix for issues with OOjsUI v0.19.12 and tooltips
in the RevisionSlider. It can be reverted when OOjsUI v0.19.14 is
deployed.

The second problem discribed in the ticket is not fixed with this
patch.

Bug: T159428
Change-Id: Id7670b2b3ee2295a4da043bcbdf50b193a68e425
2017-03-03 09:02:20 +00:00
WMDE-Fisch dc02babd02 Increase default timeout
Improving test stability

Change-Id: Ic6fe9e55ad7d8c5e8a5a8e616f3f16ca6ea5b732
2017-03-03 09:59:57 +01:00
WMDE-Fisch 12e6631dde Update tests to Selenium 3
The waitr click on the checkbox seems to be broken or is broken with
intend since the actual OOUI checkbox has an opacity of 0.

Additionally when_visible fails when the element is not present yet.
The the way to go here seems to wait for the element to be there
and then check for visibility.

Also made use of PageObject method for checkboxes, the name selector
and the link element.

Bug: T158074
Change-Id: I2c3d6d963c8bcdc420bfbc57c1c2380bce7ef2f1
2017-03-01 17:26:12 +01:00
Translation updater bot 98ebc3ff95 Localisation updates from https://translatewiki.net.
Change-Id: Ia5335dc62dac4d77f82a3a96183720d3bf739079
2017-02-26 22:47:11 +01:00
WMDE-Fisch 8476c03a10 clean up and update gems
Looks like most of the things are not needed here.

Change-Id: I34d0abf4d1f1adac40298bafcc2f3d29f1f1d473
2017-02-22 16:09:40 +01:00
WMDE-Fisch 89345e9e8c Drop IE8 hint
Since IE8 support is dropped, remove hint for incompatibility.
Hint for IE9 is kept to keep track of possible issues.

Bug: T123218
Change-Id: I0fd066dbc22f603da733dcfa339e5af3ffbde41f
2017-02-22 14:00:13 +01:00