Commit graph

1616 commits

Author SHA1 Message Date
Ed Sanders a020b238e9 Avoid parseInt
Where we know the number contains only numerals, just cast
straight to a number using '+' operator. When getting computed
css from jQuery, use more suitable position methods instead.

Change-Id: Ia58b41a4522a1ef5a1516852821573c47e8dc9c9
2016-10-13 11:58:55 -07:00
jenkins-bot 5688a81a54 Merge "Refactor timeline browsertests" 2016-10-13 15:32:48 +00:00
jenkins-bot a77023a78b Merge "Refactor tooltips browsertests" 2016-10-13 15:31:11 +00:00
Tobias Gritschacher f3a239aa24 Refactor timeline browsertests
- Applied the Given-When-Then rule
- Added separate accessors for disabled arrow elements

Bug: T146276
Change-Id: I0278ef607f96851ed69e7373b952f5d02139cb0c
2016-10-13 15:22:57 +00:00
Tobias Gritschacher 3ca7099cc6 Refactor tooltips browsertests
- Applied the Given-When-Then rule

Bug: T146276
Change-Id: Ie9eb48cafd85ef7a00c9d9f9fd626fab5f128824
2016-10-13 15:22:46 +00:00
jenkins-bot 846fca04c2 Merge "Update beta feature screenshots to use proper layout and colours" 2016-10-13 15:21:55 +00:00
Ed Sanders 5e73b6badc Update beta feature screenshots to use proper layout and colours
Bug: T144428
Change-Id: I60e90436a6e99f7d5131b4cfe0ff4d9e956bcb94
2016-10-13 15:02:31 +00:00
WMDE-Fisch 8fef5ac005 Fix order when executing pointer update
This should always happen before updating the diff.

Change-Id: Icf6b52c3495e42e188bfa5d5307f91d0558cc7a4
2016-10-13 16:51:11 +02:00
WMDE-Fisch a111213d36 Wait for pointers to finish moving in browsertests
This will avoid checking pointer data prematurely when
they are still moving and the diff was not reloaded yet.

Change-Id: I3c29a43940e40b7c338a00b3520e5aa6b237ea4a
2016-10-13 16:41:19 +02:00
Ed Sanders d728cda396 Compute and cache directionality once
Computed CSS ($.css) is relatively slow, and directionality
should never change, so just compute it once.

Change-Id: I6519fa7f54599c498e22a348dfaedd940c860955
2016-10-12 21:07:28 -07:00
Tobias Gritschacher da8f7fb064 Update pointer position attributes immediately
Update attributes right after setting position and
don't wait until revisions are refreshed.

Change-Id: Ic32a554d6939806ce95d4e7b441ee08965b81940
2016-10-12 15:31:38 +02:00
Tobias Gritschacher 5553fe0688 Remove obsolete step
Bug: T146276
Change-Id: I9b1b8e2aa87b88bd18d58a46834e6090284314ee
2016-10-12 11:48:06 +02:00
Tobias Gritschacher 722242a600 Refactor history and pointers browsertests
- Applied the Given-When-Then rule
- Created alias for the "diff-has-loaded" step for readability
- Created higher-level step for loading the revisionslider
- Added assertions where missing
- Added ability to click the upper or lower area of revisionbars

Bug: T146276
Change-Id: Iad5abbb6e73a31afad1e2058b26ece3fbc7ad942
2016-10-12 10:46:24 +02:00
Tobias Gritschacher 70ea8fafda Always apply data-pos attribute to pointers as well
Adding position data-attribute to the pointer elements and always
apply the same value as for the revision bars they are pointing to.

This will allow us to reduce the complexity of browsertests.

Bug: T146276
Change-Id: I6e6db55204b0c45fe94a5173e297a67a7ed38d00
2016-10-10 14:52:45 +00:00
Tobias Gritschacher c2f4b64a3a Refactor help browsertest
- Applied the Given-When-Then rule
- Created alias of "close-help-dialog" step for readability

Bug: T146276
Change-Id: Icc8aeb8720025bd3c6d6bc811713fac48a9919dd
2016-10-10 14:52:24 +00:00
Translation updater bot a8e145dd42 Localisation updates from https://translatewiki.net.
Change-Id: Ifd17903343e135b13c92c00c94511e35fec63698
2016-10-09 22:55:15 +02:00
Tobias Gritschacher eeedd58f56 Refactor expand browsertests
- Applied the Given-When-Then rule to scenarios
- Added alias for one step for better readability of scenarios

Bug: T146276
Change-Id: I08aabda113d6ad9f1bbf06161484143549b13a7c
2016-10-07 16:11:12 +02:00
Tobias Gritschacher c7781efd34 Refactor autoexpand browsertests
- Applied the Given-When-Then rule to scenarios
- Small renaming of steps

Bug: T146276
Change-Id: I873be448f9b472aa7438bf525f79c403e1346641
2016-10-07 15:57:58 +02:00
jenkins-bot 6f1e1fbcc3 Merge "Only load when revisions are from the same title" 2016-10-05 09:28:22 +00:00
Translation updater bot b49f734bf4 Localisation updates from https://translatewiki.net.
Change-Id: I4382e327559db4815562fcfdbc9b26027520f18f
2016-10-04 22:40:48 +02:00
addshore 7cd9e7b36a Only load when revisions are from the same title
Bug: T147059
Change-Id: If5e3c89a6691dffbdbdeb1fcf81c3477587094bc
2016-10-04 17:47:55 +01:00
Translation updater bot 1f8f43e27e Localisation updates from https://translatewiki.net.
Change-Id: I546aa00eb3d2c8e032a26eedecbb0595d8888f6a
2016-10-02 10:41:11 +02:00
jenkins-bot 9eb29ee156 Merge "Add fixed padding for scrollbar" 2016-09-29 09:43:36 +00:00
Translation updater bot 1dbb54cc42 Localisation updates from https://translatewiki.net.
Change-Id: Ib5cba6d5a80463314db80bca02b126d06f9d83a6
2016-09-28 22:26:46 +02:00
Tobias Gritschacher 4872d31669 Add fixed padding for scrollbar
This is not very nice but the simplest I was able to come up with.

Bug: T144267
Change-Id: I959c8e6e7aa053f372455b1ec4ed5768a02d8b5d
2016-09-28 14:27:51 +02:00
Translation updater bot cce5cd63fd Localisation updates from https://translatewiki.net.
Change-Id: I2b96ebc18d10e5ef252e0f8f8c52b3247ec7071c
2016-09-26 22:42:07 +02:00
jenkins-bot 82a7af9be5 Merge "Fix pin button style" 2016-09-26 08:20:06 +00:00
Translation updater bot 9a96f4bbdc Localisation updates from https://translatewiki.net.
Change-Id: Ia14deb8b3e6990992d42f05131f8f1013801c202
2016-09-25 22:24:55 +02:00
Translation updater bot 918d8b8293 Localisation updates from https://translatewiki.net.
Change-Id: I09185185c38f6f239b76340ef3630b08c6fb48da
2016-09-24 22:42:18 +02:00
Translation updater bot 7d9dd20be1 Localisation updates from https://translatewiki.net.
Change-Id: I9505c79e2ddd1d3fd909e75b17c67bab319d8999
2016-09-23 22:36:04 +02:00
Translation updater bot 645ca15e6a Localisation updates from https://translatewiki.net.
Change-Id: I331d19f53890a90053b63e95504f4f94eae954c5
2016-09-22 23:41:24 +02:00
Translation updater bot 2a716772f0 Localisation updates from https://translatewiki.net.
Change-Id: I7b6b2f2e332579c5783ab77fb24c77e3139666b0
2016-09-20 22:40:37 +02:00
jenkins-bot ed549dfaba Merge "Follow-up I9fe75a04: Use natural language for beta feature title" 2016-09-20 14:50:40 +00:00
addshore 5c9b9f7eb4 Fix pin button style
Bug: T145519
Change-Id: I1fdc0ec32b223732d59640a6462758c59b99ebac
2016-09-20 12:35:30 +02:00
Ed Sanders a97c4d1c0e Use word-break to avoid horizontal scrollbars inside popups
Bug: T144267
Change-Id: If946b2a71dfede4cf33a513b3fad974517d4359f
2016-09-19 17:36:10 -07:00
Ed Sanders be60e36c06 Follow-up I9fe75a04: Use natural language for beta feature title
Change-Id: Ib97977e2c448ec4ec1fd4c41d0f982d05bf56437
2016-09-19 17:24:25 -07:00
Translation updater bot 4dd5125ed8 Localisation updates from https://translatewiki.net.
Change-Id: I3019d7c8c5163faa2d4e42d2586a1d249b477777
2016-09-19 22:59:47 +02:00
Translation updater bot d3334cfc36 Localisation updates from https://translatewiki.net.
Change-Id: I7fb2ae04a9d48f2e0666686ce81e6acefbd9ffd7
2016-09-17 23:21:56 +02:00
Translation updater bot 463ed9d9fb Localisation updates from https://translatewiki.net.
Change-Id: I7356c19ec02553c675f4a5e78b013802681a80d0
2016-09-15 23:02:39 +02:00
jenkins-bot a79bccf2ea Merge "Close HelpDialouge when clicking away from it" 2016-09-15 10:14:33 +00:00
jenkins-bot de1b2b37ca Merge "Adjust pin button tooltip" 2016-09-15 10:03:09 +00:00
addshore 22556fcf16 Close HelpDialouge when clicking away from it
Bug: T145525
Change-Id: Ia21d5163f561ede4f327eec3a4aaf7c34d103094
2016-09-15 12:01:08 +02:00
Tobi Gritschacher 12c0cd294c Adjust pin button tooltip
Bug: T145068
Change-Id: Ic675324fd4286123794647151afa12a5166f9cfe
2016-09-15 11:54:43 +02:00
jenkins-bot dec6b85652 Merge "Fire wikipage.diff instead of revslider.diffreload" 2016-09-15 09:04:54 +00:00
Translation updater bot e4b409c5db Localisation updates from https://translatewiki.net.
Change-Id: Ibccefbd0b407bb08af823cde1621740ecdac7aa7
2016-09-14 22:36:59 +02:00
jenkins-bot cce4ff706c Merge "Expand Revision Slider when user activates pin button" 2016-09-14 09:18:42 +00:00
Translation updater bot f66e44f21a Localisation updates from https://translatewiki.net.
Change-Id: I8dced90f84fa98217e7ed57963175b7be2f96a4b
2016-09-13 22:55:41 +02:00
jenkins-bot 78b43fd79d Merge "Manually fix nl revisionslider-tutorial i18n msg" 2016-09-13 17:03:22 +00:00
addshore 71a408924c Manually fix nl revisionslider-tutorial i18n msg
This comes frmo a suggestion in IRC.
This patch is here so that it will deployed
with this weeks train.
This message has also been fixed on translate wiki.

Bug: T145513
Change-Id: Ia5c6ae788283b2fc7aacbf700da87f1864cb4d5d
2016-09-13 18:17:46 +02:00
jenkins-bot 9aabbb4ae4 Merge "Fix position from top of tuitorial" 2016-09-13 16:07:20 +00:00