Commit graph

1542 commits

Author SHA1 Message Date
WMDE-Fisch edd9ed4dcb Add rubocop rules and make it pass
Change-Id: Ie0f7ea20c9f79a005a253b41c120ed40d884a1b8
2017-03-08 12:24:05 +01:00
WMDE-Fisch aa7daf4758 Rename $rev to $revisionContainer in ListView
Meanings are more clear now.

Change-Id: I3ff9fd0df4748c68ab363a47bda84ec8d1464fc4
2017-03-06 10:14:03 +01:00
jenkins-bot 7f851a48ca Merge "Refactor usage of OOjs UI tooltips" 2017-03-04 17:21:37 +00:00
jenkins-bot ab79b6c0f4 Merge "Fix arrow css for OOjs UI v0.19.4" 2017-03-04 17:17:11 +00:00
jenkins-bot 159b2d4290 Merge "Update tests to Selenium 3" 2017-03-04 17:13:24 +00:00
jenkins-bot 89729ad529 Merge "clean up and update gems" 2017-03-04 17:11:18 +00:00
WMDE-Fisch fbac5c69a4 Refactor usage of OOjs UI tooltips
This patch changes the way OOjs UI tooltips are constructed.
Until now we did not use the full potential of the widget.

Some strange behaviour remains and it seems we can not use
'horizontalPosition' here. Therefore the direction is passed
down to the RevisionsListView to center the tooltip manually
and margins are set for the help and arrow tooltips.

Bug: T159428
Change-Id: I0a67340da4d94f2f6b29e507f94fc695b44b71f9
2017-03-03 14:31:07 +00:00
WMDE-Fisch 2ee4d4415b Fix arrow css for OOjs UI v0.19.4
Also reordered the css so arrow related stuff is now
in the same area.

Bug: T159434
Change-Id: I851e1c208394306df0d0d595dd1131af70e946f8
Depends-On: Ifa1c6cb355a0c4f5073c93e37939cfc2f6653c81
2017-03-03 14:30:57 +00:00
WMDE-Fisch c5b214fab9 Quick fix for misplaced tooltips on RTL wikis
This is a quick fix for issues with OOjsUI v0.19.12 and tooltips
in the RevisionSlider. It can be reverted when OOjsUI v0.19.14 is
deployed.

The second problem discribed in the ticket is not fixed with this
patch.

Bug: T159428
Change-Id: Id7670b2b3ee2295a4da043bcbdf50b193a68e425
2017-03-03 09:02:20 +00:00
WMDE-Fisch dc02babd02 Increase default timeout
Improving test stability

Change-Id: Ic6fe9e55ad7d8c5e8a5a8e616f3f16ca6ea5b732
2017-03-03 09:59:57 +01:00
WMDE-Fisch 12e6631dde Update tests to Selenium 3
The waitr click on the checkbox seems to be broken or is broken with
intend since the actual OOUI checkbox has an opacity of 0.

Additionally when_visible fails when the element is not present yet.
The the way to go here seems to wait for the element to be there
and then check for visibility.

Also made use of PageObject method for checkboxes, the name selector
and the link element.

Bug: T158074
Change-Id: I2c3d6d963c8bcdc420bfbc57c1c2380bce7ef2f1
2017-03-01 17:26:12 +01:00
Translation updater bot 98ebc3ff95 Localisation updates from https://translatewiki.net.
Change-Id: Ia5335dc62dac4d77f82a3a96183720d3bf739079
2017-02-26 22:47:11 +01:00
WMDE-Fisch 8476c03a10 clean up and update gems
Looks like most of the things are not needed here.

Change-Id: I34d0abf4d1f1adac40298bafcc2f3d29f1f1d473
2017-02-22 16:09:40 +01:00
WMDE-Fisch 89345e9e8c Drop IE8 hint
Since IE8 support is dropped, remove hint for incompatibility.
Hint for IE9 is kept to keep track of possible issues.

Bug: T123218
Change-Id: I0fd066dbc22f603da733dcfa339e5af3ffbde41f
2017-02-22 14:00:13 +01:00
Translation updater bot e03f4c3c88 Localisation updates from https://translatewiki.net.
Change-Id: Ie35b021c94370ea2b28594001e6813bad054321f
2017-02-20 23:54:06 +01:00
Translation updater bot c012862db6 Localisation updates from https://translatewiki.net.
Change-Id: I139b0dece98b9bf8f7c9a2355003c79c48528ed8
2017-02-19 22:44:08 +01:00
James D. Forrester 8f34233c69 build: Bump stylelint and make pass
grunt-stylelint              0.6.0  →   0.7.0
 stylelint-config-wikimedia   0.3.0  →   0.4.1

Change-Id: Id87b8df04d415e1f1058a4042a31408236402037
2017-02-17 16:22:57 -08:00
Translation updater bot 00723753b1 Localisation updates from https://translatewiki.net.
Change-Id: Ic9a24a773cff83e9aed3849af31fdbcd38276e8e
2017-02-17 22:47:19 +01:00
Translation updater bot ae411e5aa0 Localisation updates from https://translatewiki.net.
Change-Id: I7a7a4de922d086a7a7d47a4ba540fcb3bf7b2e22
2017-02-15 22:39:57 +01:00
Translation updater bot 5063cd6c0d Localisation updates from https://translatewiki.net.
Change-Id: Ibe8e8d81644eba8377e23391fdccd5eff8c2add0
2017-02-12 22:35:17 +01:00
Tobias Gritschacher ccab029670 Don't set min-height and min-width for oo-ui buttons
OOJS-UI 0.19.0 introduced min-height and min-width for
oo-ui-buttonElement in which caused our UI elements to be mis-dimentioned.

Bug: 157800
Change-Id: I24b4d2ff6abfe02581b99b48a622972e7ef2f6b1
2017-02-10 15:32:48 +01:00
Translation updater bot 72d9d14cd6 Localisation updates from https://translatewiki.net.
Change-Id: I0ff8790fd4faa55833dadaef2c77930c5c1113a8
2017-02-05 22:50:19 +01:00
Translation updater bot 7d4f25c807 Localisation updates from https://translatewiki.net.
Change-Id: I6cfe8a1cef272ae07d752a3df211989fe1aeb1b8
2017-02-04 22:53:31 +01:00
Translation updater bot 872a1854cb Localisation updates from https://translatewiki.net.
Change-Id: I108acdbf319a8f1eab07f621935eb90f30a9326e
2017-02-03 22:58:34 +01:00
addshore ce4bc18569 Attach to Newer / Older edit links
This now attaches the revisionslider to the
older and new links that are by default in the
diff.

This means when clicking them the revision slider
will use an ajax call to reload the diff (while moving
its own pointes) rather than reloading the whole page

Change-Id: I11fa92828140f980ca8edee27403a4e2a5f5a6a7
2017-02-03 15:06:20 +00:00
jenkins-bot 3f688ebf27 Merge "Remove WikEdDiff logging code" 2017-02-02 16:54:52 +00:00
addshore 4225951117 Remove WikEdDiff logging code
Change-Id: I898234d72f496d0ce7299f18c121faf2fe174645
2017-02-02 16:26:09 +00:00
jenkins-bot 95c50b0522 Merge "Switch BF links to meta WMDE_Technical_Wishes/RevisionSlider" 2017-01-30 13:47:08 +00:00
jenkins-bot 26dfdce687 Merge "Introduce ESC key detection during dragging RevisionSlider" 2017-01-30 13:32:53 +00:00
addshore 99ce25ab73 Switch BF links to meta WMDE_Technical_Wishes/RevisionSlider
Change-Id: Ibdb3093c1fc22e9119c4a24d9343b8c6e7b7035d
2017-01-30 12:58:14 +00:00
Fomafix 5176e2f7fa Remove unrecognized parameter uslimit from API request
The current API request with uslimit=500 generates a warning in the response:

{"warnings":{"main":{"*":"Unrecognized parameter: uslimit."}}...

Change-Id: I5bb5e505f3f7b64cdf71b3ef0e2084075988aad2
2017-01-28 13:34:30 +01:00
Fomafix 8100318ad9 Use formatversion=2 for API request
The changes in the response (invalid:true instead of invalid:"" and UTF-8
encoding instead of JSON escaping) does not matter here.

Change-Id: I0b2382e373527973c8cbc75ce9213b3b6e9dafb9
2017-01-28 12:39:47 +01:00
Translation updater bot 9619a97708 Localisation updates from https://translatewiki.net.
Change-Id: If2753bc6e9128bdb39871ff6bb42ff0b73076778
2017-01-25 14:41:17 +01:00
jenkins-bot 05cd9e0f74 Merge "build: Re-use MessageDirs in banana conf" 2017-01-24 08:06:35 +00:00
Translation updater bot 0cfb886a74 Localisation updates from https://translatewiki.net.
Change-Id: Id3ff442c85f0bc02a108749d144f659f532cadbd
2017-01-23 22:43:17 +01:00
Ed Sanders 3dbd4fb2b7 build: Re-use MessageDirs in banana conf
Change-Id: I24397a8869d5661b7fbf6ea8f678a909c14ac782
2017-01-23 14:06:05 +00:00
pppery b169f6237a Introduce ESC key detection during dragging RevisionSlider
When the ESC key is pressed, aborts the drag and returns the sliders to
their original positions

Bug: T140965
Depends-On: Ib0f386c6a2447740f44591be70c34cf4a83b88c4
Change-Id: I2dfc2fa03d2c7705fa2947dffa07fbce8ed3b185
2017-01-23 09:51:52 +00:00
addshore 7d1d445417 Remove redundant phan exclude_file_list check
Change-Id: I12a1486ea034c5372516dbf77b1e19e9df078d4f
2017-01-20 15:02:14 +00:00
jenkins-bot fef3b044e5 Merge "All connector-lines should be contained within the RevisionSlider" 2017-01-16 14:34:27 +00:00
Andrew-WMDE 37ea49b326 All connector-lines should be contained within the RevisionSlider
Bug: T151450
Change-Id: I317a2fc81a85d20cf07b1e45d5501cadaaa0b727
2017-01-13 12:18:22 +01:00
jenkins-bot d8a6bd5396 Merge "Add phan issues to gitignore" 2017-01-11 08:38:29 +00:00
addshore 12c6010de5 Require MW 1.25+
This extension uses extension registration...

Change-Id: Ice7a7ba6b69a2fcb3c9f6ebcf5ef89a1dd8589bf
2017-01-06 14:54:15 +00:00
WMDE-Fisch 5bd599b3b8 Add phan issues to gitignore
Change-Id: I80d3877bf96b78123e59328c6ec243da6a085b15
2017-01-04 15:19:26 +01:00
addshore 20e0d5a779 Add Phan config
See: https://www.mediawiki.org/wiki/Continuous_integration/Phan

Change-Id: I2e870d3e8994025e19d47a32b1ff229fbf2695bf
2017-01-04 11:02:04 +00:00
addshore 6755c1b0ce Move RevisionSliderHooks class to src dir
Change-Id: I57a52c8f82180c715cbe97f4f4dd8a765992e482
2017-01-03 19:26:33 +00:00
Translation updater bot bbcca62fe2 Localisation updates from https://translatewiki.net.
Change-Id: I530b14b4228faaccf857470ae17559809d05f568
2016-12-28 10:49:37 +01:00
Leszek Manicki 4705c81e58 Pin eslint version
Same as core did in I1c76dacd0950100825b85a3791f74c1f6d5477d9

Change-Id: Id977f752afd9a5bf48f4f5e40c7116df816e0de4
2016-12-21 08:56:07 +01:00
jenkins-bot cd602086c8 Merge "Check if QUnit tests are language-setting-proof" 2016-12-20 15:53:51 +00:00
jenkins-bot 6768cda9ee Merge "Revert "Reset custom separator transform tables in number formatting tests"" 2016-12-20 13:55:41 +00:00
Tobias Gritschacher 233b69ccbf Check if QUnit tests are language-setting-proof
Change-Id: I6ed0cc013db676a587f734c1f35f117525405db7
2016-12-20 14:44:56 +01:00