Commit graph

1588 commits

Author SHA1 Message Date
Tobias Gritschacher effdcca08a RevisionSlider should always be on top of the page
E.g. in combination with FlaggedRevs extension, the RevisionSlider
was positioned between FlaggedRevs headers and diffs which looked odd.

Still todo: in combination with FlaggedRevs there is still an issue
with the connector-lines that should be fixed.

Bug: T151450
Change-Id: Ieb1a21549092063729f66656127f59918ec07c90
2016-12-14 10:38:42 +00:00
addshore a21c586762 Load bar arrow on left for RTL languages
Bug: T152913
Change-Id: Ic79be04f8345057ff66ceac6c8fd748682b03a79
2016-12-14 10:38:32 +00:00
Leszek Manicki b46c105202 Reset custom separator transform tables in number formatting tests
Looks like custom settings used in a test for number separator
transformation added in Icc9bc09675151645055c7e7f706472a15cc81b0f
influenced RevisonSlider's tests resulting in test failure if
that core test was run before RS test.
Relevant RevisionSlider tests now are ignoring any custom value.
Any value before the test is restored after the test run, though,
in case other tests relied on this (which does not seem to be a case).

Bug: T153121
Change-Id: Ida81b93e4d081b6948e760995a92d182ad79fe0f
2016-12-14 11:23:28 +01:00
Translation updater bot 1d459dbfa9 Localisation updates from https://translatewiki.net.
Change-Id: Ie44953c2b72f917496e2a62dad8795a63e934ce0
2016-12-13 22:45:11 +01:00
Translation updater bot ddc734aa73 Localisation updates from https://translatewiki.net.
Change-Id: I90b2a34107ee888b9e26ede6bda366a40a65bb38
2016-12-05 22:51:34 +01:00
Translation updater bot dd604fa3d5 Localisation updates from https://translatewiki.net.
Change-Id: I8369ea89ef8fa10c850eea1a254e76d0994067c9
2016-12-04 22:39:36 +01:00
jenkins-bot ac383df079 Merge "Fix pin-button vertical alignment" 2016-11-30 13:10:10 +00:00
WMDE-Fisch bf55a214e5 Remove doubled padding
The inline padding on the widget element seems to be the original reason
for the flickering. To reflect the CSS it needed to be moved to the
button element.

I overlooked this when fixing the lazy load patch. 
https://gerrit.wikimedia.org/r/#/c/323193/16..17/RevisionSlider.hooks.php

This patch fixes it by removing the now doubled padding on the 
widget element.

Change-Id: Ie904f619e8c84474653d2ba40d9f9e62e74fa9db
2016-11-30 12:25:44 +00:00
addshore 2cf768f7b7 Lazy load most of the JS
With the parent of this commit (current master)
Loading the RevisionSlider JS without it expanded increases
the request size by roughly 767KB on first request and 242KB
on subsequent requests.
The large size of the first request is mainly down the to
dependancies of the slider.

This lazy loading patch means the RevisionSlider JS
only causes an increase of 184 KB per request.

If the user has the bar expand by default the main JS will
be loaded straight away (and the lazy JS will not be).

This patch also means that when only the bar is loaded the
pin button to set auto expand will not be shown.
This will be added once the RevsionSlider is loaded.

Bug: T151668
Change-Id: I054a82e9ea2aa89326464632e744497239f7adba
2016-11-30 11:59:16 +01:00
WMDE-Fisch ee82977c1c Fix pin-button vertical alignment
Changes in https://gerrit.wikimedia.org/r/#/c/322114 did mess with
the vertical alignment of the pin-button.

Change-Id: Ie8906e69bc4c37772d0f2d36a87c099a7ad12776
2016-11-30 11:28:09 +01:00
Translation updater bot 33f84d0783 Localisation updates from https://translatewiki.net.
Change-Id: I702aa2100fc2889575c427d8086e2c0c443c25f4
2016-11-28 22:31:14 +01:00
Leszek Manicki f97b572c27 Add missing dependency on mw.Uri
Bug: T151747
Change-Id: Ibefeb151661727b817482207ae043f2361e0190b
2016-11-28 12:40:32 +01:00
Translation updater bot 9fa985f6f8 Localisation updates from https://translatewiki.net.
Change-Id: I98307ca7106d376e4dfa42b0f0686c99e112c9fc
2016-11-27 22:32:14 +01:00
Translation updater bot cc47561acf Localisation updates from https://translatewiki.net.
Change-Id: Ifec8a48de0a509aab8528fad69a3ce98b2d1d3b1
2016-11-25 22:53:33 +01:00
Tobias Gritschacher c7d806b175 Don't show opt-out preference for betafeature
Bug: T151452
Change-Id: I8c80afc1c05180a3ff28234db92e117b82a82348
2016-11-25 10:06:03 +01:00
Translation updater bot 6a81eaaa74 Localisation updates from https://translatewiki.net.
Change-Id: Id1835faa12e25448d13ee36499d2715f333b9320
2016-11-24 22:21:55 +01:00
jenkins-bot 40f4020ccb Merge "Fix typos in README" 2016-11-24 15:05:09 +00:00
addshore 10b8f9d2b2 Fix typos in README
Change-Id: Ie4816e5766b1f9de27490132ee7212ab3bae35f2
2016-11-24 14:53:31 +00:00
jenkins-bot a62920dbf4 Merge "User preference to disable the Extension" 2016-11-24 10:38:36 +00:00
Translation updater bot dae33ee14d Localisation updates from https://translatewiki.net.
Change-Id: Iddd91f89709829293c3915075ee80022fe319da5
2016-11-23 22:40:01 +01:00
addshore 0d4323c4a1 User preference to disable the Extension
Bug: T151452
Change-Id: I35a50a411006dca6919a50ba2d0c5f2e8bc1b2e9
2016-11-23 17:58:13 +00:00
Ed Sanders e9eabd00ef Don't replace all tabs on update
Tabs are hooked up to JS events which will break
if they are replaced, just switch out the oldid
in the edit link as that is all that changes.

Change-Id: Iea073f8d435a511ba91cdc0c7bdb9e8f1ec1d4ac
2016-11-23 13:25:32 +00:00
addshore 4ff95b9ece Fix HelpDialog.js creates a window without a static name
Bug: T151448
Change-Id: I55fa256b837b88d93755f0d20dac897f55b03fcc
2016-11-23 12:04:50 +00:00
addshore 17caad54ca Use mw.Map#get instead of mw.Map#values
Change-Id: Ifbc7f3e40190f678d6d9dad41fc161334b9b12c2
2016-11-23 00:31:53 +00:00
Ed Sanders e2e34bfd95 Fix line height in help dialog
Change-Id: I6827bc57d3372eaa6080bf7aaa351fdcf8b2d38e
2016-11-22 16:04:02 +00:00
jenkins-bot 6105fa89b8 Merge "Adjust colors to color palette" 2016-11-22 11:05:18 +00:00
WMDE-Fisch 119c66fbc4 Adjust colors to color palette
Some colors are not changed due to comments by the
UX/UI-Team.

Bug: T151193
Change-Id: I2e34b42de8633b4846a4675dabbcf48110c4ab22
2016-11-21 12:55:13 +00:00
WMDE-Fisch 6944439491 Fix word-break CSS
Change-Id: I56e783db4a68e93cb22867d3dfa5e8edd185eb5e
2016-11-21 10:56:48 +01:00
jenkins-bot 624e87f59c Merge "eslint: Remove old jshint/jscs refs, fix exceptions" 2016-11-21 08:57:58 +00:00
Translation updater bot 467aea7ad9 Localisation updates from https://translatewiki.net.
Change-Id: If7f5e2b6be7d92d0eae100e33fffb5f5cb3623e2
2016-11-20 22:20:29 +01:00
Ed Sanders 1c3ef546ad eslint: Remove old jshint/jscs refs, fix exceptions
Change-Id: I56b9f037405d0f93f82dc81dad1cc1b111be338e
2016-11-19 13:37:20 +00:00
jenkins-bot c3643df69e Merge "Fix padding for toggle button element" 2016-11-17 16:20:06 +00:00
addshore 1e8bfa62fb Fix padding for toggle button element
Bug: T150845
Change-Id: I64b9aa3b547c119410067a98df8dd2574f41e0b7
2016-11-17 15:43:26 +00:00
addshore ccc6905a05 Fix / Change autoexpand metric name
.'s in a metric name can essentially be thought of
as directories.

When building graphs from this data an * can be used to
match everything in a directory, for example:
MediaWiki.RevisionSlider.event.*

As these 2 events held another . in their name they
would ont be matched by the abov wild card, so instead use
a _ so that they will!

Change-Id: I1dce9253eb9d4ccb99516683897564e14bb9a577
2016-11-17 11:02:26 +00:00
addshore fc213c8880 Flip toggle button in 2 missing cases
- The first case is when the slider is collapsed and the auto
   expand is switched on, the slider expands and now the toggle
   switches.
 - The second case is when the slider is loaded expanded, the toggle
   now loads in the correct direction

Bug: T150846
Change-Id: I75610308c9f169fb926953a12dc5108e0fba23bf
2016-11-17 10:59:40 +00:00
WMDE-Fisch f17850d6e6 Clean up logging in code
Change-Id: Iad9f6846f9a80e7c6e82d930f643a92c8f42cab6
2016-11-16 15:42:04 +01:00
James D. Forrester 3269f791f5 build: Bump eslint-config-wikimedia to v0.3.0 and make pass
Change-Id: I774e05c4393eca8b4719f335a124efcb3d2a6dd5
2016-11-15 16:48:38 -08:00
Tobias Gritschacher 518aea3ead Clean-up browsertests
- add Gemfile.lock
- use recent version of gems
- ditch README and link to wiki documentation
- clean-up environments

Change-Id: I76bb1d491911abbc0c0bb4387b436ab3ff2cebc2
2016-11-14 12:07:41 +01:00
Translation updater bot 8d6316f232 Localisation updates from https://translatewiki.net.
Change-Id: Iaacdd3c15c3241e1667f6c600059304fee3927d8
2016-11-10 23:34:47 +01:00
Tobias Gritschacher d079937e43 Fix browsertests README
Change-Id: I4ec4c22a69b4cf896b0f5a719f47ea84b7faaec3
2016-11-09 13:33:29 +01:00
WMDE-Fisch a8a129d627 Move lines into container
Bug: T149175
Change-Id: I4e231ff450661eaeaabae0fd2883914bb62101dc
2016-11-08 15:45:59 +01:00
WMDE-Fisch df9d94ca60 Draw lines between pointers and related columns
Introducing a new class that draws lines between the pointers
and the related diff columns. Lines are redrawn when pointers
were moved. A colored border is added to the diff columns and
readded when the diff changes.

Bug: T149175
Change-Id: Iadf779368c58da7779c769bda8e9bd3fc5afcffa
2016-11-08 13:46:14 +01:00
jenkins-bot bf9cde5d66 Merge "Remove negative margin" 2016-11-03 12:23:40 +00:00
WMDE-Fisch 6f8e23f7d9 Remove negative margin
The top pointer hovers a few pixel over the slider line. Thats
not intended.

Change-Id: I5424ea72ccf2828d638c1fc4e9e2e345ba7bf94e
2016-11-03 13:00:40 +01:00
jenkins-bot 53dbf1b741 Merge "Add margin to pin button" 2016-11-03 10:46:10 +00:00
Tobias Gritschacher 1bef050429 Add margin to pin button
This also fixes the "border-overlapping-issue" when hovering
the pin button in Chrome.

Bug: T145726
Bug: T145519
Change-Id: I6d3788ca5f54937f84c6a7f0fcc456ddf4b665d7
2016-11-02 14:16:02 +01:00
WMDE-Fisch c73cc114a7 Merge OOUI setting of attributes
Change-Id: I06ed509e2d47ef0369133e3c0da5b85935a9089e
2016-11-01 15:51:27 +01:00
Translation updater bot fd915fdda5 Localisation updates from https://translatewiki.net.
Change-Id: Ia312111bff1f6b3c215ba86f182956241bb929d4
2016-10-30 22:45:25 +01:00
Translation updater bot d734150fbc Localisation updates from https://translatewiki.net.
Change-Id: I4230776db94f0d5cdf72fd5b08339a1c7e8283b7
2016-10-29 22:52:10 +02:00
Translation updater bot 9a1b3d0b38 Localisation updates from https://translatewiki.net.
Change-Id: I57c3e79d622b58ac573efafa530aa602c859eafd
2016-10-27 23:21:21 +02:00