wikimedia/mediawiki-extensions-RevisionSlider

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-12-12 07:25:13 +00:00

Commit graph

Author	SHA1	Message	Date
Leszek Manicki	8e2365502b	Make RevisionList expect list of Revision object Despite its documentation the "constructor" of RevisionList tends to expect array of revision data in a format returned by API instead of array of Revision objects. Due to different name of ID fields in Revision object and in API array, if "real" Revision object is passed to RevisionList, its ID is lost. This changes RevisionList so that it only accepts an array of Revision objects. This provides better abstraction. This is basically a revert of I147270f28381038d05f8bcfd2317e8c269b2e458 which aimed at the same problem but suggested solution doesn't seem right. Change-Id: Ic45cdd3e7b707a8c6a19eecf0a84d4c11696cd1f	2016-07-05 00:01:46 +02:00
addshore	d5809a08c2	Move qunit tests to a directory Change-Id: I5aa8d951e8fb77321748af341a1a17277aad9820	2016-06-27 12:24:47 +01:00

Author

SHA1

Message

Date

Leszek Manicki

8e2365502b

Make RevisionList expect list of Revision object

Despite its documentation the "constructor" of RevisionList tends
to expect array of revision data in a format returned by API instead
of array of Revision objects.
Due to different name of ID fields in Revision object and in API array,
if "real" Revision object is passed to RevisionList, its ID is lost.

This changes RevisionList so that it only accepts an array of Revision
objects. This provides better abstraction.

This is basically a revert of I147270f28381038d05f8bcfd2317e8c269b2e458
which aimed at the same problem but suggested solution doesn't seem right.

Change-Id: Ic45cdd3e7b707a8c6a19eecf0a84d4c11696cd1f

2016-07-05 00:01:46 +02:00

addshore

d5809a08c2

Move qunit tests to a directory

Change-Id: I5aa8d951e8fb77321748af341a1a17277aad9820

2016-06-27 12:24:47 +01:00

2 commits