Commit graph

1326 commits

Author SHA1 Message Date
Thiemo Kreuz c57fe0f2b6 Get rid of all var … = function () {} declarations
… and replace them with more trivial `function …() {}`. I
believe this does not make any difference. But I feel this
makes the code a little more straightforward.

The motivation for this patch is because a few other patches
change some of these function declarations, leaving a (in my
opinion) confusing mixture of styles behind.

Change-Id: Ib8928c4176a963afcf1fee1c785dd7bdc86c9706
2020-11-12 19:23:40 +00:00
jenkins-bot 8ea37cd205 Merge "Improve some JSDoc blocks" 2020-11-12 18:43:32 +00:00
WMDE-Fisch 9386cb6f65 Improve some JSDoc blocks
- mostly fine graining Event objects referenced
- removing one obsolete parameter doc

Change-Id: I1270c4b8100da647ca0739f7f3571bd48d484137
2020-11-12 15:48:27 +01:00
jenkins-bot eb9219c1f1 Merge "Remove unnecessary module from init package" 2020-11-12 14:25:19 +00:00
WMDE-Fisch 3b3392a72f Use OutputPage from diff engine instead of global context
There seems to be no crucial reason why this was done differently.

Change-Id: Ib7ed261970bb9e3301f7657af6645a8373e39ddc
2020-11-12 13:42:43 +00:00
WMDE-Fisch e0aadec6f2 Remove unnecessary module from init package
Change-Id: Ic353bc2635376aded4ee29cc58985eec48254305
2020-11-12 13:25:20 +01:00
WMDE-Fisch 010f7d4137 Add hint for browser tests to README.md
Change-Id: I8c6875fe8d9c7895f2701e8e5021850b4f77a026
2020-11-12 11:58:40 +01:00
jenkins-bot c57d7e0741 Merge "ported tooltips.feature from ruby to node.js" 2020-11-12 08:59:02 +00:00
Svantje Lilienthal 3726c47ad2 ported tooltips.feature from ruby to node.js
Bug: T267204
Change-Id: I76f71532030afc6f12b29f117e5161b40c2f9cd1
2020-11-11 17:45:27 +00:00
Thiemo Kreuz eb4dbe36ab Trivialize Hooks::getConfig
This is cached anyway in the ConfigFactory. On top of that this
is called a single time only. The cache is not even used.

As far as I can tell this pattern was originally copied from
another extension with more than one hook handler.

Change-Id: Idb88bcba753a99d30cd52cf520257298fad7259a
2020-11-11 16:35:27 +01:00
WMDE-Fisch 60c82b496b Make use of UserOptionsLookup
Change-Id: I408600d0515ce4f06fc58ecfea0dadd2e6a0bbcc
2020-11-11 13:52:26 +01:00
WMDE-Fisch 69bf1e0dea Try with a minimum set of revisions for timeline test
Reducing the width further leads to a strange behavior were it fails.

Locally this test is about 30% faster this way.

Change-Id: I5f950041ccf0f2f326ad6d9023d300e6a344f902
2020-11-09 15:34:06 +01:00
WMDE-Fisch 4734f69efb Reduce some test revisions to minimum needed
Change-Id: I12572558a47824de284904bc24dd940281b689a9
2020-11-09 13:48:16 +01:00
jenkins-bot 08276faacc Merge "Remove redundant TODO for revision bar click tests" 2020-11-09 12:23:52 +00:00
jenkins-bot 14a654bb96 Merge "Rewrite fragile wait" 2020-11-09 12:23:51 +00:00
jenkins-bot 121fbc4734 Merge "Improve dragPointer methods and use them in history spec" 2020-11-09 12:01:00 +00:00
jenkins-bot 79ff26da88 Merge "Merge methods waiting for loaded slider" 2020-11-09 12:00:58 +00:00
Adam Wight 91772fa904 Remove redundant TODO for revision bar click tests
These are already covered by history.js

Bug: T267206
Bug: T165831
Change-Id: Ic133df6e1ba398180eb3e9d8c0e3a6d6c4997a10
2020-11-09 11:47:16 +00:00
WMDE-Fisch 457661419a Improve dragPointer methods and use them in history spec
Change-Id: I9cf69c116e20eb34e5502c1886a05230eeb2697e
2020-11-09 12:40:28 +01:00
Adam Wight 32c920c240 Rewrite fragile wait
Directly measure the jQuery animation using its custom
pseudo-selector.  Previously, we had been relying on a side-effect.

Change-Id: I0db8077e9ed86d5be025d089e0467654789bb13f
2020-11-09 11:38:47 +00:00
WMDE-Fisch 5537fb963b Merge methods waiting for loaded slider
Change-Id: I06009d372c0691d2db8356e8cd7e7e8653ff51a0
2020-11-09 12:36:35 +01:00
Adam Wight 0c9ef9d88f Port timeline browser tests to js
`aria-disabled` is a bit of a hack, but maybe more robust than
coupling to the OOUI internal class name.

Bug: T267205
Change-Id: I5c1f547f2d25d9acaa74d63da03cd215be82bd71
2020-11-09 12:04:36 +01:00
Adam Wight c9f9023873 Move loop into browser code
This seems to be much faster.

Change-Id: I6caafd5a38c0dd319b8518538663862fb8d7cec8
2020-11-09 11:44:12 +01:00
Adam Wight 11bf368fc1 Port pointers browser tests to js
Bug: T267206
Change-Id: I7419c49786de87e4dd228af9bf281f6fcf061a88
2020-11-09 11:35:48 +01:00
Andrew Kostka eb09ac07b9 Port difflinks Ruby selenium tests to NodeJS
Bug: T267199
Change-Id: I357927144c42e67cc449fd1b9ce73ecd770c1481
2020-11-09 09:53:09 +00:00
jenkins-bot 0762782b21 Merge "Compatibility with standalone chromedriver" 2020-11-09 09:49:33 +00:00
jenkins-bot 999f450086 Merge "Port history Ruby selenium tests to NodeJS" 2020-11-09 09:38:23 +00:00
WMDE-Fisch 5a8f3bce94 Port history Ruby selenium tests to NodeJS
The numbering in the content of the test revisions was slightly changed
to fit the data-pos attribute numbering in the revision tags.

Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.

Bug: T267201
Change-Id: Ifa25b881c6aa1e94a934532606c944a33f5648dd
2020-11-09 10:06:33 +01:00
Translation updater bot d341f221ee Localisation updates from https://translatewiki.net.
Change-Id: I12f922faec51f9be1fba27871a8bd8196a5bf780
2020-11-09 08:35:42 +01:00
Adam Wight 09ed1f05fe Compatibility with standalone chromedriver
I don't understand how others are running the tests, but I need this
configuration in order to run.  They also appear in the
mediawiki/core wdio.conf.js .

Bug: T180247
Change-Id: Ic75bac41e0bf3cda3b23a4489e02f1dde2300740
2020-11-06 12:04:17 +01:00
Translation updater bot 2dc2631beb Localisation updates from https://translatewiki.net.
Change-Id: Ia4ebbcf0bd6f0d43b717d050f6c00fe3e4a18e17
2020-11-06 08:34:34 +01:00
WMDE-Fisch c40f44cf2b Port expand Ruby selenium tests to NodeJS
These test do not add much value. Expanding the interface is an
essential step done in all other tests. Therefore the only test
ported is manually collapsing the interface.

Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.

Bug: T267198
Change-Id: I7beabc1a91f22dc8b7094318bf90684a3deb63f7
2020-11-05 07:34:21 +01:00
WMDE-Fisch 27e871c17b Port autoexpand Ruby selenium tests to NodeJS
Note that this is not completely cleaning up the step_definitions
from the Ruby tests. This will be done in a follow up after all
tests are ported.

Bug: T267198
Change-Id: I75baea2bd104666ba7f6a15ba79e10f7967cddb3
2020-11-04 17:04:17 +01:00
WMDE-Fisch 1d024b83ae Use a more generic function to add revisions
Change-Id: Idfebaa5c26e3b13266c6a82f7f851291d8eef30a
2020-11-04 13:49:30 +01:00
WMDE-Fisch c36d96418d Remove unneded awaits
Change-Id: I05101080d0bc4d984244d450394a19e7566ca240
2020-11-04 13:41:30 +01:00
jenkins-bot 3f011149d4 Merge "Fixed text wrapping to avoid word break in tooltip" 2020-11-04 10:02:51 +00:00
libraryupgrader f8ee4e8263 build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Change-Id: I112f97936eabb3f80b51fa79c111eeb9e5df6441
2020-11-04 09:17:37 +00:00
WMDE-Fisch 97ef338e86 Replace outdated TCB team authorship in credits
Bug: T244059
Change-Id: Ic4d0643d2e916882643ee7082510ae0a4a80779a
2020-11-03 13:41:33 +01:00
gopavasanth 748e4970f0 Fixed text wrapping to avoid word break in tooltip
Bug: T208318
Change-Id: Ib6ab38fdf99a14be237f3b611df24a9854781572
2020-11-03 16:57:31 +05:30
Translation updater bot eb65977123 Localisation updates from https://translatewiki.net.
Change-Id: I2d177c8ec198bbaa138114fb866f208c3e2524ce
2020-11-03 08:45:01 +01:00
Translation updater bot 3fe7d49baa Localisation updates from https://translatewiki.net.
Change-Id: Icc9f9ece0c7accc69cf24c048479c7dd718acdf1
2020-10-26 08:31:57 +01:00
Translation updater bot 85a66d1987 Localisation updates from https://translatewiki.net.
Change-Id: Id67058d0119c0ea5304cd0806c897330d909b8e0
2020-10-21 08:27:45 +02:00
Translation updater bot 528403f306 Localisation updates from https://translatewiki.net.
Change-Id: Ib2dcf29a5ddf961374f0134e03887b6a93732400
2020-10-20 08:31:12 +02:00
Harriet Ayugi 1a3e4888de Add /tests/selenium/log to .gitignore file
Bug: T265463
Change-Id: I7e8a638a887272eeba1c4492e55691f0fe4bfe4c
2020-10-16 10:25:44 +03:00
Translation updater bot 94af793f32 Localisation updates from https://translatewiki.net.
Change-Id: I75cc81db9fd82a25f00c21e7555c84b17384c84f
2020-10-13 08:43:37 +02:00
Translation updater bot b59d3aed7d Localisation updates from https://translatewiki.net.
Change-Id: I705e52b323eefc816ad6535eebd595ec05816cde
2020-10-05 08:43:20 +02:00
Translation updater bot d5953fd615 Localisation updates from https://translatewiki.net.
Change-Id: I3f5f09d8b3ff19d3a7db9d929fc739e48993bb59
2020-09-30 08:42:39 +02:00
Translation updater bot 1590ab6227 Localisation updates from https://translatewiki.net.
Change-Id: I3265d367e3eb1defdf396244d938605396e6984e
2020-09-29 08:19:56 +02:00
Translation updater bot 86bbf2fb3d Localisation updates from https://translatewiki.net.
Change-Id: I322482a3f7d5171293dff1ef6b9ebd2bb5662bae
2020-09-28 08:30:16 +02:00
libraryupgrader 48abddc90e build: Updating mediawiki/mediawiki-phan-config to 0.10.3
Change-Id: I0bd1a44067011377a6aa6d5f0dac62e7e3e3b949
2020-09-25 08:26:17 +00:00