Commit graph

39 commits

Author SHA1 Message Date
WMDE-Fisch 3b3392a72f Use OutputPage from diff engine instead of global context
There seems to be no crucial reason why this was done differently.

Change-Id: Ib7ed261970bb9e3301f7657af6645a8373e39ddc
2020-11-12 13:42:43 +00:00
Thiemo Kreuz eb4dbe36ab Trivialize Hooks::getConfig
This is cached anyway in the ConfigFactory. On top of that this
is called a single time only. The cache is not even used.

As far as I can tell this pattern was originally copied from
another extension with more than one hook handler.

Change-Id: Idb88bcba753a99d30cd52cf520257298fad7259a
2020-11-11 16:35:27 +01:00
WMDE-Fisch 60c82b496b Make use of UserOptionsLookup
Change-Id: I408600d0515ce4f06fc58ecfea0dadd2e6a0bbcc
2020-11-11 13:52:26 +01:00
Ed Sanders ced0fbbbb4 Use correct context for checking for MobileDiff
The title returned by DifferenceEngine::getTitle() will change with
I2120d52 (T245172).

Bug: T245172
Change-Id: I092071573a779cc20c33d25d2a495cbf1e22db4b
2020-09-17 09:29:19 +00:00
DannyS712 8e1ed89152 Update hooks to use DifferenceEngineViewHeader, require MW 1.35+
Bug: T255769
Change-Id: I0d64099dd4caffc5b9631fc743bfe229868f46a8
2020-06-24 01:15:45 +00:00
Reedy d8da8ab98a Namespace extension
Change-Id: I0cd732fc28bf2b152281f3318c17215d519c32db
2020-04-19 01:10:58 +00:00
Adam Wight 512d99e6a9 Declare QUnit test modules in extension.json
Newer, declarative syntax for QUnit test modules.

Change-Id: Ifb0064a4891293a29e9a2a9a0e34c106f7614a72
2020-03-30 00:01:22 +02:00
libraryupgrader c9240eacd1 build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.

Change-Id: I96581fb165d9c60c205f83a4d9d479e7e7a0da64
2020-01-14 11:15:55 +00:00
Timo Tijhof ad26385a59 Remove use of jquery.ui module aliases (part 2)
Follows-up f0720b6eaf which covered the ones in extension.json.

Bug: T219604
Change-Id: I8a4b5aebee6c055fb9e447e1ce393f925e00d7ee
2019-11-26 19:52:45 +00:00
jenkins-bot 4949c15d0c Merge "Replace expand icon with down indicator" 2019-08-17 13:19:45 +00:00
tzhelyazkova a5d329758a Replace expand icon with down indicator
Bug: T212803
Change-Id: Ic0ae23bbc399ce70764457bbf4d789f113fb2f48
2019-08-15 11:47:14 +02:00
Amir Sarabadani 111d108150 Merge some resource loader modules
Each RL module comes with the cost of its name + hash being sent over every
request and in the startup module increasing the time to load the page.

Bug: T229791
Change-Id: I3ae230a84112a70ab369ffbff70e173b8f07ec1a
2019-08-14 23:10:25 +02:00
Thiemo Kreuz 7eb5a10ce6 Fix capitalization of Html::element() call
Change-Id: I272901367c7ba4a12406c9f8ec7fa444f3889c0c
2018-10-24 11:40:36 +02:00
srish dd4310aece Replace loading bar of revision slider with three moving bubbles
Using rawElement function to generate a new html element for loading spinner.
This replaces the progress bar widget.

Bug: T161640
Change-Id: I949bce945def25de561c0ae0df971c3f609586ce
2018-08-14 09:31:16 +00:00
Anmol Wassan 4ab8460fde Indicator flip issue on expand/collapse
The arrow in Revision Slider flips on expand and collapse which is not according to the standard of OOUI.

Bug: T198626
Change-Id: I4205a2260e8507a09f2950566e5033bd58a74345
2018-07-04 10:41:35 +00:00
jenkins-bot 0fadc05265 Merge "Remove default "return true" from hook handlers" 2018-06-26 14:02:48 +00:00
Thiemo Kreuz c73bf149bf Remove default "return true" from hook handlers
Change-Id: I78d6d3034556a0bc513265a9f5af785a1843f229
2018-06-26 15:20:53 +02:00
WMDE-Fisch 59435b4bf4 Clean up phpcs and add function spacing check
- added function spacing checks and fixed code
- removed vendor excludes since they are part of MW-CS
- reduced extensions to php, nothing else used here

Change-Id: I8dbdede97be965313e17357fa560d1c7e04686fb
2018-06-20 17:49:54 +02:00
Umherirrender 35f1d3fc48 Add phan-taint-check-plugin
Change-Id: I19032d573a425dd9385945295428d12b11082420
2018-05-22 21:41:10 +02:00
Kunal Mehta f94fa6b851 Use SPDX 3.0 license identifier
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: I3e7a12a224f4c1563a467eeff74ba0f118aa8f00
2018-03-02 15:35:31 -08:00
Ed Sanders b1f2613d79 Use core wgDiffOldId/wgDiffNewId JS config values
Newly introduced in a469795efc5bc1c585c9f84ee289ee099833661d.
This will require MediaWiki 1.30.

Change-Id: I9897a77b24e258bf037f8ec6cafa1d0684bf867d
2017-07-18 16:16:05 +00:00
jenkins-bot 449dfdb051 Merge "Do not hook RevisonSlider into MobileDiff page" 2017-07-06 14:31:44 +00:00
WMDE-Fisch edfd885543 Remove last SliderViewTwo parts
Bug: T165747
Change-Id: I9ac410613361e567bd825f096eb12bbb3edc5cde
2017-07-05 10:22:33 +02:00
WMDE-Fisch 11caf4c828 Do not hook RevisonSlider into MobileDiff page
The RevisionSlider is not ready for the MobileDiff right now, so
do not include him on the MobileDiff page, even when the hook is
called.

Bug: T169535
Change-Id: I190a8681adad4e8605ae5c8bd69399459f364238
2017-07-03 16:56:43 +02:00
Mukunda Modell 8bea89dbdd Set onDiffViewHeader argument defaults = null
See also I1221357746f5d4ba1430bcf0bfe773202484eebc

Change-Id: I0b96a9557ed1fc0e9a74e14bc25753ecddd97d1d
2017-06-29 00:07:37 -05:00
WMDE-Fisch 557ab23aa9 Fixes to address MW PHPCS 0.9
Change-Id: Ia911d9aa0516d6619bd62f104a527b1dc1b62228
2017-06-26 11:58:50 +00:00
Andrew-WMDE 80ab1408ac Remove BetaFeature Code
Bug: T167276
Change-Id: Iad2e34e2f906777c7ba0e22e245dc55891f211ae
2017-06-23 14:45:48 +02:00
WMDE-Fisch 12e34322bc Merge SliderViewTwo CSS into main CSS
Bug: T165747
Change-Id: I1949591063bb8d2df7ddf3bc0c33247ece1bd522
2017-06-21 10:13:32 +02:00
Chad Horohoe 0687de3fbd Also drop Revision typehint from $oldRev
Already did this in $oldRev, this follows up I4c483d7

Bug: T167359
Change-Id: I8b74932caf1188005155b4cbd8a1ff76066b1604
2017-06-08 15:32:01 -07:00
aude 71c586a351 Handle possible null $oldRev in DiffViewHeader hook handler
Sometimes $oldRev can be null (e.g. not a Revision, but
maybe is a missing revision), and also not sure we can be
certain about $newRev being a Revision object.

Bug: T167359
Change-Id: I4c483d711f2ec07a918c708a473aff1b2c150cf5
2017-06-07 22:19:16 -04:00
WMDE-Fisch ae96989d0b Disable the RevisionSlider for screenreaders
Until the sliding mechanism has full support to work with screen-
readers the tool will be disabled for them to avoid unnecessary
confusion.

Bug: T165489
Change-Id: Id0da2c891040ac7e6f1b6ce5ba5f65b727d3cb07
2017-06-06 08:28:15 +00:00
Florian Schmidt 5173fe59d4 Do not use the main config for extension configuration options
This currently just works, because the currently used backend are
global variables. Once the main config uses a more scoped/focused
backend, such as a HashConfig or a database-based config, requesting
extension configurations from it will not work anymore.

Therefore, use the extensions Config object to request configuration
options for the extension.

Change-Id: Iea02d3c284f9a0e12abff33e3624dce9585ab51c
2017-05-20 11:54:52 +02:00
addshore ed48f4ef3b Split ext.RevisionSlider.lazy into Js and Css modules
Bug: T164893
Change-Id: Ideb82a24aa852067acc60e512318a26f88f2d395
2017-05-11 10:45:57 +02:00
Ed Sanders 187ba30937 Fix alignment of expand icon
Also fix loading of styles for lazy.css to avoid FOUC and
inline style hacks.

Bug: T162804
Change-Id: Ie5a462993075f87b776f8a1f0494b5fe563df079
2017-04-12 18:22:55 +01:00
WMDE-Fisch e6d28dc19d Use a new config var to activate the alternate SliderView
Change-Id: I7e2dd04c333d3b8daf9f009898f8f80b4e7aad3d
2017-04-07 11:58:19 +02:00
WMDE-Fisch b8ccbfa763 Improve SliderViewTwo load stability
In some cases there seemed to be a race condition where the SliderViewTwo
class was not loaded when the Slider class tried to use it.

Change-Id: I3f161e024bb3ed0e035cb55bd698124be31e8aa1
2017-04-06 11:23:37 +02:00
WMDE-Fisch c52c657516 Introduce alternate SliderView
Adding a new class for an alternative slider view with
one slider for each pointer. The new class will be used
when the extension is installed as a beta feature.

Each pointer has now its own pointer container visualized
with a thin line. Pointers can not change places anymore
and methods doing so where overwritten in the patch.

Selected revisions are not colored atm to better distinguish
between pointers and bars. Poiner lines are now shown above
the bars. ( as from feedback in the last PM session )

Some issues with the design might remain. But since we plan
the deployment anyway next week this could be merged if reviewed. 

Bug: T160410
Change-Id: If00c31e30f8a01f3525b191c70605b9c9381671d
2017-04-06 07:29:19 +00:00
addshore 99ce25ab73 Switch BF links to meta WMDE_Technical_Wishes/RevisionSlider
Change-Id: Ibdb3093c1fc22e9119c4a24d9343b8c6e7b7035d
2017-01-30 12:58:14 +00:00
addshore 6755c1b0ce Move RevisionSliderHooks class to src dir
Change-Id: I57a52c8f82180c715cbe97f4f4dd8a765992e482
2017-01-03 19:26:33 +00:00