This is cached anyway in the ConfigFactory. On top of that this
is called a single time only. The cache is not even used.
As far as I can tell this pattern was originally copied from
another extension with more than one hook handler.
Change-Id: Idb88bcba753a99d30cd52cf520257298fad7259a
The title returned by DifferenceEngine::getTitle() will change with
I2120d52 (T245172).
Bug: T245172
Change-Id: I092071573a779cc20c33d25d2a495cbf1e22db4b
Each RL module comes with the cost of its name + hash being sent over every
request and in the startup module increasing the time to load the page.
Bug: T229791
Change-Id: I3ae230a84112a70ab369ffbff70e173b8f07ec1a
Using rawElement function to generate a new html element for loading spinner.
This replaces the progress bar widget.
Bug: T161640
Change-Id: I949bce945def25de561c0ae0df971c3f609586ce
The arrow in Revision Slider flips on expand and collapse which is not according to the standard of OOUI.
Bug: T198626
Change-Id: I4205a2260e8507a09f2950566e5033bd58a74345
- added function spacing checks and fixed code
- removed vendor excludes since they are part of MW-CS
- reduced extensions to php, nothing else used here
Change-Id: I8dbdede97be965313e17357fa560d1c7e04686fb
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.
Bug: T183858
Change-Id: I3e7a12a224f4c1563a467eeff74ba0f118aa8f00
The RevisionSlider is not ready for the MobileDiff right now, so
do not include him on the MobileDiff page, even when the hook is
called.
Bug: T169535
Change-Id: I190a8681adad4e8605ae5c8bd69399459f364238
Sometimes $oldRev can be null (e.g. not a Revision, but
maybe is a missing revision), and also not sure we can be
certain about $newRev being a Revision object.
Bug: T167359
Change-Id: I4c483d711f2ec07a918c708a473aff1b2c150cf5
Until the sliding mechanism has full support to work with screen-
readers the tool will be disabled for them to avoid unnecessary
confusion.
Bug: T165489
Change-Id: Id0da2c891040ac7e6f1b6ce5ba5f65b727d3cb07
This currently just works, because the currently used backend are
global variables. Once the main config uses a more scoped/focused
backend, such as a HashConfig or a database-based config, requesting
extension configurations from it will not work anymore.
Therefore, use the extensions Config object to request configuration
options for the extension.
Change-Id: Iea02d3c284f9a0e12abff33e3624dce9585ab51c
In some cases there seemed to be a race condition where the SliderViewTwo
class was not loaded when the Slider class tried to use it.
Change-Id: I3f161e024bb3ed0e035cb55bd698124be31e8aa1
Adding a new class for an alternative slider view with
one slider for each pointer. The new class will be used
when the extension is installed as a beta feature.
Each pointer has now its own pointer container visualized
with a thin line. Pointers can not change places anymore
and methods doing so where overwritten in the patch.
Selected revisions are not colored atm to better distinguish
between pointers and bars. Poiner lines are now shown above
the bars. ( as from feedback in the last PM session )
Some issues with the design might remain. But since we plan
the deployment anyway next week this could be merged if reviewed.
Bug: T160410
Change-Id: If00c31e30f8a01f3525b191c70605b9c9381671d